From 146ec62a0aa62a0e6833696deaa1a3f5d729fa1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Behmo?= Date: Tue, 13 Dec 2022 09:05:13 +0100 Subject: [PATCH] feat: skip explicit openedx-dev image building in `tutor dev launch` I have no idea why we decided to kickstart a separate build. The image will be built anyway at the next step because we run `docker compose up --build` in `tutor dev start`. The build step was introduced in this PR: https://github.com/overhangio/tutor/pull/627 --- changelog.d/20221213_090356_regis_dev.md | 1 + tutor/commands/dev.py | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) create mode 100644 changelog.d/20221213_090356_regis_dev.md diff --git a/changelog.d/20221213_090356_regis_dev.md b/changelog.d/20221213_090356_regis_dev.md new file mode 100644 index 0000000..405611d --- /dev/null +++ b/changelog.d/20221213_090356_regis_dev.md @@ -0,0 +1 @@ +- [Improvement] Skip unnecessary image building in development. This should make `tutor dev launch` slightly faster. (by @regisb) diff --git a/tutor/commands/dev.py b/tutor/commands/dev.py index 4b6727c..908b75b 100644 --- a/tutor/commands/dev.py +++ b/tutor/commands/dev.py @@ -98,9 +98,6 @@ Tutor may not work if Docker is configured with < 4 GB RAM. Please follow instru click.echo(fmt.title("Docker image updates")) context.invoke(compose.dc_command, command="pull") - click.echo(fmt.title("Building Docker image for LMS and CMS development")) - context.invoke(compose.dc_command, command="build", args=["lms"]) - click.echo(fmt.title("Starting the platform in detached mode")) context.invoke(compose.start, detach=True)