From 2d6b9c17674ebcc1ebd8cc4f56c3b0413c171300 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Behmo?= Date: Mon, 17 Apr 2023 18:07:53 +0200 Subject: [PATCH] feat: hide TOS link during registration Registering a user was causing a 400 error because the LMS expected the TOS checkbox to be checked, but it's not displayed in the frontend. So we just disable it. Close https://github.com/openedx/wg-build-test-release/issues/262 --- changelog.d/20230412_100608_regis_palm.md | 1 + tutor/templates/apps/openedx/settings/partials/common_lms.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/changelog.d/20230412_100608_regis_palm.md b/changelog.d/20230412_100608_regis_palm.md index 381ba29..63fb682 100644 --- a/changelog.d/20230412_100608_regis_palm.md +++ b/changelog.d/20230412_100608_regis_palm.md @@ -1,2 +1,3 @@ - 💥[Feature] Upgrade to Palm. (by @regisb) - [Bugfix] Rename ORA2 file upload folder from "SET-ME-PLEASE (ex. bucket-name)" to "openedxuploads". This has the effect of moving the corresponding folder from the `/data/lms/ora2` directory. MinIO users were not affected by this bug. + - 💥[Improvement] During registration, the honor code and terms of service links are no longer visible by default. For most platforms, these links did not work anyway. (by @regisb) diff --git a/tutor/templates/apps/openedx/settings/partials/common_lms.py b/tutor/templates/apps/openedx/settings/partials/common_lms.py index c1ec4af..e3b8649 100644 --- a/tutor/templates/apps/openedx/settings/partials/common_lms.py +++ b/tutor/templates/apps/openedx/settings/partials/common_lms.py @@ -4,7 +4,7 @@ LOGIN_REDIRECT_WHITELIST = ["{{ CMS_HOST }}"] # Better layout of honor code/tos links during registration -REGISTRATION_EXTRA_FIELDS["terms_of_service"] = "required" +REGISTRATION_EXTRA_FIELDS["terms_of_service"] = "hidden" REGISTRATION_EXTRA_FIELDS["honor_code"] = "hidden" # Fix media files paths