From 36e2f8184504470c870e650fa49d8e62fd4bc4c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Behmo?= Date: Tue, 7 Apr 2020 15:04:34 +0200 Subject: [PATCH] Fix Android app build for domain names that include a dash See https://discuss.overhang.io/t/build-android-app-command-error/405/30 Android package names should be composed of alphanumeric or underscore characters only (https://developer.android.com/studio/build/application-id.html) --- CHANGELOG.md | 4 ++++ tutor/templates/android/gradle.properties | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ab20895..4292e4b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ Note: Breaking changes between versions are indicated by "💥". +## Unreleased + +- [Bugfix] Fix Android app build for domain names that include a dash ("-") + ## v3.11.8 (2020-04-06) - [Feature] Add `encrypt` template filter to conveniently add htpasswd-based authentication to nginx diff --git a/tutor/templates/android/gradle.properties b/tutor/templates/android/gradle.properties index 5c781bf..77f1afb 100644 --- a/tutor/templates/android/gradle.properties +++ b/tutor/templates/android/gradle.properties @@ -1,4 +1,4 @@ -APPLICATION_ID={{ LMS_HOST|reverse_host }} +APPLICATION_ID={{ LMS_HOST|reverse_host|replace("-", "_") }} RELEASE_STORE_FILE=/openedx/config/app.keystore RELEASE_STORE_PASSWORD={{ ANDROID_RELEASE_STORE_PASSWORD }} RELEASE_KEY_PASSWORD={{ ANDROID_RELEASE_KEY_PASSWORD }}