christianlight/tutor
6
0
Fork 0
mirror of https://github.com/ChristianLight/tutor.git synced 2024-12-13 14:43:03 +00:00
Code Issues Releases Activity

fix: truncate site name if longer than 50 characters and show warning

Browse Source 
Close #518
This commit is contained in:
Navin Karkera 2022-05-26 10:10:23 +05:30 committed by Régis Behmo
parent bae65ff701
commit 3890a38ca1
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -18,6 +18,7 @@ Every user-facing change should have an entry in this changelog. Please respect
## Unreleased ## Unreleased
- [Fix] Truncate site display name to 50 characters with a warning, fixing data too long error for long site names. (by @navinkarkera)
- [Feature] Add patch to allow overriding final openedx docker image CMD - [Feature] Add patch to allow overriding final openedx docker image CMD
- [Fix] Ignore Python plugins that cannot be loaded. (by @regisb) - [Fix] Ignore Python plugins that cannot be loaded. (by @regisb)
- [Improvement] Faster and more reliable builds with `npm clean-install` instead of `npm install`. (by @regisb. Thanks @ghassanmas!) - [Improvement] Faster and more reliable builds with `npm clean-install` instead of `npm install`. (by @regisb. Thanks @ghassanmas!)

9
tutor/jobs.py
View File

@ -126,11 +126,18 @@ def set_theme(
return return
python_code = "from django.contrib.sites.models import Site" python_code = "from django.contrib.sites.models import Site"
for domain_name in domain_names: for domain_name in domain_names:
if len(domain_name) > 50:
fmt.echo_alert(
"Assigning a theme to a site with a long (> 50 characters) domain name."
" The displayed site name will be truncated to 50 characters."
)
python_code += """ python_code += """
print('Assigning theme {theme_name} to {domain_name}...') print('Assigning theme {theme_name} to {domain_name}...')
site, _ = Site.objects.get_or_create(domain='{domain_name}') site, _ = Site.objects.get_or_create(domain='{domain_name}')
if not site.name: if not site.name:
site.name = '{domain_name}' name_max_length = Site._meta.get_field('name').max_length
name = '{domain_name}'[:name_max_length]
site.name = name
site.save() site.save()
site.themes.all().delete() site.themes.all().delete()
site.themes.create(theme_dir_name='{theme_name}') site.themes.create(theme_dir_name='{theme_name}')