christianlight/tutor
6
0
Fork 0
mirror of https://github.com/ChristianLight/tutor.git synced 2024-11-13 08:46:34 +00:00
Code Issues Releases Activity

fix: respect RUN_MYSQL on k8s maple upgrade

Browse Source 
During the maple -> nutmeg upgrade on k8s, only wait for mysql when RUN_MYSQL is true.
This commit is contained in:
Emad Rad 2023-01-09 15:31:48 +03:30 committed by GitHub
parent d7bc3370df
commit b903c69fac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/20230109_100009_codewithemad_upgrade_mysql_issue.md Normal file
View File

@ -0,0 +1 @@
[Bugfix] Running `tutor k8s upgrade --from=maple` won't apply and won't wait for the MySQL deployment to be ready if `RUN_MYSQL: false` (When you host your MySQL somewhere else like RDS) (by @CodeWithEmad)

15
tutor/commands/upgrade/k8s.py
View File

@ -120,13 +120,14 @@ def upgrade_from_maple(context: Context, config: Config) -> None:
# The environment needs to be updated because the backpopulate/backfill commands are from Nutmeg
tutor_env.save(context.root, config)
# Start mysql
k8s.kubectl_apply(
context.root,
"--selector",
"app.kubernetes.io/name=mysql",
)
k8s.wait_for_deployment_ready(config, "mysql")
if config["RUN_MYSQL"]:
# Start mysql
k8s.kubectl_apply(
context.root,
"--selector",
"app.kubernetes.io/name=mysql",
)
k8s.wait_for_deployment_ready(config, "mysql")
# lms upgrade
k8s.kubectl_apply(