Improve plugin data deletion

CHANGELOG.md

@@ -4,6 +4,7 @@ Note: Breaking changes between versions are indicated by "💥".
 
 ## Unreleased
 
+- [Improvement] Improve plugin data deletion
 - [Improvement] Introduce the `OPENEDX_COMMON_VERSION` setting
 - [Bugfix] Make it possible to run init jobs without starting the entire platform
 - [Improvement] Reduce "openedx" Docker image size with static asset de-duplication

tutor/commands/plugins.py

@@ -57,10 +57,7 @@ def disable(context, plugin_names):
     config = tutor_config.load_user(context.root)
     for plugin in plugin_names:
         plugins.disable(config, plugin)
-
+        delete_plugin(context.root, plugin)
-        plugin_dir = tutor_env.pathjoin(context.root, "plugins", plugin)
-        if os.path.exists(plugin_dir):
-            shutil.rmtree(plugin_dir)
         fmt.echo_info("Plugin {} disabled".format(plugin))
 
     tutor_config.save_config_file(context.root, config)
@@ -69,6 +66,19 @@ def disable(context, plugin_names):
     )
 
 
+def delete_plugin(root, name):
+    plugin_dir = tutor_env.pathjoin(root, "plugins", name)
+    if os.path.exists(plugin_dir):
+        try:
+            shutil.rmtree(plugin_dir)
+        except PermissionError as e:
+            raise exceptions.TutorError(
+                "Could not delete file {} from plugin {} in folder {}".format(
+                    e.filename, name, plugin_dir
+                )
+            )
+
+
 @click.command(
     short_help="Print the location of yaml-based plugins",
     help="""Print the location of yaml-based plugins. This location can be manually