mirror of
https://github.com/ChristianLight/tutor.git
synced 2024-11-15 01:34:14 +00:00
a2a3c022b8
The -m/--mount option makes it possible to bind-mount volumes at runtime. The volumes are declared in a local/docker-compose.tmp.yml file. The problem with this approach is when we want to bind-mount a volume to a service which is specific to the dev context. For instance: the "learning" service when the MFE plugin is enabled. In such a case, starting the service triggers a call to `docker-compose stop` in the local context. This call fails because the "learning" service does not exist in the local context. Note that this issue only seems to occur with docker-compose v1. To resolve this issue, we create two additional filters for the dev context, which emulate the behaviour of the local context. With this approach, we convert the -m/--mount arguments right after they are parsed. Because they are parsed just once, we can get rid of the de-duplication logic initially introduced with the COMPOSE_CLI_MOUNTS context. Close #711. Close also https://github.com/overhangio/tutor-mfe/issues/57.
90 lines
3.6 KiB
Python
90 lines
3.6 KiB
Python
import typing as t
|
|
import unittest
|
|
from io import StringIO
|
|
from unittest.mock import patch
|
|
|
|
from click.exceptions import ClickException
|
|
|
|
from tutor import hooks
|
|
from tutor.commands import compose
|
|
from tutor.commands.local import LocalContext
|
|
|
|
|
|
class ComposeTests(unittest.TestCase):
|
|
|
|
maxDiff = None # Ensure we can see long diffs of YAML files.
|
|
|
|
def test_mount_option_parsing(self) -> None:
|
|
param = compose.MountParam()
|
|
|
|
self.assertEqual(
|
|
[("lms", "/path/to/edx-platform", "/openedx/edx-platform")],
|
|
param("lms:/path/to/edx-platform:/openedx/edx-platform"),
|
|
)
|
|
self.assertEqual(
|
|
[
|
|
("lms", "/path/to/edx-platform", "/openedx/edx-platform"),
|
|
("cms", "/path/to/edx-platform", "/openedx/edx-platform"),
|
|
],
|
|
param("lms,cms:/path/to/edx-platform:/openedx/edx-platform"),
|
|
)
|
|
self.assertEqual(
|
|
[
|
|
("lms", "/path/to/edx-platform", "/openedx/edx-platform"),
|
|
("cms", "/path/to/edx-platform", "/openedx/edx-platform"),
|
|
],
|
|
param("lms, cms:/path/to/edx-platform:/openedx/edx-platform"),
|
|
)
|
|
self.assertEqual(
|
|
[
|
|
("lms", "/path/to/edx-platform", "/openedx/edx-platform"),
|
|
("lms-worker", "/path/to/edx-platform", "/openedx/edx-platform"),
|
|
],
|
|
param("lms,lms-worker:/path/to/edx-platform:/openedx/edx-platform"),
|
|
)
|
|
with self.assertRaises(ClickException):
|
|
param("lms,:/path/to/edx-platform:/openedx/edx-platform")
|
|
|
|
@patch("sys.stdout", new_callable=StringIO)
|
|
def test_compose_local_tmp_generation(self, _mock_stdout: StringIO) -> None:
|
|
"""
|
|
Ensure that docker-compose.tmp.yml is correctly generated.
|
|
"""
|
|
param = compose.MountParam()
|
|
mount_args = (
|
|
# Auto-mounting of edx-platform to lms* and cms*
|
|
param.convert_implicit_form("/path/to/edx-platform"),
|
|
# Manual mounting of some other folder to mfe and lms
|
|
param.convert_explicit_form(
|
|
"mfe,lms:/path/to/something-else:/openedx/something-else"
|
|
),
|
|
)
|
|
# Mount volumes
|
|
compose.mount_tmp_volumes(mount_args, LocalContext(""))
|
|
|
|
compose_file: t.Dict[str, t.Any] = hooks.Filters.COMPOSE_LOCAL_TMP.apply({})
|
|
actual_services: t.Dict[str, t.Any] = compose_file["services"]
|
|
expected_services: t.Dict[str, t.Any] = {
|
|
"cms": {"volumes": ["/path/to/edx-platform:/openedx/edx-platform"]},
|
|
"cms-worker": {"volumes": ["/path/to/edx-platform:/openedx/edx-platform"]},
|
|
"lms": {
|
|
"volumes": [
|
|
"/path/to/edx-platform:/openedx/edx-platform",
|
|
"/path/to/something-else:/openedx/something-else",
|
|
]
|
|
},
|
|
"lms-worker": {"volumes": ["/path/to/edx-platform:/openedx/edx-platform"]},
|
|
"mfe": {"volumes": ["/path/to/something-else:/openedx/something-else"]},
|
|
}
|
|
self.assertEqual(actual_services, expected_services)
|
|
|
|
compose_jobs_file: t.Dict[
|
|
str, t.Any
|
|
] = hooks.Filters.COMPOSE_LOCAL_JOBS_TMP.apply({})
|
|
actual_jobs_services: t.Dict[str, t.Any] = compose_jobs_file["services"]
|
|
expected_jobs_services: t.Dict[str, t.Any] = {
|
|
"cms-job": {"volumes": ["/path/to/edx-platform:/openedx/edx-platform"]},
|
|
"lms-job": {"volumes": ["/path/to/edx-platform:/openedx/edx-platform"]},
|
|
}
|
|
self.assertEqual(actual_jobs_services, expected_jobs_services)
|