mirror of
https://github.com/ChristianLight/tutor.git
synced 2024-11-16 01:57:16 +00:00
15b219e235
This is a very large refactoring which aims at making Tutor both more extendable and more generic. Historically, the Tutor plugin system was designed as an ad-hoc solution to allow developers to modify their own Open edX platforms without having to fork Tutor. The plugin API was simple, but limited, because of its ad-hoc nature. As a consequence, there were many things that plugin developers could not do, such as extending different parts of the CLI or adding custom template filters. Here, we refactor the whole codebase to make use of a generic plugin system. This system was inspired by the Wordpress plugin API and the Open edX "hooks and filters" API. The various components are added to a small core thanks to a set of actions and filters. Actions are callback functions that can be triggered at different points of the application lifecycle. Filters are functions that modify some data. Both actions and filters are collectively named as "hooks". Hooks can optionally be created within a certain context, which makes it easier to keep track of which application created which callback. This new hooks system allows us to provide a Python API that developers can use to extend their applications. The API reference is added to the documentation, along with a new plugin development tutorial. The plugin v0 API remains supported for backward compatibility of existing plugins. Done: - Do not load commands from plugins which are not enabled. - Load enabled plugins once on start. - Implement contexts for actions and filters, which allow us to keep track of the source of every hook. - Migrate patches - Migrate commands - Migrate plugin detection - Migrate templates_root - Migrate config - Migrate template environment globals and filters - Migrate hooks to tasks - Generate hook documentation - Generate patch reference documentation - Add the concept of action priority Close #499.
138 lines
4.6 KiB
Makefile
138 lines
4.6 KiB
Makefile
.DEFAULT_GOAL := help
|
||
.PHONY: docs
|
||
SRC_DIRS = ./tutor ./tests ./bin ./docs
|
||
BLACK_OPTS = --exclude templates ${SRC_DIRS}
|
||
|
||
###### Development
|
||
|
||
docs: ## Build HTML documentation
|
||
$(MAKE) -C docs
|
||
|
||
compile-requirements: ## Compile requirements files
|
||
pip-compile requirements/base.in
|
||
pip-compile requirements/dev.in
|
||
pip-compile requirements/docs.in
|
||
|
||
upgrade-requirements: ## Upgrade requirements files
|
||
pip-compile --upgrade requirements/base.in
|
||
pip-compile --upgrade requirements/dev.in
|
||
pip-compile --upgrade requirements/docs.in
|
||
|
||
build-pythonpackage: build-pythonpackage-tutor ## Build Python packages ready to upload to pypi
|
||
|
||
build-pythonpackage-tutor: ## Build the "tutor" python package for upload to pypi
|
||
python setup.py sdist
|
||
|
||
push-pythonpackage: ## Push python package to pypi
|
||
twine upload --skip-existing dist/tutor-$(shell make version).tar.gz
|
||
|
||
test: test-lint test-unit test-types test-format test-pythonpackage ## Run all tests by decreasing order of priority
|
||
|
||
test-static: test-lint test-types test-format ## Run only static tests
|
||
|
||
test-format: ## Run code formatting tests
|
||
black --check --diff $(BLACK_OPTS)
|
||
|
||
test-lint: ## Run code linting tests
|
||
pylint --errors-only --enable=unused-import,unused-argument --ignore=templates --ignore=docs/_ext ${SRC_DIRS}
|
||
|
||
test-unit: ## Run unit tests
|
||
python -m unittest discover tests
|
||
|
||
test-types: ## Check type definitions
|
||
mypy --exclude=templates --ignore-missing-imports --strict ${SRC_DIRS}
|
||
|
||
test-pythonpackage: build-pythonpackage ## Test that package can be uploaded to pypi
|
||
twine check dist/tutor-$(shell make version).tar.gz
|
||
|
||
test-k8s: ## Validate the k8s format with kubectl. Not part of the standard test suite.
|
||
tutor k8s apply --dry-run=client --validate=true
|
||
|
||
format: ## Format code automatically
|
||
black $(BLACK_OPTS)
|
||
|
||
isort: ## Sort imports. This target is not mandatory because the output may be incompatible with black formatting. Provided for convenience purposes.
|
||
isort --skip=templates ${SRC_DIRS}
|
||
|
||
bootstrap-dev: ## Install dev requirements
|
||
pip install .
|
||
pip install -r requirements/dev.txt
|
||
|
||
bootstrap-dev-plugins: bootstrap-dev ## Install dev requirements and all supported plugins
|
||
pip install -r requirements/plugins.txt
|
||
|
||
###### Code coverage
|
||
|
||
coverage: ## Run unit-tests before analyzing code coverage and generate report
|
||
$(MAKE) --keep-going coverage-tests coverage-report
|
||
|
||
coverage-tests: ## Run unit-tests and analyze code coverage
|
||
coverage run -m unittest discover
|
||
|
||
coverage-report: ## Generate CLI report for the code coverage
|
||
coverage report
|
||
|
||
coverage-html: coverage-report ## Generate HTML report for the code coverage
|
||
coverage html
|
||
|
||
coverage-browse-report: coverage-html ## Open the HTML report in the browser
|
||
sensible-browser htmlcov/index.html
|
||
|
||
###### Deployment
|
||
|
||
bundle: ## Bundle the tutor package in a single "dist/tutor" executable
|
||
pyinstaller tutor.spec
|
||
|
||
release: test release-unsafe ## Create a release tag and push it to origin
|
||
release-unsafe:
|
||
$(MAKE) release-tag release-push TAG=v$(shell make version)
|
||
release-tag:
|
||
@echo "=== Creating tag $(TAG)"
|
||
git tag -d $(TAG) || true
|
||
git tag $(TAG)
|
||
release-push:
|
||
@echo "=== Pushing tag $(TAG) to origin"
|
||
git push origin
|
||
git push origin :$(TAG) || true
|
||
git push origin $(TAG)
|
||
|
||
release-description: ## Write the current release description to a file
|
||
sed "s/TUTOR_VERSION/v$(shell make version)/g" docs/_release_description.md > release_description.md
|
||
git log -1 --pretty=format:%b >> release_description.md
|
||
|
||
###### Continuous integration tasks
|
||
|
||
pull-base-images: # Manually pull base images
|
||
docker image pull docker.io/ubuntu:20.04
|
||
docker image pull docker.io/python:3.7-alpine
|
||
|
||
ci-info: ## Print info about environment
|
||
python --version
|
||
pip --version
|
||
|
||
ci-test-bundle: ## Run basic tests on bundle
|
||
ls -lh ./dist/tutor
|
||
./dist/tutor --version
|
||
./dist/tutor config printroot
|
||
yes "" | ./dist/tutor config save --interactive
|
||
./dist/tutor config save
|
||
./dist/tutor plugins list
|
||
./dist/tutor plugins enable android discovery ecommerce forum license mfe minio notes richie webui xqueue
|
||
./dist/tutor plugins list
|
||
./dist/tutor license --help
|
||
|
||
ci-bootstrap-images:
|
||
pip install .
|
||
tutor config save
|
||
|
||
###### Additional commands
|
||
|
||
version: ## Print the current tutor version
|
||
@python -c 'import io, os; about = {}; exec(io.open(os.path.join("tutor", "__about__.py"), "rt", encoding="utf-8").read(), about); print(about["__package_version__"])'
|
||
|
||
ESCAPE =
|
||
help: ## Print this help
|
||
@grep -E '^([a-zA-Z_-]+:.*?## .*|######* .+)$$' Makefile \
|
||
| sed 's/######* \(.*\)/@ $(ESCAPE)[1;31m\1$(ESCAPE)[0m/g' | tr '@' '\n' \
|
||
| awk 'BEGIN {FS = ":.*?## "}; {printf "\033[33m%-30s\033[0m %s\n", $$1, $$2}'
|