joomla/Component-Builder
40
26
Fork 12
Code Issues 78 Pull Requests 2 Projects 4 Wiki Activity

Resolved gh-364 to allow greater depth and ensure that all custom code placeholders are always update/replaced at any depth layer. Tweaked the editURL method to also handle access control permissions.

Browse Source
This commit is contained in:
Llewellyn van der Merwe
2019-01-22 00:58:22 +02:00
parent 4e2c51c303
commit 5c2f0aec63
7 changed files with 22 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
admin/helpers/compiler/a_Get.php
View File

@@ -4915,7 +4915,7 @@ class Get
// when the custom code is loaded
if ($loaded === true)
{
$string = $this->insertCustomCode($string, $debug);
$string = $this->insertCustomCode($bucket, $string, $debug);
}
// if debug
if ($debug)
@@ -4936,19 +4936,13 @@ class Get
* @return string on success
*
*/
protected function insertCustomCode($string, $debug = 0)
protected function insertCustomCode($ids, $string, $debug = 0)
{
$code = array();
// if debug
if ($debug)
{
echo '$this->customCode:';
var_dump($this->customCode);
}
// load the code
foreach ($this->customCode as $item)
foreach ($ids as $id)
{
$this->buildCustomCodePlaceholders($item, $code, $debug);
$this->buildCustomCodePlaceholders($this->customCodeMemory[$id], $code, $debug);
}
// if debug
if ($debug)

7
admin/helpers/componentbuilder.php
View File

@@ -3895,8 +3895,13 @@ abstract class ComponentbuilderHelper
* @return string On success the edit url
*
*/
public static function getEditURL(&$item, $view, $views, $ref = '', $component = 'com_componentbuilder', $jRoute = true)
public static function getEditURL(&$item, $view, $views, $ref = '', $component = 'com_componentbuilder', $jRoute = true)
{
// make sure the user has access to view
if (!JFactory::getUser()->authorise($view. '.access', $component))
{
return false;
}
// build record
$record = new stdClass();
// check that we have the ID