Fixed gh-417 edit layout by removing the one to many div's from the dynamic build method.

README.md

@@ -150,7 +150,7 @@ TODO
 + *Version*: 2.9.18
 + *Copyright*: Copyright (C) 2015 - 2019 Vast Development Method. All rights reserved.
 + *License*: GNU General Public License version 2 or later; see LICENSE.txt
-+ *Line count*: **206669**
++ *Line count*: **206638**
 + *Field count*: **1136**
 + *File count*: **1344**
 + *Folder count*: **209**

admin/README.txt

@@ -150,7 +150,7 @@ TODO
 + *Version*: 2.9.18
 + *Copyright*: Copyright (C) 2015 - 2019 Vast Development Method. All rights reserved.
 + *License*: GNU General Public License version 2 or later; see LICENSE.txt
-+ *Line count*: **206669**
++ *Line count*: **206638**
 + *Field count*: **1136**
 + *File count*: **1344**
 + *Folder count*: **209**

admin/views/admin_custom_tabs/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/admin_fields/tmpl/edit.php

@@ -102,7 +102,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>
 

admin/views/admin_fields_conditions/tmpl/edit.php

@@ -102,7 +102,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>
 

admin/views/admin_fields_relations/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/admin_view/tmpl/edit.php

@@ -200,7 +200,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 
 <div class="clearfix"></div>
 <?php echo JLayoutHelper::render('admin_view.details_under', $this); ?>

admin/views/component_admin_views/tmpl/edit.php

@@ -102,7 +102,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>
 

admin/views/component_config/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/component_custom_admin_menus/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/component_custom_admin_views/tmpl/edit.php

@@ -102,7 +102,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>
 

admin/views/component_dashboard/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/component_files_folders/tmpl/edit.php

@@ -112,6 +112,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/component_mysql_tweaks/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/component_placeholders/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/component_site_views/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/component_updates/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/custom_admin_views/view.html.php

@@ -193,14 +193,14 @@ class ComponentbuilderViewCustom_admin_views extends JViewLegacy
 
 		// Set Main Get Name Selection
 		$this->main_getNameOptions = JFormHelper::loadFieldType('Maingets')->options;
-		// We do some sanitation for  filter
+		// We do some sanitation for Main Get Name filter
 		if (ComponentbuilderHelper::checkArray($this->main_getNameOptions) &&
 			isset($this->main_getNameOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->main_getNameOptions[0]->value))
 		{
 			unset($this->main_getNameOptions[0]);
 		}
-		// Only load  filter if it has values
+		// Only load Main Get Name filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->main_getNameOptions))
 		{
 			// Main Get Name Filter

admin/views/custom_code/tmpl/edit.php

@@ -108,7 +108,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 
 <div class="clearfix"></div>
 <?php echo JLayoutHelper::render('custom_code.details_under', $this); ?>

admin/views/custom_codes/view.html.php

@@ -193,14 +193,14 @@ class ComponentbuilderViewCustom_codes extends JViewLegacy
 
 		// Set Component System Name Selection
 		$this->componentSystem_nameOptions = JFormHelper::loadFieldType('Component')->options;
-		// We do some sanitation for  filter
+		// We do some sanitation for Component System Name filter
 		if (ComponentbuilderHelper::checkArray($this->componentSystem_nameOptions) &&
 			isset($this->componentSystem_nameOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->componentSystem_nameOptions[0]->value))
 		{
 			unset($this->componentSystem_nameOptions[0]);
 		}
-		// Only load  filter if it has values
+		// Only load Component System Name filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->componentSystem_nameOptions))
 		{
 			// Component System Name Filter

admin/views/dynamic_get/tmpl/edit.php

@@ -151,7 +151,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 
 <div class="clearfix"></div>
 <?php echo JLayoutHelper::render('dynamic_get.main_under', $this); ?>

admin/views/field/tmpl/edit.php

@@ -139,7 +139,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 
 <div class="clearfix"></div>
 <?php echo JLayoutHelper::render('field.set_properties_under', $this); ?>

admin/views/fields/view.html.php

@@ -210,14 +210,14 @@ class ComponentbuilderViewFields extends JViewLegacy
 
 		// Set Fieldtype Name Selection
 		$this->fieldtypeNameOptions = JFormHelper::loadFieldType('Fieldtypes')->options;
-		// We do some sanitation for  filter
+		// We do some sanitation for Fieldtype Name filter
 		if (ComponentbuilderHelper::checkArray($this->fieldtypeNameOptions) &&
 			isset($this->fieldtypeNameOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->fieldtypeNameOptions[0]->value))
 		{
 			unset($this->fieldtypeNameOptions[0]);
 		}
-		// Only load  filter if it has values
+		// Only load Fieldtype Name filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->fieldtypeNameOptions))
 		{
 			// Fieldtype Name Filter

admin/views/fieldtype/tmpl/edit.php

@@ -131,7 +131,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>
 

admin/views/help_document/tmpl/edit.php

@@ -108,7 +108,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 
 <div class="clearfix"></div>
 <?php echo JLayoutHelper::render('help_document.details_under', $this); ?>

admin/views/help_documents/view.html.php

@@ -248,14 +248,14 @@ class ComponentbuilderViewHelp_documents extends JViewLegacy
 
 		// Set Admin View Selection
 		$this->admin_viewOptions = JFormHelper::loadFieldType('Adminviewfolderlist')->options;
-		// We do some sanitation for Location filter
+		// We do some sanitation for Admin View filter
 		if (ComponentbuilderHelper::checkArray($this->admin_viewOptions) &&
 			isset($this->admin_viewOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->admin_viewOptions[0]->value))
 		{
 			unset($this->admin_viewOptions[0]);
 		}
-		// Only load Location filter if it has values
+		// Only load Admin View filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->admin_viewOptions))
 		{
 			// Admin View Filter
@@ -278,14 +278,14 @@ class ComponentbuilderViewHelp_documents extends JViewLegacy
 
 		// Set Site View Selection
 		$this->site_viewOptions = JFormHelper::loadFieldType('Siteviewfolderlist')->options;
-		// We do some sanitation for Location filter
+		// We do some sanitation for Site View filter
 		if (ComponentbuilderHelper::checkArray($this->site_viewOptions) &&
 			isset($this->site_viewOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->site_viewOptions[0]->value))
 		{
 			unset($this->site_viewOptions[0]);
 		}
-		// Only load Location filter if it has values
+		// Only load Site View filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->site_viewOptions))
 		{
 			// Site View Filter

admin/views/joomla_component/tmpl/edit.php

@@ -217,7 +217,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 
 <div class="clearfix"></div>
 <?php echo JLayoutHelper::render('joomla_component.details_under', $this); ?>

admin/views/language/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/language_translation/tmpl/edit.php

@@ -101,7 +101,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>
 

admin/views/layouts/view.html.php

@@ -193,14 +193,14 @@ class ComponentbuilderViewLayouts extends JViewLegacy
 
 		// Set Dynamic Get Name Selection
 		$this->dynamic_getNameOptions = JFormHelper::loadFieldType('Dynamicget')->options;
-		// We do some sanitation for  filter
+		// We do some sanitation for Dynamic Get Name filter
 		if (ComponentbuilderHelper::checkArray($this->dynamic_getNameOptions) &&
 			isset($this->dynamic_getNameOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->dynamic_getNameOptions[0]->value))
 		{
 			unset($this->dynamic_getNameOptions[0]);
 		}
-		// Only load  filter if it has values
+		// Only load Dynamic Get Name filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->dynamic_getNameOptions))
 		{
 			// Dynamic Get Name Filter

admin/views/libraries/view.html.php

@@ -183,14 +183,14 @@ class ComponentbuilderViewLibraries extends JViewLegacy
 
 		// Set How Selection
 		$this->howOptions = JFormHelper::loadFieldType('Filebehaviour')->options;
-		// We do some sanitation for  filter
+		// We do some sanitation for How filter
 		if (ComponentbuilderHelper::checkArray($this->howOptions) &&
 			isset($this->howOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->howOptions[0]->value))
 		{
 			unset($this->howOptions[0]);
 		}
-		// Only load  filter if it has values
+		// Only load How filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->howOptions))
 		{
 			// How Filter

admin/views/library/tmpl/edit.php

@@ -138,7 +138,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 
 <div class="clearfix"></div>
 <?php echo JLayoutHelper::render('library.behaviour_under', $this); ?>

admin/views/library_config/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/library_files_folders_urls/tmpl/edit.php

@@ -112,6 +112,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/placeholder/tmpl/edit.php

@@ -107,7 +107,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>
 

admin/views/server/tmpl/edit.php

@@ -120,7 +120,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>
 

admin/views/site_views/view.html.php

@@ -193,14 +193,14 @@ class ComponentbuilderViewSite_views extends JViewLegacy
 
 		// Set Main Get Name Selection
 		$this->main_getNameOptions = JFormHelper::loadFieldType('Maingets')->options;
-		// We do some sanitation for  filter
+		// We do some sanitation for Main Get Name filter
 		if (ComponentbuilderHelper::checkArray($this->main_getNameOptions) &&
 			isset($this->main_getNameOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->main_getNameOptions[0]->value))
 		{
 			unset($this->main_getNameOptions[0]);
 		}
-		// Only load  filter if it has values
+		// Only load Main Get Name filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->main_getNameOptions))
 		{
 			// Main Get Name Filter

admin/views/snippet/tmpl/edit.php

@@ -97,7 +97,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>
 

admin/views/snippet_type/tmpl/edit.php

@@ -102,6 +102,5 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>

admin/views/snippets/view.html.php

@@ -198,14 +198,14 @@ class ComponentbuilderViewSnippets extends JViewLegacy
 
 		// Set Type Name Selection
 		$this->typeNameOptions = JFormHelper::loadFieldType('Snippettype')->options;
-		// We do some sanitation for  filter
+		// We do some sanitation for Type Name filter
 		if (ComponentbuilderHelper::checkArray($this->typeNameOptions) &&
 			isset($this->typeNameOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->typeNameOptions[0]->value))
 		{
 			unset($this->typeNameOptions[0]);
 		}
-		// Only load  filter if it has values
+		// Only load Type Name filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->typeNameOptions))
 		{
 			// Type Name Filter
@@ -228,14 +228,14 @@ class ComponentbuilderViewSnippets extends JViewLegacy
 
 		// Set Library Name Selection
 		$this->libraryNameOptions = JFormHelper::loadFieldType('Library')->options;
-		// We do some sanitation for  filter
+		// We do some sanitation for Library Name filter
 		if (ComponentbuilderHelper::checkArray($this->libraryNameOptions) &&
 			isset($this->libraryNameOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->libraryNameOptions[0]->value))
 		{
 			unset($this->libraryNameOptions[0]);
 		}
-		// Only load  filter if it has values
+		// Only load Library Name filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->libraryNameOptions))
 		{
 			// Library Name Filter

admin/views/templates/view.html.php

@@ -193,14 +193,14 @@ class ComponentbuilderViewTemplates extends JViewLegacy
 
 		// Set Dynamic Get Name Selection
 		$this->dynamic_getNameOptions = JFormHelper::loadFieldType('Dynamicget')->options;
-		// We do some sanitation for  filter
+		// We do some sanitation for Dynamic Get Name filter
 		if (ComponentbuilderHelper::checkArray($this->dynamic_getNameOptions) &&
 			isset($this->dynamic_getNameOptions[0]->value) &&
 			!ComponentbuilderHelper::checkString($this->dynamic_getNameOptions[0]->value))
 		{
 			unset($this->dynamic_getNameOptions[0]);
 		}
-		// Only load  filter if it has values
+		// Only load Dynamic Get Name filter if it has values
 		if (ComponentbuilderHelper::checkArray($this->dynamic_getNameOptions))
 		{
 			// Dynamic Get Name Filter

admin/views/validation_rule/tmpl/edit.php

@@ -108,7 +108,6 @@ $componentParams = $this->params; // will be removed just use $this->params inst
 		<?php echo JHtml::_('form.token'); ?>
 	</div>
 </div>
-</div>
 </form>
 </div>