improved the table method generateAlias to only get added if there is an alias in the view

README.md

@@ -130,7 +130,7 @@ Component Builder is mapped as a component in itself on my local development env
 + *Version*: 2.7.7
 + *Copyright*: Copyright (C) 2015. All Rights Reserved
 + *License*: GNU/GPL Version 2 or later - http://www.gnu.org/licenses/gpl-2.0.html
-+ *Line count*: **193953**
++ *Line count*: **193602**
 + *Field count*: **1027**
 + *File count*: **1201**
 + *Folder count*: **193**

admin/README.txt

@@ -130,7 +130,7 @@ Component Builder is mapped as a component in itself on my local development env
 + *Version*: 2.7.7
 + *Copyright*: Copyright (C) 2015. All Rights Reserved
 + *License*: GNU/GPL Version 2 or later - http://www.gnu.org/licenses/gpl-2.0.html
-+ *Line count*: **193953**
++ *Line count*: **193602**
 + *Field count*: **1027**
 + *File count*: **1201**
 + *Folder count*: **193**

admin/helpers/compiler/e_Interpretation.php

@@ -5757,24 +5757,31 @@ class Interpretation extends Fields
 	public function setGenerateNewAlias($viewName_single)
 	{
 		// make sure this view has an alias
-		if (isset($this->customAliasBuilder[$viewName_single]) || isset($this->titleBuilder[$viewName_single]))
+		if (isset($this->aliasBuilder[$viewName_single]))
 		{
 			// set the title stuff
 			if (isset($this->customAliasBuilder[$viewName_single]))
 			{
 				$titles = array_values($this->customAliasBuilder[$viewName_single]);
 			}
-			else
+			elseif (isset($this->titleBuilder[$viewName_single]))
 			{
 				$titles = array($this->titleBuilder[$viewName_single]);
 			}
 			// reset the bucket
 			$titleData = array();
 			// load the dynamic title builder
+			if (isset($titles) && ComponentbuilderHelper::checkArray($titles))
+			{
 				foreach ($titles as $title)
 				{
 					$titleData[] = "\$this->" . $title;
 				}
+			}
+			else
+			{
+				$titleData = array("''"); // just incase some mad man does not set a title/customAlias (we fall back on the date)
+			}
 			// rest the new function
 			$newFunction = array();
 			$newFunction[] = PHP_EOL . PHP_EOL . "\t/**";

admin/tables/admin_fields.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableAdmin_fields extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->admin_view;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/admin_fields_conditions.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableAdmin_fields_conditions extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->admin_view;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/component_admin_views.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableComponent_admin_views extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->joomla_component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/component_config.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableComponent_config extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->joomla_component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/component_custom_admin_menus.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableComponent_custom_admin_menus extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->joomla_component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/component_custom_admin_views.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableComponent_custom_admin_views extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->joomla_component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/component_dashboard.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableComponent_dashboard extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->joomla_component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/component_files_folders.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableComponent_files_folders extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->joomla_component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/component_mysql_tweaks.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableComponent_mysql_tweaks extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->joomla_component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/component_site_views.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableComponent_site_views extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->joomla_component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/component_updates.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableComponent_updates extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->joomla_component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/custom_admin_view.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableCustom_admin_view extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/custom_code.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableCustom_code extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->component;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/dynamic_get.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableDynamic_get extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/field.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableField extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/fieldtype.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableFieldtype extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/joomla_component.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableJoomla_component extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->system_name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/language.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableLanguage extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/language_translation.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableLanguage_translation extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->source;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/library.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableLibrary extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/library_config.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableLibrary_config extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->library;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/library_files_folders_urls.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableLibrary_files_folders_urls extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->library;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/server.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableServer extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/site_view.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableSite_view extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/snippet.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableSnippet extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/snippet_type.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableSnippet_type extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }

admin/tables/validation_rule.php

@@ -326,26 +326,13 @@ class ComponentbuilderTableValidation_rule extends JTable
 	}
 
 	/**
-	* Generate a valid alias from title / date.
+	* This view does not actually have an alias
-	* Remains public to be able to check for duplicated alias before saving
 	*
-	* @return  string
+	* @return  bool
 	*/
 	public function generateAlias()
 	{
-		if (empty($this->alias))
+		return false;
-		{
-			$this->alias = $this->name;
-		}
-
-		$this->alias = JApplication::stringURLSafe($this->alias);
-
-		if (trim(str_replace('-', '', $this->alias)) == '')
-		{
-			$this->alias = JFactory::getDate()->format('Y-m-d-H-i-s');
-		}
-
-		return $this->alias;
 	}
 
 }