[Beta] The version rollback (to first record in history) does not work. #1046

New Issue

Closed

opened 2024-02-06 12:30:04 +00:00 by root · 2 comments

root commented

2024-02-06 12:30:04 +00:00

Member

Steps to reproduce the issue

Install you new component on Joomla 5.
Open an admin view and create an item.
Make a change to the item so it will have history.
Open the version and try to revert to the first version.

Expected result

That the original version will be loaded.

Actual result

You get an error about the version value being and empty string, and the rollback failed.

System information (as much as possible)

OS Name & Version: Docker (official Joomla image) on ubuntu.
MySql Version: Docker (MariaDB v11.1.2)
Apache Version: Docker (Apache v2.4.57 Debian)
PHP Version: Docker (v8.2.15)
Joomla Version: Docker (v5.0.2)
JCB Version: v3.1.37
Browser: Firefox 122.0 (64-bit)

Additional comments

I think the version value is not being saved (in history) the first time the item is created. So adding a default value 1 to the version field should resolve this. I have not yet tested this.

### Steps to reproduce the issue - Install you new component on Joomla 5. - Open an admin view and create an item. - Make a change to the item so it will have history. - Open the version and try to revert to the first version. ### Expected result - That the original version will be loaded. ### Actual result - You get an error about the version value being and empty string, and the rollback failed. ### System information (as much as possible) - OS Name & Version: Docker (official Joomla image) on ubuntu. - MySql Version: Docker (MariaDB v11.1.2) - Apache Version: Docker (Apache v2.4.57 Debian) - PHP Version: Docker (v8.2.15) - Joomla Version: Docker (v5.0.2) - JCB Version: v3.1.37 - Browser: Firefox 122.0 (64-bit) ### Additional comments I think the version value is not being saved (in history) the first time the item is created. So adding a default value 1 to the version field should resolve this. I have not yet tested this.

root added the

Bug

label 2024-02-06 12:30:04 +00:00

Llewellyn commented

2024-02-17 16:54:00 +00:00

Owner

Fixed it in 3256efd7ec please test download

Fixed it in https://git.vdm.dev/joomla-beta/com-componentbuilder/commit/3256efd7ecd79fba1f952252776eedb07b1ce2ac please test [download](https://git.vdm.dev/joomla-beta/pkg-component-builder/archive/v3.1.39.zip)

Llewellyn commented

2024-03-26 10:13:34 +00:00

Owner

This has been fixed so this issue seems resolved, let me know if this is not the case.