[BETA] Bug on the right of tabs section of the forms #1053

New Issue

Closed

opened 2024-02-18 07:57:17 +00:00 by vistamedia · 3 comments

vistamedia commented

2024-02-18 07:57:17 +00:00

Member

Steps to reproduce the issue

Create an admin view, put some fields in « right of tabs » position. Attach the view to a component and compile for J4/5

Expected result

The fields to be positionned outside the tabs on the right and visible whatever tab is chosen

Actual result

The tabs are positionned at the bottom of the tabs

System information (as much as possible)

OS Name & Version: Mac 14.2.1
MySql Version: 5.7
PHP Version: 7.4
Joomla Version: 3.10.12
JCB Version: 3.1.39
Browser: Firefox developer edition

Additional comments

### Steps to reproduce the issue Create an admin view, put some fields in « right of tabs » position. Attach the view to a component and compile for J4/5 ### Expected result The fields to be positionned outside the tabs on the right and visible whatever tab is chosen ### Actual result The tabs are positionned at the bottom of the tabs ### System information (as much as possible) - OS Name & Version: Mac 14.2.1 - MySql Version: 5.7 - PHP Version: 7.4 - Joomla Version: 3.10.12 - JCB Version: 3.1.39 - Browser: Firefox developer edition ### Additional comments

vistamedia added the

Beta

label 2024-02-18 07:57:17 +00:00

vistamedia commented

2024-02-19 16:54:41 +00:00

Author

Member

Here is what I suggest (Please see the screenshot)

<div id="discussions_loader" style="display: none;">
    <form action="<?php echo Route::_('index.php?option=com_discussions&layout=edit&id=' . (int) $this->item->id . $this->referral); ?>"
          method="post" name="adminForm" id="adminForm" class="form-validate" enctype="multipart/form-data">

		<?php echo LayoutHelper::render('topic.details_above', $this); ?>
        <div class="row">
            <div class="col-md-9">
                <div class="main-card">
					<?php echo Html::_('uitab.startTabSet', 'topicTab', array('active' => 'details')); ?>

					<?php echo Html::_('uitab.addTab', 'topicTab', 'details', Text::_('COM_DISCUSSIONS_TOPIC_DETAILS', true)); ?>
                    <div class="row">
                        <div class="col-md-12">
							<?php echo LayoutHelper::render('topic.details_left', $this); ?>
                        </div>
                    </div>
					<?php echo Html::_('uitab.endTab'); ?>

					<?php echo Html::_('uitab.addTab', 'topicTab', 'authors', Text::_('COM_DISCUSSIONS_TOPIC_AUTHORS', true)); ?>
                    <div class="row">
                    </div>
                    <div class="row">
                        <div class="col-md-12">
							<?php echo LayoutHelper::render('topic.authors_fullwidth', $this); ?>
                        </div>
                    </div>
					<?php echo Html::_('uitab.endTab'); ?>

					<?php echo Html::_('uitab.addTab', 'topicTab', 'keys_dates', Text::_('COM_DISCUSSIONS_TOPIC_KEYS_DATES', true)); ?>
                    <div class="row">
                    </div>
                    <div class="row">
                        <div class="col-md-12">
							<?php echo LayoutHelper::render('topic.keys_dates_fullwidth', $this); ?>
                        </div>
                    </div>
					<?php echo Html::_('uitab.endTab'); ?>

					<?php echo Html::_('uitab.addTab', 'topicTab', 'comments', Text::_('COM_DISCUSSIONS_TOPIC_COMMENTS', true)); ?>
                    <div class="row">
                    </div>
                    <div class="row">
                        <div class="col-md-12">
							<?php echo LayoutHelper::render('topic.comments_fullwidth', $this); ?>
                        </div>
                    </div>
					<?php echo Html::_('uitab.endTab'); ?>

					<?php $this->ignore_fieldsets = array('details', 'metadata', 'vdmmetadata', 'accesscontrol'); ?>
					<?php $this->tab_name = 'topicTab'; ?>
					<?php echo LayoutHelper::render('joomla.edit.params', $this); ?>

					<?php if ($this->canDo->get('core.edit.created_by') || $this->canDo->get('core.edit.created') || $this->canDo->get('core.edit.state') || ($this->canDo->get('core.delete') && $this->canDo->get('core.edit.state'))) : ?>
						<?php echo Html::_('uitab.addTab', 'topicTab', 'publishing', Text::_('COM_DISCUSSIONS_TOPIC_PUBLISHING', true)); ?>
                        <div class="row">
                            <div class="col-md-6">
								<?php echo LayoutHelper::render('topic.publishing', $this); ?>
                            </div>
                            <div class="col-md-6">
								<?php echo LayoutHelper::render('topic.publlshing', $this); ?>
                            </div>
                        </div>
						<?php echo Html::_('uitab.endTab'); ?>
					<?php endif; ?>

					<?php echo Html::_('uitab.endTabSet'); ?>

                    <div>
                        <input type="hidden" name="task" value="topic.edit"/>
						<?php echo Html::_('form.token'); ?>
                    </div>
                </div>
            </div>
            <div class="col-md-3">
		        <?php echo LayoutHelper::render('topic.details_rightside', $this); ?>
            </div>
        </div>
    </form>
</div>

Here is what I suggest (Please see the screenshot) ``` <div id="discussions_loader" style="display: none;"> <form action="<?php echo Route::_('index.php?option=com_discussions&layout=edit&id=' . (int) $this->item->id . $this->referral); ?>" method="post" name="adminForm" id="adminForm" class="form-validate" enctype="multipart/form-data"> <?php echo LayoutHelper::render('topic.details_above', $this); ?> <div class="row"> <div class="col-md-9"> <div class="main-card"> <?php echo Html::_('uitab.startTabSet', 'topicTab', array('active' => 'details')); ?> <?php echo Html::_('uitab.addTab', 'topicTab', 'details', Text::_('COM_DISCUSSIONS_TOPIC_DETAILS', true)); ?> <div class="row"> <div class="col-md-12"> <?php echo LayoutHelper::render('topic.details_left', $this); ?> </div> </div> <?php echo Html::_('uitab.endTab'); ?> <?php echo Html::_('uitab.addTab', 'topicTab', 'authors', Text::_('COM_DISCUSSIONS_TOPIC_AUTHORS', true)); ?> <div class="row"> </div> <div class="row"> <div class="col-md-12"> <?php echo LayoutHelper::render('topic.authors_fullwidth', $this); ?> </div> </div> <?php echo Html::_('uitab.endTab'); ?> <?php echo Html::_('uitab.addTab', 'topicTab', 'keys_dates', Text::_('COM_DISCUSSIONS_TOPIC_KEYS_DATES', true)); ?> <div class="row"> </div> <div class="row"> <div class="col-md-12"> <?php echo LayoutHelper::render('topic.keys_dates_fullwidth', $this); ?> </div> </div> <?php echo Html::_('uitab.endTab'); ?> <?php echo Html::_('uitab.addTab', 'topicTab', 'comments', Text::_('COM_DISCUSSIONS_TOPIC_COMMENTS', true)); ?> <div class="row"> </div> <div class="row"> <div class="col-md-12"> <?php echo LayoutHelper::render('topic.comments_fullwidth', $this); ?> </div> </div> <?php echo Html::_('uitab.endTab'); ?> <?php $this->ignore_fieldsets = array('details', 'metadata', 'vdmmetadata', 'accesscontrol'); ?> <?php $this->tab_name = 'topicTab'; ?> <?php echo LayoutHelper::render('joomla.edit.params', $this); ?> <?php if ($this->canDo->get('core.edit.created_by') || $this->canDo->get('core.edit.created') || $this->canDo->get('core.edit.state') || ($this->canDo->get('core.delete') && $this->canDo->get('core.edit.state'))) : ?> <?php echo Html::_('uitab.addTab', 'topicTab', 'publishing', Text::_('COM_DISCUSSIONS_TOPIC_PUBLISHING', true)); ?> <div class="row"> <div class="col-md-6"> <?php echo LayoutHelper::render('topic.publishing', $this); ?> </div> <div class="col-md-6"> <?php echo LayoutHelper::render('topic.publlshing', $this); ?> </div> </div> <?php echo Html::_('uitab.endTab'); ?> <?php endif; ?> <?php echo Html::_('uitab.endTabSet'); ?> <div> <input type="hidden" name="task" value="topic.edit"/> <?php echo Html::_('form.token'); ?> </div> </div> </div> <div class="col-md-3"> <?php echo LayoutHelper::render('topic.details_rightside', $this); ?> </div> </div> </form> </div> ```

2024-02-19_17-50-23.jpg

491 KiB