joomla/Component-Builder
joomla/Component-Builder
39
23
Fork 11
Code Issues 80 Pull Requests Projects 4 Wiki Activity

[BUG]: Missing Factory call in JoomlaFive Event class of the Compiler. #1093

New Issue
Closed
opened 2024-03-18 08:57:41 +00:00 by Lemuel · 3 comments
Lemuel commented 2024-03-18 08:57:41 +00:00
Member
Copy Link

What Happened?

Missing Factory call in JoomlaFive Event class of the Compiler.

  • This is the error output

Screenshot from 2024-03-18 10-01-20

Steps to reproduce the Bug

Compile a Demo Component in Joomla five Component Builder

Which Joomla version are you compiling in?

v5.0.3

Which PHP version are you compiling in?

v8.2

Which Joomla versions are you targeting?

All

Which PHP version are you targeting?

8.2

Which Web server is JCB running on?

Apache 2.4

Which Relational Database is JCB running on?

Mysqli Latest

Which OS is JCB running on?

Ubuntu 22.04

Which JCB version are you using?

v5.0.0-alpha4

Which Joomla version is JCB installed on?

Joomla 5

Where in JCB did this issue occur?

Compilation of a component

On which browsers did you encounter the issue?

Firefox

Additional Comments

No response

### What Happened? Missing Factory call in JoomlaFive Event class of the Compiler. * This is the error output ![Screenshot from 2024-03-18 10-01-20](https://git.vdm.dev/attachments/5c42ebb5-18fb-4c13-97b8-f0f9a5d43fb9) ### Steps to reproduce the Bug Compile a Demo Component in Joomla five Component Builder ### Which Joomla version are you compiling in? v5.0.3 ### Which PHP version are you compiling in? v8.2 ### Which Joomla versions are you targeting? All ### Which PHP version are you targeting? 8.2 ### Which Web server is JCB running on? Apache 2.4 ### Which Relational Database is JCB running on? Mysqli Latest ### Which OS is JCB running on? Ubuntu 22.04 ### Which JCB version are you using? v5.0.0-alpha4 ### Which Joomla version is JCB installed on? Joomla 5 ### Where in JCB did this issue occur? Compilation of a component ### On which browsers did you encounter the issue? Firefox ### Additional Comments _No response_
Screenshot from 2024-03-18 10-01-20.png
60 KiB
Lemuel added the
Bug
 label 2024-03-18 08:57:41 +00:00
Llewellyn changed title from [BUG]: to [BUG]: Missing Factory call in JoomlaFive Event class of the Compiler. 2024-03-18 09:30:17 +00:00
Llewellyn commented 2024-03-18 09:36:21 +00:00
Owner
Copy Link

Can you in the Event class for JoomlaFive add the following header use statement as a temp fix... and let me know if it worked.

use Joomla\CMS\Factory;

I will add it to the next update.

Can you in the [Event class for JoomlaFive](https://git.vdm.dev/joomla/Component-Builder/src/branch/5.x/libraries/jcb_powers/VDM.Joomla/src/Componentbuilder/Compiler/JoomlaFive/Event.php#L14) add the following header use statement as a temp fix... and let me know if it worked. ``` use Joomla\CMS\Factory; ``` I will add it to the next update.
Lemuel commented 2024-03-18 11:05:32 +00:00
Author
Member
Copy Link

Yep! adding that extra line to the Event class of JoomlaFive fixed the problem.
It is now successfully compiling the demo component for versions 3, 4, and 5 of Joomla.
Thank you! 👍

Yep! adding that extra line to the [Event class of JoomlaFive](https://git.vdm.dev/joomla/Component-Builder/src/commit/8deb178d7c83083b5419bbd6912695244328d374/libraries/jcb_powers/VDM.Joomla/src/Componentbuilder/Compiler/JoomlaFive/Event.php#L14) fixed the problem. It is now successfully compiling the demo component for versions 3, 4, and 5 of Joomla. Thank you! 👍
Robot referenced this issue from a commit 2024-03-20 12:19:40 +00:00
Release of v3.2.0-beta8
Robot referenced this issue from a commit 2024-03-20 12:20:45 +00:00
Release of v4.0.0-alpha5
Robot referenced this issue from a commit 2024-03-20 12:22:34 +00:00
Release of v5.0.0-alpha5
Lemuel commented 2024-03-22 09:55:57 +00:00
Author
Member
Copy Link

Installing new Joomla Component Builder v5.0.0-alpha5fixed the issue and adding new fields works.
This issue can be closed.

Installing new Joomla Component Builder [v5.0.0-alpha5](https://git.vdm.dev/joomla/Component-Builder/releases/tag/v5.0.0-alpha6)fixed the issue and adding new fields works. This issue can be closed.
Robot referenced this issue from a commit 2024-03-27 13:04:44 +00:00
Release of v3.2.0
Robot referenced this issue from a commit 2024-05-10 16:12:54 +00:00
Release of v4.0.0
Robot referenced this issue from a commit 2024-05-10 16:15:25 +00:00
Release of v5.0.0
Robot referenced this issue from a commit 2024-05-10 16:35:57 +00:00
Release of v4.0.0
Robot referenced this issue from a commit 2024-05-10 16:39:50 +00:00
Release of v5.0.0
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Beta

Issues related to the a beta release

  
Bug

   
Documentation

   
enhancement

   
help wanted

   
invalid

   
joomla

Joomla related changes

  
question

   
URGENT

   
wontfix
No Label
Beta
Bug
Documentation
enhancement
help wanted
invalid
joomla
question
URGENT
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#1093
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?