[BUG]: CustomCode hash implementation not working #1126

New Issue

Open

opened 2024-05-10 19:22:45 +00:00 by Marco Aldana · 1 comment

Marco Aldana commented

2024-05-10 19:22:45 +00:00

Member

What Happened?

Use of /[INSERT<>$$$$]/ /[/INSERT<>$$$$]/ and /[REPLACE<>$$$$]/ /[/REPLACE<>$$$$]/ tags, is being ignored upon compilation

Steps to reproduce the Bug

in the IDE, create a set of insertion and/or replace tags to insert custom code in view files.
Compile component for J3
install new compiled component
code is not inserted, nor is it loaded in customviews section of JCB

Which Joomla version are you compiling in?

Joomla! 3.10.12 Stable [ Daraja ] 8-July-2023 15:18 GMT

Which PHP version are you compiling in?

8.0.30

Which Joomla versions are you targeting?

Joomla 3

Which PHP version are you targeting?

8.0.30

Which Web server is JCB running on?

Apache 2.4.58

Which Relational Database is JCB running on?

10.6.17-MariaDB-log

Which OS is JCB running on?

Linux ecngx303.inmotionhosting.com 4.18.0-372.19.1.lve.el7h.x86_64 #1 SMP Tue Aug 9 14:38:15 UTC 2022 x86_64

Which JCB version are you using?

3.2.1

Where in JCB did this issue occur?

Compilation of a component, Custom Code(admin_view)

On which browsers did you encounter the issue?

Firefox, Microsoft Edge, Opera

Additional Comments

upon some time replicating the problem on different browsers, the Custom Code items were created in the CustomCodes Area, but htey were unpublished.

retried after publishing them, but still no code is inserted in the compiled component.

### What Happened? Use of /***[INSERT<>$$$$]***/ /***[/INSERT<>$$$$]***/ and /***[REPLACE<>$$$$]***/ /***[/REPLACE<>$$$$]***/ tags, is being ignored upon compilation ### Steps to reproduce the Bug in the IDE, create a set of insertion and/or replace tags to insert custom code in view files. Compile component for J3 install new compiled component code is not inserted, nor is it loaded in customviews section of JCB ### Which Joomla version are you compiling in? Joomla! 3.10.12 Stable [ Daraja ] 8-July-2023 15:18 GMT ### Which PHP version are you compiling in? 8.0.30 ### Which Joomla versions are you targeting? Joomla 3 ### Which PHP version are you targeting? 8.0.30 ### Which Web server is JCB running on? Apache 2.4.58 ### Which Relational Database is JCB running on? 10.6.17-MariaDB-log ### Which OS is JCB running on? Linux ecngx303.inmotionhosting.com 4.18.0-372.19.1.lve.el7h.x86_64 #1 SMP Tue Aug 9 14:38:15 UTC 2022 x86_64 ### Which JCB version are you using? 3.2.1 ### Where in JCB did this issue occur? Compilation of a component, Custom Code(admin_view) ### On which browsers did you encounter the issue? Firefox, Microsoft Edge, Opera ### Additional Comments upon some time replicating the problem on different browsers, the Custom Code items were created in the CustomCodes Area, but htey were unpublished. retried after publishing them, but still no code is inserted in the compiled component.

Marco Aldana added the

Bug

label 2024-05-10 19:22:45 +00:00

Llewellyn commented

2024-05-11 08:24:56 +00:00

Owner

I will have to test this, but I can assure you from my last test it worked perfectly.

Yet I have always said that custom-code insert replace method is not the best thing to do. What should be done instead is that we improve JCB so that it can do what you need done.

But we want the feature to stay, and remain stable since sometimes our clients don't understand this, and time is against us and we just have to get the product out. But in the long run the maintenance goes up, and we lose the real advantage of JCB.

I will have to test this, but I can assure you from my last test it worked perfectly. Yet I have always said that custom-code insert replace method is not the best thing to do. What should be done instead is that we improve JCB so that it can do what you need done. But we want the feature to stay, and remain stable since sometimes our clients don't understand this, and time is against us and we just have to get the product out. But in the long run the maintenance goes up, and we lose the real advantage of JCB.