joomla/Component-Builder
42
28 Fork 13
Code Issues 56 Pull Requests Projects Wiki Activity

WIP: Change typo #1236

Closed
ConfidantCommunications wants to merge 2 commits from ConfidantCommunications/Component-Builder:confidantcommunications-patch-1 into 5.x
pull from: ConfidantCommunications/Component-Builder:confidantcommunications-patch-1
merge into: joomla:5.x
Conversation 4 Commits 2 Files Changed 26
+1225 -1076
ConfidantCommunications commented 2025-07-22 19:44:30 +00:00
First-time contributor
Copy link
Copy source

Pull Request for joomla/Component-Builder#1133

Summary of Changes

Changed reference of dynamic to dynamicget

Testing Instructions

After merging, perform compilation of a module containing a custom get.

Expected result

Successful compiling.

Actual result

Successful compiling without error.

Documentation Changes Required

No.

Pull Request for joomla/Component-Builder#1133 ### Summary of Changes Changed reference of `dynamic` to `dynamicget` ### Testing Instructions After merging, perform compilation of a module containing a custom get. ### Expected result Successful compiling. ### Actual result Successful compiling without error. ### Documentation Changes Required No.
ConfidantCommunications added 1 commit 2025-07-22 19:44:30 +00:00
Change typo f1911bf413
Llewellyn commented 2025-07-23 10:27:41 +00:00
Owner
Copy link
Copy source

Since your commit has changed the whole class, instead if just the line in question... I can not see what you've done.

Since your commit has changed the whole class, instead if just the line in question... I can not see what you've done.
ConfidantCommunications commented 2025-07-23 16:30:04 +00:00
Author
First-time contributor
Copy link
Copy source

Similar to my comment on #1133, not sure why Git claims the whole file changed. Sorry if I made a mistake.

Similar to my comment on #1133, not sure why Git claims the whole file changed. Sorry if I made a mistake.
ConfidantCommunications commented 2025-07-23 16:34:35 +00:00
Author
First-time contributor
Copy link
Copy source

The changes here involved removing a greater-than sign (>) at the end of the "addfieldprefix" attribute lines. Line 439 on the 2 MainXML.php files (Joomla 4 and 5). Also line 23458 in Interpretation.php.

The changes here involved removing a greater-than sign (>) at the end of the "addfieldprefix" attribute lines. Line 439 on the 2 MainXML.php files (Joomla 4 and 5). Also line 23458 in Interpretation.php.
Llewellyn commented 2025-07-23 18:56:10 +00:00
Owner
Copy link
Copy source

It is not git, but your editor... many editors auto update the file indentation and other things like line breaks and more... so best to update the file in a none auto file updating editor... like nano. and then make the commit 👍

It is not git, but your editor... many editors auto update the file indentation and other things like line breaks and more... so best to update the file in a none auto file updating editor... like nano. and then make the commit 👍
Llewellyn closed this pull request 2025-12-22 09:07:38 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
This pull request is marked as a work in progress.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Beta
Issues related to the a beta release
 Bug
Documentation
URGENT
enhancement
help wanted
invalid
joomla
Joomla related changes
 question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
aamigo Eunice Hannah Jeff Lemuel Llewellyn Malachi Roline vistamedia Martin (Martin Kopp) aB0t (Robot) ro-ot (root) TLWebdesign (Tom van der Laan)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joomla/Component-Builder#1236