joomla/Component-Builder
40
26
Fork 12
Code Issues 84 Pull Requests 2 Projects 4 Wiki Activity

WIP: Change typo #1236

Draft
ConfidantCommunications wants to merge 1 commits from ConfidantCommunications/Component-Builder:confidantcommunications-patch-1 into 5.x
pull from: ConfidantCommunications/Component-Builder:confidantcommunications-patch-1
merge into: joomla:5.x
Conversation 4 Commits 1 Files Changed 1 +1003 -1003
ConfidantCommunications commented 2025-07-22 19:44:30 +00:00
First-time contributor
Copy Link

Pull Request for joomla/Component-Builder#1133

Summary of Changes

Changed reference of dynamic to dynamicget

Testing Instructions

After merging, perform compilation of a module containing a custom get.

Expected result

Successful compiling.

Actual result

Successful compiling without error.

Documentation Changes Required

No.

Pull Request for joomla/Component-Builder#1133 ### Summary of Changes Changed reference of `dynamic` to `dynamicget` ### Testing Instructions After merging, perform compilation of a module containing a custom get. ### Expected result Successful compiling. ### Actual result Successful compiling without error. ### Documentation Changes Required No.
ConfidantCommunications added 1 commit 2025-07-22 19:44:30 +00:00
Change typo f1911bf413
Llewellyn commented 2025-07-23 10:27:41 +00:00
Owner
Copy Link

Since your commit has changed the whole class, instead if just the line in question... I can not see what you've done.

Since your commit has changed the whole class, instead if just the line in question... I can not see what you've done.
ConfidantCommunications commented 2025-07-23 16:30:04 +00:00
Author
First-time contributor
Copy Link

Similar to my comment on #1133, not sure why Git claims the whole file changed. Sorry if I made a mistake.

Similar to my comment on #1133, not sure why Git claims the whole file changed. Sorry if I made a mistake.
ConfidantCommunications commented 2025-07-23 16:34:35 +00:00
Author
First-time contributor
Copy Link

The changes here involved removing a greater-than sign (>) at the end of the "addfieldprefix" attribute lines. Line 439 on the 2 MainXML.php files (Joomla 4 and 5). Also line 23458 in Interpretation.php.

The changes here involved removing a greater-than sign (>) at the end of the "addfieldprefix" attribute lines. Line 439 on the 2 MainXML.php files (Joomla 4 and 5). Also line 23458 in Interpretation.php.
Llewellyn commented 2025-07-23 18:56:10 +00:00
Owner
Copy Link

It is not git, but your editor... many editors auto update the file indentation and other things like line breaks and more... so best to update the file in a none auto file updating editor... like nano. and then make the commit 👍

It is not git, but your editor... many editors auto update the file indentation and other things like line breaks and more... so best to update the file in a none auto file updating editor... like nano. and then make the commit 👍
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u confidantcommunications-patch-1:ConfidantCommunications-confidantcommunications-patch-1
git checkout ConfidantCommunications-confidantcommunications-patch-1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Beta
Issues related to the a beta release
Bug
Documentation
enhancement
help wanted
invalid
joomla
Joomla related changes
question
URGENT
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aamigo Lemuel Llewellyn Malachi Roline vistamedia Martin Martin Kopp aB0t Robot ro-ot root TLWebdesign Tom van der Laan
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joomla/Component-Builder#1236
No description provided.
Delete Branch "ConfidantCommunications/Component-Builder:confidantcommunications-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?