WIP: Change typo #1236
Reference in New Issue
Block a user
No description provided.
Delete Branch "ConfidantCommunications/Component-Builder:confidantcommunications-patch-1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Pull Request for joomla/Component-Builder#1133
Summary of Changes
Changed reference of
dynamic
todynamicget
Testing Instructions
After merging, perform compilation of a module containing a custom get.
Expected result
Successful compiling.
Actual result
Successful compiling without error.
Documentation Changes Required
No.
Since your commit has changed the whole class, instead if just the line in question... I can not see what you've done.
Similar to my comment on #1133, not sure why Git claims the whole file changed. Sorry if I made a mistake.
The changes here involved removing a greater-than sign (>) at the end of the "addfieldprefix" attribute lines. Line 439 on the 2 MainXML.php files (Joomla 4 and 5). Also line 23458 in Interpretation.php.
It is not git, but your editor... many editors auto update the file indentation and other things like line breaks and more... so best to update the file in a none auto file updating editor... like nano. and then make the commit 👍
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.