admin view header custom code not linked text is not compiled #468

New Issue

Closed

opened 2019-08-24 08:55:09 +00:00 by jcodewalker · 12 comments

jcodewalker commented 2019-08-24 08:55:09 +00:00 (Migrated from github.com)

Copy Link

Steps to reproduce the issue

custom code the admin view header template: insert and
compile

Expected result

all translated text

Actual result

not linked (it means not sortable), so not inside tags, header placeholders not translated
linked placeholders are correctly translated

System information (as much as possible)

• Joomla Version: 3.9.11
• JCB Version: 2.10.0

Additional comments

### Steps to reproduce the issue custom code the admin view header template: insert <!---[REPLACE<>$$$$]--> and <!---[/REPLACE<>$$$$]--> compile ### Expected result all translated text ### Actual result not linked (it means not sortable), so not inside <a> tags, header placeholders not translated linked placeholders are correctly translated  ### System information (as much as possible) - Joomla Version: 3.9.11 - JCB Version: 2.10.0 ### Additional comments

Llewellyn commented 2019-08-26 06:43:11 +00:00

Copy Link

Hmmm, I am not sure I get what you are trying to do.... you will need to explain more.

Hmmm, I am not sure I get what you are trying to do.... you will need to explain more.

jcodewalker commented 2019-08-26 06:51:47 +00:00 (Migrated from github.com)

Copy Link

Say I want to customize the header of a list view, in admin side.
I just set the custom codes (<!— [REPLACE<>$$$$]—> and <!— [/REPLACE<>$$$$]—>) in default_header.php file, save, compile, upload. Just this.
The column titles which are not sortable (haven’t the a tag) are not compiled, it means instead of translation there is the text: COM_[[[COMPONENT]_HEADER_TEXT

Say I want to customize the header of a list view, in admin side. I just set the custom codes (<!— [REPLACE<>$$$$]—> and <!— [/REPLACE<>$$$$]—>) in default_header.php file, save, compile, upload. Just this. The column titles which are not sortable (haven’t the a tag) are not compiled, it means instead of translation there is the text: COM_[[[COMPONENT]_HEADER_TEXT

Llewellyn commented 2019-08-26 06:57:22 +00:00

Copy Link

Custom code does not work on one line, you must replace a few lines, and not close to eachother.

Why don't you change the TAB names in JCB?

Custom code does not work on one line, you must replace a few lines, and not close to eachother. Why don't you change the TAB names in JCB?

Llewellyn commented 2019-08-26 06:59:33 +00:00

Copy Link

This is in the settings tab of an admin-view.

 This is in the settings tab of an admin-view.

jcodewalker commented 2019-08-26 09:22:37 +00:00 (Migrated from github.com)

Copy Link

There is a misunderstand..
I’m referring to the header of a content list view:

Il giorno 26/ago/2019, alle ore 08:59, {{ǝʍǝ}}yn notifications@github.com ha scritto:

https://user-images.githubusercontent.com/5607939/63671412-b7fdaa80-c7df-11e9-82f9-9c54437c9a93.png
This is in the settings tab of an admin-view.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/vdm-io/Joomla-Component-Builder/issues/468?email_source=notifications&email_token=ALWXFT23ZRLJ4F47HJTJDMTQGN5NVA5CNFSM4IPFUCFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DOZ7I#issuecomment-524741885, or mute the thread https://github.com/notifications/unsubscribe-auth/ALWXFTZ4QZMJI2FMH5K566TQGN5NVANCNFSM4IPFUCFA.

There is a misunderstand.. I’m referring to the header of a content list view: > Il giorno 26/ago/2019, alle ore 08:59, {{ǝʍǝ}}yn <notifications@github.com> ha scritto: > > <https://user-images.githubusercontent.com/5607939/63671412-b7fdaa80-c7df-11e9-82f9-9c54437c9a93.png> > This is in the settings tab of an admin-view. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub <https://github.com/vdm-io/Joomla-Component-Builder/issues/468?email_source=notifications&email_token=ALWXFT23ZRLJ4F47HJTJDMTQGN5NVA5CNFSM4IPFUCFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DOZ7I#issuecomment-524741885>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALWXFTZ4QZMJI2FMH5K566TQGN5NVANCNFSM4IPFUCFA>. >

Llewellyn commented 2019-08-26 11:07:10 +00:00

Copy Link

hmmm that does not help... content list view? where is that. If you watch the tutorials I use terms to idetify things and if you use different terms I can't follow seeing there is like just way to many thinks on the table here.

Far as I understand tabs are used in the admin_view and dashboard of components build with JCB if you are adding more dashboard tabs... then this is also done in JCB and not needed to use custom insert/replace code. If you are adding tabs in and admin_view (edit) view then this also is done inside JCB as explained above.

Yet you are saying in the content list view, this sounds like the admin_views but this does not have tabs... so I am still not getting where you are doing this.

hmmm that does not help... content list view? where is that. If you watch the tutorials I use terms to idetify things and if you use different terms I can't follow seeing there is like just way to many thinks on the table here. Far as I understand tabs are used in the admin_view and dashboard of components build with JCB if you are adding more dashboard tabs... then this is also done in JCB and not needed to use custom insert/replace code. If you are adding tabs in and admin_view (edit) view then this also is done inside JCB as explained above. Yet you are saying in the content list view, this sounds like the admin_views but this does not have tabs... so I am still not getting where you are doing this.

jcodewalker commented 2019-08-26 16:20:20 +00:00 (Migrated from github.com)

Copy Link

:-)
Please note that I haven’t written “tab” in any post.. maybe you read “taG” and thought a tab…

Anyway,
I want to customize the header of a list table (result of a list query), in admin side. There are no tabs! :-)
Being in a table there are columns and rows.
After I set the custom codes (<!— [REPLACE<>$$$$] —> and <!— [/REPLACE<>$$$$] —> the headers that haven’t sorting option are not translated.
Only those like listDirn, $this->listOrder); ?> are translated,
simple echo like echo 'COM_[COMPONENT]_ORDER_SUBSCRIBER_ID_LABEL’ are not translated.

I hope it’s a bit more understandable.

Il giorno 26/ago/2019, alle ore 13:07, {{ǝʍǝ}}yn notifications@github.com ha scritto:

l that does not help... content list view? where is that. If you watch the tutorials I use terms to idetify things and if you use different terms I can't follow seeing there is like just way to many thinks on the table here.

Far as I understand tabs are used in the admin_view and dashboard of components build with JCB if you are adding more dashboard tabs... then this is also done in JCB and not needed to use custom insert/replace code. If you are adding tabs in and admin_view (edit) view then this also is done inside JCB as explained above.

Yet you are saying in the content list view, this sounds like the admin_views but this does not have tabs... so I am still not getting where you are doing this.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/vdm-io/Joomla-Component-Builder/issues/468?email_source=notifications&email_token=ALWXFT4JG3AXH76KWS64P3TQGO2OJA5CNFSM4IPFUCFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EBRYA#issuecomment-524818656, or mute the thread https://github.com/notifications/unsubscribe-auth/ALWXFT75UVT2DRFJS7TEIHLQGO2OJANCNFSM4IPFUCFA.

:-) Please note that I haven’t written “tab” in any post.. maybe you read “taG” and thought a tab… Anyway, I want to customize the header of a list table (result of a list query), in admin side. There are no tabs! :-) Being in a table there are columns and rows. After I set the custom codes (<!— [REPLACE<>$$$$] —> and <!— [/REPLACE<>$$$$] —> the headers that haven’t sorting option are not translated. Only those like <?php echo JHtml::_('grid.sort', 'COM_[[[COMPONENT]]]_ORDER_SUBSCRIBER_ID_LABEL', 'subscriber_id_lname', $this->listDirn, $this->listOrder); ?> are translated, simple echo like echo 'COM_[[[COMPONENT]]]_ORDER_SUBSCRIBER_ID_LABEL’ are not translated. I hope it’s a bit more understandable. > Il giorno 26/ago/2019, alle ore 13:07, {{ǝʍǝ}}yn <notifications@github.com> ha scritto: > > l that does not help... content list view? where is that. If you watch the tutorials I use terms to idetify things and if you use different terms I can't follow seeing there is like just way to many thinks on the table here. > > Far as I understand tabs are used in the admin_view and dashboard of components build with JCB if you are adding more dashboard tabs... then this is also done in JCB and not needed to use custom insert/replace code. If you are adding tabs in and admin_view (edit) view then this also is done inside JCB as explained above. > > Yet you are saying in the content list view, this sounds like the admin_views but this does not have tabs... so I am still not getting where you are doing this. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub <https://github.com/vdm-io/Joomla-Component-Builder/issues/468?email_source=notifications&email_token=ALWXFT4JG3AXH76KWS64P3TQGO2OJA5CNFSM4IPFUCFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EBRYA#issuecomment-524818656>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALWXFT75UVT2DRFJS7TEIHLQGO2OJANCNFSM4IPFUCFA>. >

Llewellyn commented 2019-08-26 17:16:10 +00:00

Copy Link

okay... my mistake, we speak about that area as the admin_views or the list view.

Please watch this tutorial as to why avoiding the use of custom code.

Now to change the names of those columns in the table use the admin_fields_relations since you have the option to change the column name from default to anything you want. This is the most ideal place to do this.

Then if you really want to do this with custom code placeholder, you will have to give me the code so I can see what is not working out. Since we know that feature is stable and if it does not work, there is often wrong implementation.

So as example:

<!-- [REPLACE<>$$$$] -->
<?php echo JHtml::_('grid.sort', 'COM_COMPONENTNAME_ORDER_SUBSCRIBER_ID_LABEL', 'subscriber_id_lname', $this->listDirn, $this->listOrder); ?>
<!-- [/REPLACE<>$$$$] -->

Another note, JCB does not target translations stings done in the JHtml, only the following strings are targeted. So what you are trying to do will not work without some tweaking.

try this:

<!-- [REPLACE<>$$$$] -->
<?php echo JHtml::_('grid.sort', JustTEXT::_('The column name'), 'subscriber_id_lname', $this->listDirn, $this->listOrder); ?>
<!-- [/REPLACE<>$$$$] -->

Hope this helps, I have not tested it.

okay... my mistake, we speak about that area as the admin_view**s** or the list view. Please watch this [tutorial as to why avoiding the use of custom code](https://www.youtube.com/watch?v=QGMURJI_Mds&list=PLQRGFI8XZ_wuzAQELTUUIDdqKFmLP9lSl&index=4&t=0s). Now to change the names of those columns in the table use the [admin_fields_relations](https://youtu.be/hh4IIPmYIY8) since you have the option to change the column name from default to anything you want. This is the most ideal place to do this. Then if you really want to do this with custom code placeholder, you will have to give me the code so I can see what is not working out. Since we know that feature is stable and if it does not work, there is often wrong implementation. So as example: ``` <!-- [REPLACE<>$$$$] --> <?php echo JHtml::_('grid.sort', 'COM_COMPONENTNAME_ORDER_SUBSCRIBER_ID_LABEL', 'subscriber_id_lname', $this->listDirn, $this->listOrder); ?> <!-- [/REPLACE<>$$$$] --> ``` Another note, JCB does not target translations stings done in the JHtml, only the [following ](https://github.com/vdm-io/Joomla-Component-Builder/blob/staging/admin/helpers/compiler/a_Get.php#L296) strings are targeted. So what you are trying to do will not work without some tweaking. try this: ``` <!-- [REPLACE<>$$$$] --> <?php echo JHtml::_('grid.sort', JustTEXT::_('The column name'), 'subscriber_id_lname', $this->listDirn, $this->listOrder); ?> <!-- [/REPLACE<>$$$$] --> ``` Hope this helps, I have not tested it.

jcodewalker commented 2019-08-27 07:39:41 +00:00 (Migrated from github.com)

Copy Link

Hello,
Great advice to use "field relations"! That does the trick! Thanks.

About the column headers link, just use your Demo component and follow these instructions:

1. Open the "Look" admin views in JCB and add a field in the list (I added "alias"), NOT SORTABLE
   

2. Compile, upload
   
   Everything works fine

3. Open default_head.php in your editor and add the replace tags:
   

4 Compile

5 Upload

6 Go to Looks view

"Alias" is not translated anymore.
Just the "not sortable" fields, sortable fields work fine.

Hello, Great advice to use "field relations"! That does the trick! Thanks. About the column headers link, just use your Demo component and follow these instructions: 1. Open the "Look" admin views in JCB and add a field in the list (I added "alias"), NOT SORTABLE  2. Compile, upload  Everything works fine 3. Open default_head.php in your editor and add the replace tags:  4 Compile  5 Upload  6 Go to Looks view  "Alias" is not translated anymore. Just the "not sortable" fields, sortable fields work fine.

jcodewalker commented 2019-08-27 08:02:21 +00:00 (Migrated from github.com)

Copy Link

By the way, is there also a way to add CSS to the column headers, like align-right, without custom code?

By the way, is there also a way to add CSS to the column headers, like align-right, without custom code?

Llewellyn commented 2019-08-28 11:50:17 +00:00

Copy Link

By the way, is there also a way to add CSS to the column headers, like align-right, without custom code?

In the admin_view there is a tab->CSS and a field Add CSS (views) * which targets the list_view of the admin view.

I have pushed a fix to your issue, try out the staging branch on a blank install and see it it is truly resolved.

> By the way, is there also a way to add CSS to the column headers, like align-right, without custom code? In the admin_view there is a tab->CSS and a field Add CSS (views) * which targets the list_view of the admin view. I have pushed a fix to your issue, try out the staging branch on a blank install and see it it is truly resolved.

jcodewalker commented 2019-08-28 12:37:04 +00:00 (Migrated from github.com)

Copy Link

I know about that tabs to add css code, but, how can I add a style to just 1 column header?
If I set a css style for the th rag, all th are affected, it means all column headers all together. Each th should have an id identifier (perhaps with the field name?).
To do it, right now, I have to use custom code.

I will check your fix soon and give you a feedback.

Thanks!

Il giorno 28/ago/2019, alle ore 13:50, {{ǝʍǝ}}yn notifications@github.com ha scritto:

By the way, is there also a way to add CSS to the column headers, like align-right, without custom code?
In the admin_view there is a tab->CSS and a field Add CSS (views) * which targets the list_view of the admin view.

I have pushed a fix to your issue, try out the staging branch on a blank install and see it it is truly resolved.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/vdm-io/Joomla-Component-Builder/issues/468?email_source=notifications&email_token=ALWXFT7HNMNEDGKX44EEHHTQGZQ77A5CNFSM4IPFUCFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5K3BQQ#issuecomment-525709506, or mute the thread https://github.com/notifications/unsubscribe-auth/ALWXFT2AZFBJFEW5XLNQKR3QGZQ77ANCNFSM4IPFUCFA.

I know about that tabs to add css code, but, how can I add a style to just 1 column header? If I set a css style for the th rag, all th are affected, it means all column headers all together. Each th should have an id identifier (perhaps with the field name?). To do it, right now, I have to use custom code. I will check your fix soon and give you a feedback. Thanks! > Il giorno 28/ago/2019, alle ore 13:50, {{ǝʍǝ}}yn <notifications@github.com> ha scritto: > > By the way, is there also a way to add CSS to the column headers, like align-right, without custom code? > In the admin_view there is a tab->CSS and a field Add CSS (views) * which targets the list_view of the admin view. > > I have pushed a fix to your issue, try out the staging branch on a blank install and see it it is truly resolved. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub <https://github.com/vdm-io/Joomla-Component-Builder/issues/468?email_source=notifications&email_token=ALWXFT7HNMNEDGKX44EEHHTQGZQ77A5CNFSM4IPFUCFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5K3BQQ#issuecomment-525709506>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALWXFT2AZFBJFEW5XLNQKR3QGZQ77ANCNFSM4IPFUCFA>. >

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

5.x

4.x

3.x

master

staging

v5.0.1-alpha2

v4.0.1-alpha2

v3.2.2-alpha2

v3.2.2-alpha1

v4.0.1-alpha1

v5.0.1-alpha1

v5.0.0

v4.0.0

v3.2.1

v3.2.0

v3.1.28

v3.1.27

v3.1.24

v3.1.19

v3.1.17

v3.1.15

v3.1.12

v3.1.11

v3.1.10

v3.1.9

v3.1.8

v3.1.7

v3.1.6

v3.1.5

v3.1.4

v3.1.3

v3.1.2

v2.13.1

v2.13.0

v2.12.16

v2.12.15

v2.12.14

v2.12.10

v2.12.9

v2.12.8

v2.12.7

v2.12.6

v2.12.4

v2.12.3

v2.12.2

v2.11.7

v2.11.4

v2.11.3

v2.11.2

v2.11.0

v2.10.13

v2.10.11

v2.10.9

v2.10.5

v2.10.1

v2.10.0

v2.9.21

v2.9.18

v2.9.14

v2.9.11

v2.9.10

v2.9.8

v2.9.7

v2.9.1

v2.9.0

v2.8.5

v2.8.4

v2.8.2

v2.8.0

v2.7.10

v2.7.7

v2.7.6

v2.7.5

v2.7.4

v2.7.1

v2.7.0

v2.6.17

v2.6.16

v2.6.15

v2.6.14

v2.6.13

v2.6.12

v2.6.11

v2.6.10

v2.6.9

v2.6.8

v2.6.7

v2.6.6

v2.6.5

v2.6.3

v2.6.2

v2.6.1

v2.6.0

v2.5.8

v2.5.6

v2.5.5

v2.5.4

v2.5.1

v2.5.0

v2.4.10

v2.4.9

v2.4.8

v2.4.7

v2.4.6

v2.4.5

v2.4.4

v2.4.3

v2.4.2

v2.4.1

v2.4.0

v2.3.10

v2.3.9

v2.3.8

v2.3.7

v2.3.6

v2.3.5

v2.3.4

v2.3.2

v2.3.1

v2.3.0

v2.2.10

v2.2.9

v2.2.6

v2.2.5

v2.2.4

v2.2.3

v2.2.2

v2.2.0

v2.1.21

v2.1.20

v2.1.19

v2.1.18

v2.1.17

v2.1.16

v2.1.14

v2.1.13

v2.1.12

v2.1.11

v2.1.10

v2.1.9

v2.1.8

v2.1.7

v2.1.6

v2.1.5

v2.1.4

v2.1.3

v2.1.2

v2.1.1

v2.1.0

v2.0.9

v2.0.8

Labels

Clear labels   

Beta

Issues related to the a beta release

  

Bug

  

Documentation

  

enhancement

  

help wanted

  

invalid

  

joomla

Joomla related changes

  

question

  

URGENT

  

wontfix

No Label

Beta

Bug

Documentation

enhancement

help wanted

invalid

joomla

question

URGENT

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#468

No description provided.