Snippets do not update #510

New Issue

Closed

opened 2020-01-04 23:44:17 +00:00 by Manfred · 4 comments

Manfred commented

2020-01-04 23:44:17 +00:00

Member

Steps to reproduce the issue

Go to GetSnippets and try to load updates for Bootstrap 4 snippets. I see under "New" lots of new snippets. Try to update them by "Bulk" or standalone.

Expected result

Snippets should get updated into the DB and marked as "equal"

Actual result

Snippets do not get updated, neither "bulk" or manually.

System information (as much as possible)

OS Name & Version:
MySql Version: 5.7
Apache Version: 2 (running on localhost)
PHP Version: 7.2
Joomla Version: 3.9.14
JCB Version: 2.10.9
Browser: Firefox

Additional comments

On my test website on V-Server (Linux) there are no snippets visible at all and JCB do not get Snippets from Git repo. Loading spinner runs and runs ...

### Steps to reproduce the issue Go to GetSnippets and try to load updates for Bootstrap 4 snippets. I see under "New" lots of new snippets. Try to update them by "Bulk" or standalone. ### Expected result Snippets should get updated into the DB and marked as "equal" ### Actual result Snippets do not get updated, neither "bulk" or manually. ### System information (as much as possible) - OS Name & Version: - MySql Version: 5.7 - Apache Version: 2 (running on localhost) - PHP Version: 7.2 - Joomla Version: 3.9.14 - JCB Version: 2.10.9 - Browser: Firefox ### Additional comments On my test website on V-Server (Linux) there are no snippets visible at all and JCB do not get Snippets from Git repo. Loading spinner runs and runs ...

Llewellyn commented

2020-01-05 04:35:13 +00:00

Owner

I am actually working in this area, since the Assistant will have what we call plans and it will be json maps that the Assistant can use to build a component. So I have started consolidating the two areas to share code. Yet this is only in the staging branch, but I will run some test, since I did not work on that area for months until now. When last did it work?

Llewellyn commented

2020-01-05 04:58:10 +00:00

Owner

Okay I see there is indeed an error (bug), still debugging it, but it should not be major.

Llewellyn commented

2020-01-05 21:19:31 +00:00

Owner

Okay found it, to patch your JCB update this line 3392 in the Ajax class as follow:

if (($snippet = ComponentbuilderHelper::getGithubRepoData('lib_snippet_' . $base_path, $url, null, 'array')) !== false)

The next release should have the fix, since I just pushed the fix to the staging branch.

Okay found it, to patch your JCB [update this line 3392](https://github.com/vdm-io/Joomla-Component-Builder/blob/master/admin/models/ajax.php#L3392) in the Ajax class as follow: ``` if (($snippet = ComponentbuilderHelper::getGithubRepoData('lib_snippet_' . $base_path, $url, null, 'array')) !== false) ``` The next release should have the fix, since I just pushed the fix to the staging branch.

Manfred commented

2020-01-06 22:50:31 +00:00

Author

Member

Thanks, patch works :-)