joomla/Component-Builder
joomla/Component-Builder
39
23
Fork 11
Code Issues 80 Pull Requests Projects 4 Wiki Activity

Joomla 3.9.25 breaks JCB compiler page, don't upgrade just yet!!!! #678

New Issue
Closed
opened 2021-03-04 04:43:31 +00:00 by Llewellyn · 5 comments
Llewellyn commented 2021-03-04 04:43:31 +00:00
Owner
Copy Link

Steps to reproduce the issue

When you upgrade to Joomla 3.9.25 there are a number of supersizes... one is that they strip all JavaScript from system messages. This means the compiler page buttons stop working, ans they are onclick="install()" buttons.

Expected result

That they would not mess with system "developer generated messages"

Actual result

They just added the following update to the message area.
aadf6979f8 (diff-cc812ef35110247c370f8a84f5ee62a1ed85bab5747ee4b0252bde2c6836b920R177)

Additional comments

We are working on a fix for this, and soon as its ready I will update this issue.

### Steps to reproduce the issue When you upgrade to [Joomla 3.9.25](https://github.com/joomla/joomla-cms/releases/tag/3.9.25) there are a number of supersizes... one is that they strip all JavaScript from system messages. This means the compiler page buttons stop working, ans they are `onclick="install()"` buttons. ### Expected result That they would not mess with system **"developer generated messages"** ### Actual result They just added the following update to the message area. https://github.com/joomla/joomla-cms/commit/aadf6979f8b99308c3621ea3af2ca98e678a477d#diff-cc812ef35110247c370f8a84f5ee62a1ed85bab5747ee4b0252bde2c6836b920R177 ### Additional comments We are working on a fix for this, and soon as its ready I will update this issue.
Llewellyn commented 2021-03-04 06:14:13 +00:00
Author
Owner
Copy Link

This commit above should resolve this issue... we will make an urgent release.

This commit above should resolve this issue... we will make an urgent release.
LordRazen commented 2021-03-05 13:12:32 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

Unbenannt
Quite happy this got fixed. Thanks a lot!

I ust wonder: Whenever I compile (within Firefox), my qhole compiler page is marked and therefor turns blue. Like I selected the whole page with Strg + A. This is a cosmetic issue, everything works, that's why I didnt create an issue. If you would like to investigate, my settings can be found here: https://github.com/vdm-io/Joomla-Component-Builder/issues/686

(The Debug mode has no influence on the bug. I already tested that).

![Unbenannt](https://user-images.githubusercontent.com/9381368/110120091-e0933700-7dbc-11eb-8cd3-0405d8762758.png) Quite happy this got fixed. Thanks a lot! I ust wonder: Whenever I compile (within Firefox), my qhole compiler page is marked and therefor turns blue. Like I selected the whole page with Strg + A. This is a cosmetic issue, everything works, that's why I didnt create an issue. If you would like to investigate, my settings can be found here: https://github.com/vdm-io/Joomla-Component-Builder/issues/686 (The Debug mode has no influence on the bug. I already tested that).
Llewellyn commented 2021-03-05 14:13:51 +00:00
Author
Owner
Copy Link

The screen going blue is new, I did that to prevent you from clicking on anything during compilation. I could add a switch to remove that behavior...

Reality is that it does not effect the compiler at all. There is a whole new "graphic" being used and the page also has the notices on the side during compilation.

I will still push out a little tutorial about the update...

The screen going blue is new, I did that to prevent you from clicking on anything during compilation. I could add a switch to remove that behavior... Reality is that it does not effect the compiler at all. There is a whole new "graphic" being used and the page also has the notices on the side during compilation. I will still push out a little tutorial about the update...
Llewellyn commented 2021-03-05 14:14:53 +00:00
Author
Owner
Copy Link

Maybe I can make it green instead... 👍

Maybe I can make it green instead... :+1:
LordRazen commented 2021-03-05 17:22:00 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

Oh, that might help indeed. The blue suggests Ctrl+A and it feels like a bug somehow. Any other colour would probably more feel like a feature ^^

Oh, that might help indeed. The blue suggests Ctrl+A and it feels like a bug somehow. Any other colour would probably more feel like a feature ^^
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Beta

Issues related to the a beta release

  
Bug

   
Documentation

   
enhancement

   
help wanted

   
invalid

   
joomla

Joomla related changes

  
question

   
URGENT

   
wontfix
No Label
Beta
Bug
Documentation
enhancement
help wanted
invalid
joomla
question
URGENT
wontfix
Milestone
Clear milestone
No items
No Milestone
Free Support
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: joomla/Component-Builder#678
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?