Dynamic Values on Layouts #93
Labels
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: joomla/Component-Builder#93
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I noticed, today, when working on finishing a couple of views that there is a "reference" issue on layouts when it's displaying the dynamic values. You can see this on, as an example "Preachers Panel". The main get shows the foreach correctly: , using $displayData instead of $this->item.
However, on the additional get, idPreacherSermonB, it references $item, instead of $displayData: idPreacherSermonB as $idPreacherSermonB): ?>. As written, it would throw errors. However, if it was idPreacherSermonB as $idPreacherSermonB): ?>, it would work fine.
If someone is relying, copying from those references, they may get frustrated when idPreacherSermonB is throwing errors.
Yes those code snippets do need some attention, would you like to make improvement to it?
Okay this could be an issue if you don't know PHP, but this is clearly a requirement :)
Would be great to improve this, the algorithm is very crazy... you can have a look at it here. It is just that the variation is huge, and to correctly set those values across various places is where the improvements are needed.