joomla/Component-Builder
42
28 Fork 13
Code Issues 56 Pull Requests Projects Wiki Activity

Component doesn't compile after update to 3.1.19 #994

New Issue
Closed
opened 2023-05-01 13:57:18 +00:00 by dormasta · 4 comments
dormasta commented 2023-05-01 13:57:18 +00:00
Copy link
Copy source

After beeing blocked on JCB 3.1.2 according to the discussion in https://github.com/vdm-io/Joomla-Component-Builder/discussions/953
I maid the update by hand to 3.1.19.

Step to reproduce

Component gets compiled in 3.1.2, after update to 3.1.19 the component doesn't get compiled.
Message when openning admin view

An error has occurred.
500 View class not found [class, file]: invitooViewinvitations, /Users/afievet/Sites/invitoo/www/administrator/components/com_invitoo/views/invitations/view.html.php 
/Users/afievet/Sites/invitoo/www/libraries/src/MVC/Factory/LegacyFactory.php:85

Expected result

Working like in previous JCB versions

Actual result

Looking into the source code it appears that placeholders like ###name### are not replaced by content.
For example in the views/name/view.html.php the beginning of the file looks like

// No direct access to this file
defined('_JEXEC') or die('Restricted access');
?>
###BOM###

// No direct access to this file
defined('_JEXEC') or die('Restricted access');

###DASH_VIEW_HTML_HEADER###

/**
 * ###Component### View class
 */
class ###Component###View###Component### extends JViewLegacy
{

System information (as much as possible)

  • OS Name & Version: Mac OS Ventura
  • MySql Version: 5.7.39
  • Apache Version: 2.4.54
  • PHP Version: 7.4.33
  • Joomla Version: 3.10.11
  • JCB Version: 3.1.19
  • Browser: S, FF, Ch

Additional comments

After beeing blocked on JCB 3.1.2 according to the discussion in https://github.com/vdm-io/Joomla-Component-Builder/discussions/953 I maid the update by hand to 3.1.19. ### Step to reproduce Component gets compiled in 3.1.2, after update to 3.1.19 the component doesn't get compiled. Message when openning admin view ``` An error has occurred. 500 View class not found [class, file]: invitooViewinvitations, /Users/afievet/Sites/invitoo/www/administrator/components/com_invitoo/views/invitations/view.html.php /Users/afievet/Sites/invitoo/www/libraries/src/MVC/Factory/LegacyFactory.php:85 ``` ### Expected result Working like in previous JCB versions ### Actual result Looking into the source code it appears that placeholders like ###name### are not replaced by content. For example in the views/name/view.html.php the beginning of the file looks like ``` // No direct access to this file defined('_JEXEC') or die('Restricted access'); ?> ###BOM### // No direct access to this file defined('_JEXEC') or die('Restricted access'); ###DASH_VIEW_HTML_HEADER### /** * ###Component### View class */ class ###Component###View###Component### extends JViewLegacy { ``` ### System information (as much as possible) - OS Name & Version: Mac OS Ventura - MySql Version: 5.7.39 - Apache Version: 2.4.54 - PHP Version: 7.4.33 - Joomla Version: 3.10.11 - JCB Version: 3.1.19 - Browser: S, FF, Ch ### Additional comments
dormasta commented 2023-05-01 14:14:32 +00:00
Author
Copy link
Copy source

I downgraded to 3.1.2 same file looks like:

// No direct access to this file
defined('_JEXEC') or die('Restricted access');

/**
 * Invitoo View class
 */
class InvitooViewInvitoo extends JViewLegacy
{
I downgraded to 3.1.2 same file looks like: ``` // No direct access to this file defined('_JEXEC') or die('Restricted access'); /** * Invitoo View class */ class InvitooViewInvitoo extends JViewLegacy { ```
Llewellyn commented 2023-05-01 14:41:29 +00:00
Owner
Copy link
Copy source

could you try the beta-version? https://git.vdm.dev/joomla-beta/pkg-component-builder/archive/master.zip

Since I think we have fixed this issue...

could you try the beta-version? https://git.vdm.dev/joomla-beta/pkg-component-builder/archive/master.zip Since I think we have fixed this issue...
Llewellyn commented 2023-05-02 01:02:02 +00:00
Owner
Copy link
Copy source

Version v3.1.24 has been released and this issue should be resolved. Test and let me know.

Version [v3.1.24](https://git.vdm.dev/joomla/pkg-component-builder/archive/v3.1.24.zip) has been released and this issue should be resolved. Test and let me know.
dormasta commented 2023-05-02 10:58:35 +00:00
Author
Copy link
Copy source

sorry for the delayed answer, I had a strange issue where comments like /* comment */ where tranformed in /* comment /* closing comment inverted. If I find out in which step it happened I will open an issue if it is one.

Back to the initial problem, indeed it works with the beta.
Thank you for the help and release, cheers.

sorry for the delayed answer, I had a strange issue where comments like `/* comment */` where tranformed in `/* comment /*` closing comment inverted. If I find out in which step it happened I will open an issue if it is one. Back to the initial problem, indeed it works with the beta. Thank you for the help and release, cheers.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
Beta
Issues related to the a beta release
 Bug
Documentation
URGENT
enhancement
help wanted
invalid
joomla
Joomla related changes
 question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
aamigo Eunice Hannah Jeff Lemuel Llewellyn Malachi Roline vistamedia Martin (Martin Kopp) aB0t (Robot) ro-ot (root) TLWebdesign (Tom van der Laan)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joomla/Component-Builder#994