joomla/cms
29
0
Fork 0
mirror of https://github.com/joomla/joomla-cms.git synced 2024-06-27 07:33:41 +00:00
Code Packages Releases Activity

[4.4] Proposed fix for Workflow transition error (#42036)

Browse Source 
* Update UsersModel.php for 'GROUP BY' fix

* Update administrator/components/com_users/src/Model/UsersModel.php

Conform to coding style

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

* Update Workflow.php for issue #42031

Proposed fix for the reported error at #42031:
An error has occurred.
42601 42601, 7, ERROR: syntax error at or near "WHERE" LINE 5: WHERE "t"."id" = $1 AND "t"."workflow_id" = "w"."id" AND "t"... ^

* Revised update Workflow.php for #42031

Corrected join() call.

* Update Workflow.php for code style

Remove a space which caused phpcs complained.

---------

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
This commit is contained in:
kochinc 2023-10-30 17:27:09 -04:00 committed by GitHub
parent 85227208a9
commit 3b13b2433b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libraries/src/Workflow/Workflow.php
View File

@ -302,7 +302,11 @@ class Workflow
$this->db->quoteName('#__workflow_transitions', 't'),
]
)
->join('INNER', $this->db->quoteName('#__workflows', 'w'))
->join(
'INNER',
$this->db->quoteName('#__workflows', 'w'),
$this->db->quoteName('t.workflow_id') . ' = ' . $this->db->quoteName('w.id')
)
->join(
'LEFT',
$this->db->quoteName('#__workflow_stages', 's'),
@ -311,7 +315,6 @@ class Workflow
->where(
[
$this->db->quoteName('t.id') . ' = :id',
$this->db->quoteName('t.workflow_id') . ' = ' . $this->db->quoteName('w.id'),
$this->db->quoteName('t.published') . ' = 1',
$this->db->quoteName('w.extension') . ' = :extension',
]