joomla/cms
29
0
Fork 0
mirror of https://github.com/joomla/joomla-cms.git synced 2024-06-28 16:13:42 +00:00
Code Packages Releases Activity

fix @todo tags (#36418)

Browse Source
This commit is contained in:
Phil E. Taylor 2021-12-26 15:30:04 +00:00 committed by GitHub
parent 5f937f8928
commit a444e83449
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
administrator/components/com_config/src/Model/ApplicationModel.php
View File

@ -1090,7 +1090,7 @@ class ApplicationModel extends FormModel
}
/**
* @to do: incorrect ACL stored
* @todo: incorrect ACL stored
* When changing a permission of an item that doesn't have a row in the asset table the row a new row is created.
* This works fine for item <-> component <-> global config scenario and component <-> global config scenario.
* But doesn't work properly for item <-> section(s) <-> component <-> global config scenario,
@ -1184,7 +1184,7 @@ class ApplicationModel extends FormModel
$parentAssetId = null;
/**
* @to do: incorrect info
* @todo: incorrect info
* When creating a new item (not saving) it uses the calculated permissions from the component (item <-> component <-> global config).
* But if we have a section too (item <-> section(s) <-> component <-> global config) this is not correct.
* Also, currently it uses the component permission, but should use the calculated permissions for a child of the component/section.
@ -1285,7 +1285,7 @@ class ApplicationModel extends FormModel
// Second part: Overwrite the calculated permissions labels if there is an explicit permission in the current group.
/**
* @to do: incorrect info
* @todo: incorrect info
* If a component has a permission that doesn't exists in global config (ex: frontend editing in com_modules) by default
* we get "Not Allowed (Inherited)" when we should get "Not Allowed (Default)".
*/

2
layouts/joomla/form/field/rules.php
View File

@ -198,7 +198,7 @@ $ajaxUri = Route::_('index.php?option=com_config&task=application.store&format=j
// Second part: Overwrite the calculated permissions labels if there is an explicit permission in the current group.
/**
* @to do: incorrect info
* @todo: incorrect info
* If a component has a permission that doesn't exists in global config (ex: frontend editing in com_modules) by default
* we get "Not Allowed (Inherited)" when we should get "Not Allowed (Default)".
*/

2
libraries/src/Form/Field/RulesField.php
View File

@ -208,7 +208,7 @@ class RulesField extends FormField
$this->assetId = (int) $db->loadResult();
/**
* @to do: incorrect info
* @todo: incorrect info
* When creating a new item (not saving) it uses the calculated permissions from the component (item <-> component <-> global config).
* But if we have a section too (item <-> section(s) <-> component <-> global config) this is not correct.
* Also, currently it uses the component permission, but should use the calculated permissions for achild of the component/section.