joomla/cms
29
0
Fork 0
mirror of https://github.com/joomla/joomla-cms.git synced 2024-06-21 03:22:52 +00:00
Code Packages Releases Activity

[4.1] webauthn table accessibility (#37464)

Browse Source 
This pr adds the required table caption and column/row scope to the table.

There are no visual changes and brings this table into line with all other admin tables.

As webauthn requires https this PR cannot be tested on a site without https.

Co-authored-by: Quy <quy@fluxbb.org>
This commit is contained in:
Brian Teeman 2022-04-03 20:13:29 +01:00 committed by GitHub
parent 11c32dde7f
commit cd9c48a406
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
administrator/language/en-GB/plg_system_webauthn.ini
View File

@ -43,3 +43,4 @@ PLG_SYSTEM_WEBAUTHN_MANAGE_HEADER_NOMETHODS_LABEL="No authenticators have been s
PLG_SYSTEM_WEBAUTHN_MSG_DELETED="The authenticator has been removed."
PLG_SYSTEM_WEBAUTHN_MSG_SAVED_LABEL="The label has been saved."
PLG_SYSTEM_WEBAUTHN_REQUIRES_GMP="Either of the PHP extensions GMP or BCmath must be loaded to add authenticators."
PLG_SYSTEM_WEBAUTHN_TABLE_CAPTION="Table of WebAuthn authenticators."

9
layouts/plugins/system/webauthn/manage.php
View File

@ -98,17 +98,20 @@ $postbackURL = base64_encode(rtrim(Uri::base(), '/') . '/index.php?' . Joomla::g
<?php endif; ?>
<table class="table table-striped">
<caption class="visually-hidden">
<?php echo Text::_('PLG_SYSTEM_WEBAUTHN_TABLE_CAPTION'); ?>,
</caption>
<thead class="table-dark">
<tr>
<th><?php echo Text::_('PLG_SYSTEM_WEBAUTHN_MANAGE_FIELD_KEYLABEL_LABEL') ?></th>
<th><?php echo Text::_('PLG_SYSTEM_WEBAUTHN_MANAGE_HEADER_ACTIONS_LABEL') ?></th>
<th scope="col"><?php echo Text::_('PLG_SYSTEM_WEBAUTHN_MANAGE_FIELD_KEYLABEL_LABEL') ?></th>
<th scope="col"><?php echo Text::_('PLG_SYSTEM_WEBAUTHN_MANAGE_HEADER_ACTIONS_LABEL') ?></th>
</tr>
</thead>
<tbody>
<?php // phpcs:ignore
foreach ($credentials as $method): ?>
<tr data-credential_id="<?php echo $method['id'] ?>">
<td><?php echo htmlentities($method['label']) ?></td>
<th scope="row"><?php echo htmlentities($method['label']) ?></th>
<td>
<button data-random-id="<?php echo $randomId; ?>" class="plg_system_webauthn-manage-edit btn btn-secondary">
<span class="icon-edit" aria-hidden="true"></span>