From e7920e0b222adb82ea5d8ddcf96b4b3e8cf119e6 Mon Sep 17 00:00:00 2001 From: Allon Moritz Date: Mon, 26 Jun 2023 19:34:49 +0200 Subject: [PATCH] Adds a code style rule to check if there are unused imports (#41004) * Adds a code style rule to check if there are unused imports * alignment --- .php-cs-fixer.dist.php | 2 ++ administrator/components/com_mails/src/Model/TemplatesModel.php | 1 - components/com_tags/src/Model/TagsModel.php | 1 - libraries/src/Document/HtmlDocument.php | 1 - libraries/src/Form/Field/SqlField.php | 1 - libraries/src/MVC/View/AbstractView.php | 1 - plugins/system/guidedtours/services/provider.php | 1 - .../updatenotification/src/Extension/UpdateNotification.php | 1 - tests/Unit/Libraries/Cms/Mail/MailFactoryTest.php | 1 - 9 files changed, 2 insertions(+), 8 deletions(-) diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php index 69c9a61acd0..ddaf4c34c23 100644 --- a/.php-cs-fixer.dist.php +++ b/.php-cs-fixer.dist.php @@ -78,6 +78,8 @@ $config 'binary_operator_spaces' => ['operators' => ['=>' => 'align_single_space_minimal', '=' => 'align']], // The "No break" comment in switch statements 'no_break_comment' => ['comment_text' => 'No break'], + // Remove unused imports + 'no_unused_imports' => true, ] ) ->setFinder($finder); diff --git a/administrator/components/com_mails/src/Model/TemplatesModel.php b/administrator/components/com_mails/src/Model/TemplatesModel.php index 28817741a9f..45173e78fbd 100644 --- a/administrator/components/com_mails/src/Model/TemplatesModel.php +++ b/administrator/components/com_mails/src/Model/TemplatesModel.php @@ -14,7 +14,6 @@ use Joomla\CMS\Component\ComponentHelper; use Joomla\CMS\Language\LanguageHelper; use Joomla\CMS\MVC\Model\ListModel; use Joomla\Database\DatabaseQuery; -use Joomla\Database\QueryInterface; // phpcs:disable PSR1.Files.SideEffects \defined('_JEXEC') or die; diff --git a/components/com_tags/src/Model/TagsModel.php b/components/com_tags/src/Model/TagsModel.php index 0fcab821f6d..b9f45501c4e 100644 --- a/components/com_tags/src/Model/TagsModel.php +++ b/components/com_tags/src/Model/TagsModel.php @@ -16,7 +16,6 @@ use Joomla\CMS\Helper\ContentHelper; use Joomla\CMS\MVC\Model\ListModel; use Joomla\Database\DatabaseQuery; use Joomla\Database\ParameterType; -use Joomla\Database\QueryInterface; // phpcs:disable PSR1.Files.SideEffects \defined('_JEXEC') or die; diff --git a/libraries/src/Document/HtmlDocument.php b/libraries/src/Document/HtmlDocument.php index 66ed3170a63..2b2ec36d5c5 100644 --- a/libraries/src/Document/HtmlDocument.php +++ b/libraries/src/Document/HtmlDocument.php @@ -18,7 +18,6 @@ use Joomla\CMS\Helper\ModuleHelper; use Joomla\CMS\Language\Text; use Joomla\CMS\Uri\Uri; use Joomla\CMS\Utility\Utility; -use Joomla\Database\ParameterType; use Joomla\Registry\Registry; // phpcs:disable PSR1.Files.SideEffects diff --git a/libraries/src/Form/Field/SqlField.php b/libraries/src/Form/Field/SqlField.php index 5a8fa51cae1..f6a088324c0 100644 --- a/libraries/src/Form/Field/SqlField.php +++ b/libraries/src/Form/Field/SqlField.php @@ -12,7 +12,6 @@ namespace Joomla\CMS\Form\Field; use Joomla\CMS\Factory; use Joomla\CMS\HTML\HTMLHelper; use Joomla\CMS\Language\Text; -use Joomla\Database\DatabaseQuery; use Joomla\Database\Exception\ExecutionFailureException; use Joomla\Database\QueryInterface; diff --git a/libraries/src/MVC/View/AbstractView.php b/libraries/src/MVC/View/AbstractView.php index 40233c4abb6..330b0e04ee7 100644 --- a/libraries/src/MVC/View/AbstractView.php +++ b/libraries/src/MVC/View/AbstractView.php @@ -11,7 +11,6 @@ namespace Joomla\CMS\MVC\View; use Joomla\CMS\Document\Document; use Joomla\CMS\Document\DocumentAwareInterface; -use Joomla\CMS\Document\DocumentAwareTrait; use Joomla\CMS\Factory; use Joomla\CMS\Language\LanguageAwareInterface; use Joomla\CMS\Language\LanguageAwareTrait; diff --git a/plugins/system/guidedtours/services/provider.php b/plugins/system/guidedtours/services/provider.php index 256cd38c939..5435066d3b0 100644 --- a/plugins/system/guidedtours/services/provider.php +++ b/plugins/system/guidedtours/services/provider.php @@ -10,7 +10,6 @@ defined('_JEXEC') or die; -use Joomla\Application\ApplicationInterface; use Joomla\CMS\Extension\PluginInterface; use Joomla\CMS\Factory; use Joomla\CMS\Plugin\PluginHelper; diff --git a/plugins/system/updatenotification/src/Extension/UpdateNotification.php b/plugins/system/updatenotification/src/Extension/UpdateNotification.php index eb7db6e3f9f..c6f5a330ed5 100644 --- a/plugins/system/updatenotification/src/Extension/UpdateNotification.php +++ b/plugins/system/updatenotification/src/Extension/UpdateNotification.php @@ -15,7 +15,6 @@ use Joomla\CMS\Access\Access; use Joomla\CMS\Cache\Cache; use Joomla\CMS\Component\ComponentHelper; use Joomla\CMS\Extension\ExtensionHelper; -use Joomla\CMS\Language\Text; use Joomla\CMS\Log\Log; use Joomla\CMS\Mail\Exception\MailDisabledException; use Joomla\CMS\Mail\MailTemplate; diff --git a/tests/Unit/Libraries/Cms/Mail/MailFactoryTest.php b/tests/Unit/Libraries/Cms/Mail/MailFactoryTest.php index ba1706cd78a..27163118590 100644 --- a/tests/Unit/Libraries/Cms/Mail/MailFactoryTest.php +++ b/tests/Unit/Libraries/Cms/Mail/MailFactoryTest.php @@ -9,7 +9,6 @@ namespace Joomla\Tests\Unit\Libraries\Cms\Layout; -use Joomla\CMS\Layout\BaseLayout; use Joomla\CMS\Mail\Mail; use Joomla\CMS\Mail\MailerFactory; use Joomla\Registry\Registry;