joomla/jedchecker
31
2
Fork 0
mirror of https://github.com/joomla-extensions/jedchecker.git synced 2024-06-16 19:52:19 +00:00
Code Issues Releases Activity

change unknown children and attribute to just an info-level message

Browse Source
This commit is contained in:
Denis Ryabov 2021-04-04 14:19:14 +03:00
parent ae251b5d5b
commit 49b383514e
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
administrator/components/com_jedchecker/libraries/rules/xmlmanifest.php
View File

@ -58,6 +58,13 @@ class JedcheckerRulesXMLManifest extends JEDcheckerRule
*/
protected $warnings;
/**
* List of infos.
*
* @var string[]
*/
protected $infos;
/**
* Rules for XML nodes
* ? - single, optional
@ -153,6 +160,7 @@ class JedcheckerRulesXMLManifest extends JEDcheckerRule
$this->errors = array();
$this->warnings = array();
$this->infos = array();
// Validate manifest
$this->validateXml($xml, 'extension');
@ -167,6 +175,11 @@ class JedcheckerRulesXMLManifest extends JEDcheckerRule
$this->report->addWarning($file, implode('<br />', $this->warnings));
}
if (count($this->infos))
{
$this->report->addInfo($file, implode('<br />', $this->infos));
}
// All checks passed. Return true
return true;
}
@ -186,12 +199,12 @@ class JedcheckerRulesXMLManifest extends JEDcheckerRule
{
foreach ($node->attributes() as $attr)
{
$attrName = (string)$attr->getName();
$attrName = (string) $attr->getName();
if (!in_array($attrName, $DTDattributes, true))
{
// The node has unknown attribute
$this->warnings[] = JText::sprintf('COM_JEDCHECKER_MANIFEST_UNKNOWN_ATTRIBUTE', $name, $attrName);
$this->infos[] = JText::sprintf('COM_JEDCHECKER_MANIFEST_UNKNOWN_ATTRIBUTE', $name, $attrName);
}
}
}
@ -202,7 +215,7 @@ class JedcheckerRulesXMLManifest extends JEDcheckerRule
// No children
if ($node->count() > 0)
{
$this->warnings[] = JText::sprintf('COM_JEDCHECKER_MANIFEST_UNKNOWN_CHILDREN', $name);
$this->infos[] = JText::sprintf('COM_JEDCHECKER_MANIFEST_UNKNOWN_CHILDREN', $name);
}
}
elseif (!isset($this->DTDNodeRules[$name]['*']))
@ -248,13 +261,14 @@ class JedcheckerRulesXMLManifest extends JEDcheckerRule
{
$childNames[$child->getName()] = 1;
}
$childNames = array_keys($childNames);
foreach ($childNames as $child)
{
if (!isset($DTDchildren[$child]))
{
$this->warnings[] = JText::sprintf('COM_JEDCHECKER_MANIFEST_UNKNOWN_CHILD', $name, $child);
$this->infos[] = JText::sprintf('COM_JEDCHECKER_MANIFEST_UNKNOWN_CHILD', $name, $child);
}
else
{
@ -287,6 +301,7 @@ class JedcheckerRulesXMLManifest extends JEDcheckerRule
}
/**
* Extra check for menu nodes
* @param SimpleXMLElement $node XML node
*
* @return void