From 3324bb12b028c20e1fed58da6ea2daf9208e23e9 Mon Sep 17 00:00:00 2001 From: Peter van Westen Date: Wed, 27 Jun 2012 16:53:50 +0300 Subject: [PATCH 01/11] Added more allowed defines via array. Changed order of stripos checks to be as quick as possible. --- .../com_jedchecker/libraries/rules/jexec.php | 52 +++++++++++-------- 1 file changed, 31 insertions(+), 21 deletions(-) diff --git a/source/administrator/components/com_jedchecker/libraries/rules/jexec.php b/source/administrator/components/com_jedchecker/libraries/rules/jexec.php index b2b8311..aab0779 100644 --- a/source/administrator/components/com_jedchecker/libraries/rules/jexec.php +++ b/source/administrator/components/com_jedchecker/libraries/rules/jexec.php @@ -68,33 +68,43 @@ class jedcheckerRulesJexec { $content = (array) file($file); + $defines = array( + '_JEXEC', + 'JPATH_PLATFORM', + 'JPATH_BASE', + 'AKEEBAENGINE', + 'WF_EDITOR' + ); + foreach($content AS $line) { - $pos_2 = strpos($line, '_JEXEC'); + foreach ($defines AS $define) + { + // Search for "defined" + $pos_1 = stripos($line, 'defined'); + // Skip the line if "defined" is not found + if ($pos_1 === false) { + continue; + } - // Skip the line if _JEXEC is not found - if($pos_2 === false) { - // Alternatively search for JPATH_PLATFORM - $pos_2 = strpos($line, 'JPATH_PLATFORM'); + // Search for "die". + // "or" may not be present depending on syntax + $pos_3 = stripos($line, 'die'); + // Skip the line if "die" is not found + if ($pos_3 === false) { + continue; + } - // Nothing found, skip the line + // Search for the define + $pos_2 = strpos($line, $define); + // Skip the line if the define is not found if($pos_2 === false) continue; - } - // Search for "defined" and "die". "or" may not be present - // depending on syntax - $pos_1 = stripos($line, 'defined'); - $pos_3 = stripos($line, 'die'); - - // Both words must be present - if($pos_1 === false || $pos_3 === false) { - continue; - } - - // Check the position of the words - if($pos_2 > $pos_1 && $pos_3 > $pos_2) { - unset($content); - return true; + // Check the position of the words + if($pos_2 > $pos_1 && $pos_3 > $pos_2) { + unset($content); + return true; + } } } From a6b428751845f75e117e12254f696b3b7a57f798 Mon Sep 17 00:00:00 2001 From: Peter van Westen Date: Wed, 27 Jun 2012 17:08:33 +0300 Subject: [PATCH 02/11] Added skips for index.html checks in system folders --- .../libraries/rules/htmlindexes.php | 71 +++++++++++++------ 1 file changed, 50 insertions(+), 21 deletions(-) diff --git a/source/administrator/components/com_jedchecker/libraries/rules/htmlindexes.php b/source/administrator/components/com_jedchecker/libraries/rules/htmlindexes.php index 7d00704..4312e66 100644 --- a/source/administrator/components/com_jedchecker/libraries/rules/htmlindexes.php +++ b/source/administrator/components/com_jedchecker/libraries/rules/htmlindexes.php @@ -13,8 +13,9 @@ class jedcheckerRulesHtmlindexes { public $folders = array(); public $indexes = array(); - public function check($startFolder){ - $this->findHtml($startFolder); + public function check($startFolder) + { + $this->findHtml($startFolder, 1); /** * let us "merge" the 2 arrays @@ -42,30 +43,58 @@ class jedcheckerRulesHtmlindexes { * + it also saves all folders names in the folders array (folder_name => false) * @param $start */ - public function findHtml($start) { - $iterator = new RecursiveDirectoryIterator($start); + public function findHtml($start, $root = 0) + { - // there should be a better way to find out if the main directory has an index.html file... - if(file_exists($start.'/index.html')) { - $this->folders[$start] = true; - } else { - $this->folders[$start] = false; - } + // array of system folders (regex) + // will match paths ending with these folders + $system_folders = array( + 'administrator', + 'components', + 'language', + 'language/.*', + 'media', + 'modules', + 'plugins', + 'plugins/content', + 'plugins/editors', + 'plugins/editors-xtd', + 'plugins/finder', + 'plugins/search', + 'plugins/system', + 'plugins/user' + ); - foreach($iterator as $file){ - if($file->isFile()) { - if($file->getFileName() == 'index.html') { - // fill an array with the tables that contain an index.html file - $this->indexes[$file->getPath()] = true; + $iterator = new DirectoryIterator($start); + + foreach ($iterator as $file) { + if ($file->isFile()) { + continue; + } + + $path = $file->getPathname(); + + // set the path to the root start path only for first time + if ($root && $file->getFileName() == '.') { + $path = $start; + } else if ($file->isDot()) { + continue; + } + + $this->folders[$path] = true; + // only check index.html in non-system folders + if (!preg_match('#/('.implode('|', $system_folders).')$#i', str_replace('\\', '/', $path))) { + if (!file_exists($path.'/index.html')) { + $this->folders[$path] = false; } } else { - //let us save all folders in an array - $this->folders[$file->getPathname()] = false; - $this->findHtml($file->getPathname()); - + // set parent to true too + $this->folders[dirname($path)] = true; + } + // search in subfolders if not same as start + if ($path != $start) { + $this->findHtml($path); } } - - } } \ No newline at end of file From 0871349cbb1efab988e4d0d474e7b1112d3bdb29 Mon Sep 17 00:00:00 2001 From: Daniel Dimitrov Date: Thu, 28 Jun 2012 08:57:05 +0200 Subject: [PATCH 03/11] fixing reported bug by Alain Rivest - max execution level reached - on linux machines --- .../components/com_jedchecker/controllers/uploads.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/administrator/components/com_jedchecker/controllers/uploads.php b/source/administrator/components/com_jedchecker/controllers/uploads.php index 23601f3..dc9c9c2 100644 --- a/source/administrator/components/com_jedchecker/controllers/uploads.php +++ b/source/administrator/components/com_jedchecker/controllers/uploads.php @@ -122,7 +122,7 @@ class jedcheckerControllerUploads extends JController $this->unzipAll($unzip); } } - } else { + } else if (!$iterator->isDot()) { $this->unzipAll($file->getPathname()); } From b11194520cb668152e31c532956ab62affb229a9 Mon Sep 17 00:00:00 2001 From: Daniel Dimitrov Date: Thu, 28 Jun 2012 09:15:14 +0200 Subject: [PATCH 04/11] adding installation check for php version --- .../components/com_jedchecker/jedchecker.xml | 1 + .../components/com_jedchecker/script.php | 31 ++++++++++++++++++- .../language/en-GB/en-GB.com_jedchecker.ini | 3 +- 3 files changed, 32 insertions(+), 3 deletions(-) diff --git a/source/administrator/components/com_jedchecker/jedchecker.xml b/source/administrator/components/com_jedchecker/jedchecker.xml index 7d1462b..22767fa 100644 --- a/source/administrator/components/com_jedchecker/jedchecker.xml +++ b/source/administrator/components/com_jedchecker/jedchecker.xml @@ -10,6 +10,7 @@ http://www.gnu.org/copyleft/gpl.html GNU/GPL + script.php COM_@@COMPONENTNAMEUPPERCASE@@ diff --git a/source/administrator/components/com_jedchecker/script.php b/source/administrator/components/com_jedchecker/script.php index b5c9881..c05f6f7 100644 --- a/source/administrator/components/com_jedchecker/script.php +++ b/source/administrator/components/com_jedchecker/script.php @@ -7,4 +7,33 @@ * @license GNU General Public License version 2 or later; see LICENSE */ -defined('_JEXEC') or die('Restricted access'); \ No newline at end of file +defined('_JEXEC') or die('Restricted access'); + + +class com_jedcheckerInstallerScript +{ + protected $extension = 'com_jedchecker'; + + function preflight( $type, $parent ) { + $this->parent = $parent; + if (version_compare(PHP_VERSION, '5.5.6', '<')) { + $this->loadLanguage(); + Jerror::raiseWarning(null, JText::sprintf('COM_JEDCHECKER_PHP_VERSION_INCOMPATIBLE', PHP_VERSION, '5.3.6')); + return false; + } + } + + + public function loadLanguage() + { + $extension = $this->extension; + $jlang =& JFactory::getLanguage(); + $path = $this->parent->getParent()->getPath('source') . '/administrator'; + $jlang->load($extension, $path, 'en-GB', true); + $jlang->load($extension, $path, $jlang->getDefault(), true); + $jlang->load($extension, $path, null, true); + $jlang->load($extension . '.sys', $path, 'en-GB', true); + $jlang->load($extension . '.sys', $path, $jlang->getDefault(), true); + $jlang->load($extension . '.sys', $path, null, true); + } +} \ No newline at end of file diff --git a/source/administrator/language/en-GB/en-GB.com_jedchecker.ini b/source/administrator/language/en-GB/en-GB.com_jedchecker.ini index fcd3aee..9c340b6 100644 --- a/source/administrator/language/en-GB/en-GB.com_jedchecker.ini +++ b/source/administrator/language/en-GB/en-GB.com_jedchecker.ini @@ -24,5 +24,4 @@ COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML inst COM_JEDCHECKER_RULE_PH3_DESC="An install file should include the license information in a license-tag. The license must be GPL or GPL compatible." COM_JEDCHECKER_EVERYTHING_SEEMS_TO_BE_FINE_WITH_THAT_RULE="Congrats! Everything seems to be fine with that rule!" COM_JEDCHECKER_DEVELOPED_BY="JEDchecker is primary developed by compojoom.com" - - +COM_JEDCHECKER_PHP_VERSION_INCOMPATIBLE="JEDchecker is incompatible with the PHP version that you run on this site: %s. You would need at least PHP Version %s. Aborting installation" From 121f6cdba304b06478a9cfe7bd5cd730061339f5 Mon Sep 17 00:00:00 2001 From: Daniel Dimitrov Date: Thu, 28 Jun 2012 09:21:59 +0200 Subject: [PATCH 05/11] Wall of honor gets bigger! --- .../components/com_jedchecker/views/uploads/tmpl/default.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php b/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php index d754d0d..4137fce 100644 --- a/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php +++ b/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php @@ -61,6 +61,8 @@ JHtml::script('media/com_jedchecker/js/police.js');

From 24e3ba0cb23f4105c88fadc913695f6ab3468867 Mon Sep 17 00:00:00 2001 From: Daniel Dimitrov Date: Thu, 28 Jun 2012 09:22:23 +0200 Subject: [PATCH 06/11] wrong php version number :) --- source/administrator/components/com_jedchecker/script.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/administrator/components/com_jedchecker/script.php b/source/administrator/components/com_jedchecker/script.php index c05f6f7..d9c0f69 100644 --- a/source/administrator/components/com_jedchecker/script.php +++ b/source/administrator/components/com_jedchecker/script.php @@ -16,7 +16,7 @@ class com_jedcheckerInstallerScript function preflight( $type, $parent ) { $this->parent = $parent; - if (version_compare(PHP_VERSION, '5.5.6', '<')) { + if (version_compare(PHP_VERSION, '5.3.6', '<')) { $this->loadLanguage(); Jerror::raiseWarning(null, JText::sprintf('COM_JEDCHECKER_PHP_VERSION_INCOMPATIBLE', PHP_VERSION, '5.3.6')); return false; From a554d9cb9426c58b2ccf91f046c9f9a49367fda0 Mon Sep 17 00:00:00 2001 From: Daniel Dimitrov Date: Thu, 28 Jun 2012 09:25:39 +0200 Subject: [PATCH 07/11] adding opentranslators to the wall of Honor - they deserve to be there --- .../components/com_jedchecker/views/uploads/tmpl/default.php | 1 + 1 file changed, 1 insertion(+) diff --git a/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php b/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php index 4137fce..15724d4 100644 --- a/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php +++ b/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php @@ -63,6 +63,7 @@ JHtml::script('media/com_jedchecker/js/police.js');
  • Tobias Kuhn (projectfork)
  • Peter van Westen (NoNumber!)
  • Alain Rivest (Aldra.ca)
    • +
  • OpenTranslators (opentranslators.org)
    • From ab27c25ccba3c67ee13d4c5a128e7ce578a5470f Mon Sep 17 00:00:00 2001 From: Daniel Dimitrov Date: Thu, 28 Jun 2012 09:33:39 +0200 Subject: [PATCH 08/11] adding new translations thanks to opentranslators! --- .../language/da-DK/da-DK.com_jedchecker.ini | 27 +++++++++++++++++++ .../da-DK/da-DK.com_jedchecker.sys.ini | 2 ++ .../language/it-IT/it-IT.com_jedchecker.ini | 27 +++++++++++++++++++ .../it-IT/it-IT.com_jedchecker.sys.ini | 2 ++ .../language/pt-BR/pt-BR.com_jedchecker.ini | 27 +++++++++++++++++++ .../pt-BR/pt-BR.com_jedchecker.sys.ini | 2 ++ .../language/pt-PT/pt-PT.com_jedchecker.ini | 27 +++++++++++++++++++ .../pt-PT/pt-PT.com_jedchecker.sys.ini | 2 ++ 8 files changed, 116 insertions(+) create mode 100644 source/administrator/language/da-DK/da-DK.com_jedchecker.ini create mode 100644 source/administrator/language/da-DK/da-DK.com_jedchecker.sys.ini create mode 100644 source/administrator/language/it-IT/it-IT.com_jedchecker.ini create mode 100644 source/administrator/language/it-IT/it-IT.com_jedchecker.sys.ini create mode 100644 source/administrator/language/pt-BR/pt-BR.com_jedchecker.ini create mode 100644 source/administrator/language/pt-BR/pt-BR.com_jedchecker.sys.ini create mode 100644 source/administrator/language/pt-PT/pt-PT.com_jedchecker.ini create mode 100644 source/administrator/language/pt-PT/pt-PT.com_jedchecker.sys.ini diff --git a/source/administrator/language/da-DK/da-DK.com_jedchecker.ini b/source/administrator/language/da-DK/da-DK.com_jedchecker.ini new file mode 100644 index 0000000..683c972 --- /dev/null +++ b/source/administrator/language/da-DK/da-DK.com_jedchecker.ini @@ -0,0 +1,27 @@ +; Language files have to start with semicolon (;) otherwise we have problems with transifex +COM_JEDCHECKER_UPLOAD_WAS_SUCCESSFUL="Upload lykkedes" +COM_JEDCHECKER_UNZIP_SUCCESS="Udpakning lykkedes! Du kan nu fortsætte ved at klikke på check knappen!" +COM_JEDCHECKER_UNZIP_FAILED="Udpakning mislykkedes" +COM_JEDCHECKER_CONGRATS="Tillykke! Hvis du anvender denne komponent så har du sikkert udviklet en Joomla!® udvidelse! Nu kommer den "_QQ_"besværlige"_QQ_" del - at få den listet i Joomla Extension Directory (JED). JED har strenge krav til de udvidelser som bliver listet der. Disse krav kan findes her. I øjeblikket testes udvidelser manuelt for kode problemer. Denne komponent er et forsøg på at simplificere dit og JED redaktørernes liv ved automatisk at tjekke koden for almindelige fejl i udvidelser." +COM_JEDCHECKER_CODE_STANDARDS="Vores mål er dog ikke kun at teste udvidelserne for almindelige kodefejl, der forhindrer det i at blive listet i JED. Vores mål er, at også have check for kodestandarder som JPlatform har. Dette vil sikre, at joomla udviklere er klar over JPlatform kodestandarder og dette kunne hæve overliggeren for kvalitet endnu højere i vores joomla community! Til dette har vi brug for din hjælp! Tag et kig på github projektsiden. Fork komponenten! Tilføj din kodekontrol og send os dine pull anmodninger!" +COM_JEDCHECKER_HOW_TO_USE="Hvordan kan du så bruge denne komponent???" +COM_JEDCHECKER_STEP1="Upload din komponent/programudvidelse/modul zip-fil ved hjælp af upload formularen nedenfor" +COM_JEDCHECKER_STEP2="Klik på udpak" +COM_JEDCHECKER_STEP3="Klik på check og gennemgå resultaterne" +COM_JEDCHECKER_WALL_OF_HONOR="Bidragsydere" +COM_JEDCHECKER_PEOPLE_THAT_HAVE_HELPED_WITH_THE_DEVELOPMENT="Folk, der har hjulpet med udviklingen af denne komponent" +COM_JEDCHECKER_HOW_TO_INTERPRET_RESULTS="Hvordan fortolkes resultaterne?" +COM_JEDCHECKER_RULE_SE1="Regel:SE1 - Udvidelse mangler index.html fil i alle mapper" +COM_JEDCHECKER_RULE_SE1_DESC="Hvis du ønsker din udvidelse listet på JED, bør du sikre dig, at alle dine udvidelse mapper indeholder en index.html fil. - Udviklere bryder sig overhovedet ikke om denne regel - det udfylder din pakke med index.html filer, som forsinker installationsprocessen osv. Men index.html filer giver beskyttelse for dårligt konfigurerede webhosts (man kunne indvende, om vi skulle forsøge at gøre noget for dem), men så længe joomla CMS leveres med disse filer vil JED kræve at udvidelser også har dem." +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING="JEDchecker kontrollerer hver enkelt mappe i din pakke for tilstedeværelse af index.html filer, men dette betyder ikke, at alle mapper skal have en index.html fil. For eksempel - behøver sprog mapper ikke have en index.html fil, fordi joomla CMS har index.html filer disse steder.Hvis din pakke har følgende struktur:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING1="Korrekt læsning af JEDchecker resultaterne for SE1:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING2="Hvis JEDchecker fortæller dig, at du har mangler index.html i følgende mapper:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING3="Er du faktisk kun nødt til at bekymre dig om" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING4="da disse 2 mapper ikke har index.html filerne, når din komponent bliver installeret" +COM_JEDCHECKER_RULE_PH2="Regel PH2 - PHP filer mangler JEXEC sikkerhed" +COM_JEDCHECKER_RULE_PH2_DESC="Alle PHP filer i din udvidelse skal have en defined('_JEXEC') or die(); sætning i begyndelsen af hver fil. Dette sikrer, at filen ikke kan åbnes uden for joomla installationen og på denne måde øges sikkerheden for dit websted." +; COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML install file" +; COM_JEDCHECKER_RULE_PH3_DESC="An install file should include the license information in a license-tag. The license must be GPL or GPL compatible." +COM_JEDCHECKER_EVERYTHING_SEEMS_TO_BE_FINE_WITH_THAT_RULE="Tillykke! Alt synes at være fint med denne regel!" +COM_JEDCHECKER_DEVELOPED_BY="JEDchecker er primært udviklet af compojoom.com" +; COM_JEDCHECKER_PHP_VERSION_INCOMPATIBLE="JEDchecker is incompatible with the PHP version that you run on this site: %s. You would need at least PHP Version %s. Aborting installation" diff --git a/source/administrator/language/da-DK/da-DK.com_jedchecker.sys.ini b/source/administrator/language/da-DK/da-DK.com_jedchecker.sys.ini new file mode 100644 index 0000000..8006706 --- /dev/null +++ b/source/administrator/language/da-DK/da-DK.com_jedchecker.sys.ini @@ -0,0 +1,2 @@ +; Language files have to start with semicolon (;) otherwise we have problems with transifex +COM_JEDCHECKER="JEDchecker" \ No newline at end of file diff --git a/source/administrator/language/it-IT/it-IT.com_jedchecker.ini b/source/administrator/language/it-IT/it-IT.com_jedchecker.ini new file mode 100644 index 0000000..df7d2f6 --- /dev/null +++ b/source/administrator/language/it-IT/it-IT.com_jedchecker.ini @@ -0,0 +1,27 @@ +; Language files have to start with semicolon (;) otherwise we have problems with transifex +COM_JEDCHECKER_UPLOAD_WAS_SUCCESSFUL="Upload completato" +COM_JEDCHECKER_UNZIP_SUCCESS="Decompressione completata! Adesso vai avanti e premi il pulsante Controlla!" +COM_JEDCHECKER_UNZIP_FAILED="Decompressione fallita" +COM_JEDCHECKER_CONGRATS="Congratulazioni! Se usi questo componente, molto probabilmente hai sviluppato un'estensione per Joomla!®. Adesso arriva la parte "_QQ_"dura"_QQ_" - pubblicarla nella Joomla Extension Directory (JED). La JED ha dei requisiti severi per le estensioni che vengono pubblicate. Questi requisiti possono esssere trovati qui. Attualmente le estensioni sono testate manualmente per verificare problemi di codice. Questo componente è un tentativo per semplificare la vita degli editori della JED, controllando automaticamente gli errori più comuni nel codice delle estensioni." +COM_JEDCHECKER_CODE_STANDARDS="Ad ogni modo il nostro obiettivo non è solo quello di testare le estensioni contro gli errori comuni nel codice che impediscono la pubblicazione nella JED. Il nostro obiettivo è anche quello di avere dei controlli standard del codice come quelli che la JPlatform ha. Ciò assicurerà che gli sviluppatori di estensioni per Joomla saranno attenti agli standard di programmazione di JPlatform e ciò potrà elevare la barra della qualità nella nostra comunità di Joomla sempre più in alto! Per questo abbiamo bisogno di te! Dai un'occhiata alla pagina del progetto su github. Fai un fork del componente! Aggiungi i tuoi controlli del codice ed inviaci le tue richieste di pull!" +COM_JEDCHECKER_HOW_TO_USE="Come usare questo componente?" +COM_JEDCHECKER_STEP1="Carica il file zip del tuo componente/plugin/modulo utilizzando il modulo di upload sotto" +COM_JEDCHECKER_STEP2="Premi su Decomprimi" +COM_JEDCHECKER_STEP3="Premi su Controlla e rivedi i risultati" +COM_JEDCHECKER_WALL_OF_HONOR="Muro d'onore" +COM_JEDCHECKER_PEOPLE_THAT_HAVE_HELPED_WITH_THE_DEVELOPMENT="Persone che hanno contribuito allo sviluppo di questo componente" +COM_JEDCHECKER_HOW_TO_INTERPRET_RESULTS="Come interpretare i risultati?" +COM_JEDCHECKER_RULE_SE1="Regola:SE1 - L'estensione non dispone dei file index.html in tutte le cartelle" +COM_JEDCHECKER_RULE_SE1_DESC="Se vuoi che la tua estensione sia pubblicata nella JED, devi assicurarti che tutte le cartelle della tua estensione contengano un file index.html. - Gli sviluppatori non amano questa regola - dicendo che riempiendo il tuo pacchetto con i file index.html, si rallenta il processo d'installazione ecc. Ma i file index.html forniscono protezione per gli host configurati male (ci si potrebbe chiedere se si possa fare qualcosa per quelli), ma finché il CMS Joomla viene fornito con questi file, JED richiede che anche le estensioni li abbiano." +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING="Il JEDChecker controlla ogni singola cartella nel tuo pacchetto alla ricerca dei file index.html, ma ciò non vuol dire che tutte le cartelle debbano avere un file index.html. Per esempio - la cartella language non necessita di un file index.html, poiché il CMS Joomla ha un file index.html in queste cartelle. Se il tuo pacchetto ha la struttura seguente:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING1="Lettura corretta dei risultati di JEDChecker per SE1:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING2="Se JEDchecker ti dice che il file index.html è mancante nelle seguenti cartelle:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING3="Hai veramente bisogno di preoccuparti solo per" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING4="perché quelle 2 cartelle non hanno il file index.html quando il tuo componente viene installato" +COM_JEDCHECKER_RULE_PH2="Regola PH2 - I file PHP non presentano la protezione JEXEC" +COM_JEDCHECKER_RULE_PH2_DESC="Tutti i file PHP nella tua estensioni devono avere definito uno statement ('_JEXEC') or die(); all'inizio di ogni file. Ciò assicura che il file non possa essere aperto all'esterno di un'installazione di Joomla ed in questo modo aumenta la sicurezza del tuo sito." +; COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML install file" +; COM_JEDCHECKER_RULE_PH3_DESC="An install file should include the license information in a license-tag. The license must be GPL or GPL compatible." +COM_JEDCHECKER_EVERYTHING_SEEMS_TO_BE_FINE_WITH_THAT_RULE="Congratulazioni! Sembra essere tutto ok con questa regola!" +COM_JEDCHECKER_DEVELOPED_BY="JEDchecker è sviluppato principalmente da compojoom.com" +; COM_JEDCHECKER_PHP_VERSION_INCOMPATIBLE="JEDchecker is incompatible with the PHP version that you run on this site: %s. You would need at least PHP Version %s. Aborting installation" diff --git a/source/administrator/language/it-IT/it-IT.com_jedchecker.sys.ini b/source/administrator/language/it-IT/it-IT.com_jedchecker.sys.ini new file mode 100644 index 0000000..8006706 --- /dev/null +++ b/source/administrator/language/it-IT/it-IT.com_jedchecker.sys.ini @@ -0,0 +1,2 @@ +; Language files have to start with semicolon (;) otherwise we have problems with transifex +COM_JEDCHECKER="JEDchecker" \ No newline at end of file diff --git a/source/administrator/language/pt-BR/pt-BR.com_jedchecker.ini b/source/administrator/language/pt-BR/pt-BR.com_jedchecker.ini new file mode 100644 index 0000000..82c3986 --- /dev/null +++ b/source/administrator/language/pt-BR/pt-BR.com_jedchecker.ini @@ -0,0 +1,27 @@ +; Language files have to start with semicolon (;) otherwise we have problems with transifex +COM_JEDCHECKER_UPLOAD_WAS_SUCCESSFUL="Upload bem sucedido" +COM_JEDCHECKER_UNZIP_SUCCESS="Descompactação bem sucedida! Vá adiante e clique no botão Checar!" +COM_JEDCHECKER_UNZIP_FAILED="A descompactação falhou" +; COM_JEDCHECKER_CONGRATS="Congratulations! If you use this component then you've most probably developed a Joomla!® extension! Now comes the "_QQ_"hard"_QQ_" part - getting it listed in the Joomla Extension Directory (JED). The JED has strict requirements to the extensions that get listed there. Those requirements can be found here. Currently extensions are being manually tested for code problems. This component is an attempt to simplify your and the JED editors life's by automatically checking the code for common errors in extensions." +; COM_JEDCHECKER_CODE_STANDARDS="However our goal is not only to test the extensions against common code errors that prevent it from getting listed in the JED. Our goal is to also have code standards checks such as the JPlatform has. This would ensure that joomla extension developers are aware of the JPlatform coding standards and this could raise the quality bar in our Joomla community even higher! For this we will need you! Have a look at the github project page. Fork the component! Add your code checks and send us your pull requests!" +COM_JEDCHECKER_HOW_TO_USE="Como usar este componente???" +COM_JEDCHECKER_STEP1="Envie seu arquivo zip component/plugin/module utilizando o formulário de envio abaixo" +COM_JEDCHECKER_STEP2="Clique em descompactar" +COM_JEDCHECKER_STEP3="Clique em checar e veja os resultados" +COM_JEDCHECKER_WALL_OF_HONOR="Parede de honra" +COM_JEDCHECKER_PEOPLE_THAT_HAVE_HELPED_WITH_THE_DEVELOPMENT="Pessoas que contribuíram com o desenvolvimento deste componente" +COM_JEDCHECKER_HOW_TO_INTERPRET_RESULTS="Como interpretar os resultados?" +COM_JEDCHECKER_RULE_SE1="Regra:SE1 - Extensão sem o arquivo index.html em todas as pastas" +; COM_JEDCHECKER_RULE_SE1_DESC="If you want your extension to be listed on the JED, then you should make sure that all your extension folders contain an index.html file. - Developers don't like this rule at all - it fills your package with index.html files, which in terms slows down the installation process etc. But index.html files provide protection for badly configured hosts (one could argue if we need to try to do anything for those), but as long the joomla CMS comes with those files the JED is going to require that extensions also have those." +; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING="The JEDchecker checks every single folder in your package for the presence of index.html files,but this doesn't mean that all folders need to have an index.html file. For example - language folders don't need to have an index.html file, because the joomla CMS has index.html files in those locations.If your package has the following structure:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING1="Lendo corretamente os resultados de JEDchecker para SE1:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING2="Se o JEDchecker diz a você que há ausência de index.html nas seguintes pastas:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING3="Você na verdade precisa se preocupar apenas com" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING4="pois essas 2 pastas não vão ter os arquivos index. html quando o componente é instalado" +COM_JEDCHECKER_RULE_PH2="Regra PH2 - arquivos PHP sem segurança JEXEC" +COM_JEDCHECKER_RULE_PH2_DESC="Todos os arquivos PHP de sua extensão precisam ter uma afirmativa defined('_JEXEC') or die(); no início de cada arquivo. Isso assegura que o arquivo não possa ser aberto fora da instalação joomla e assim aumenta a segurança de seu site." +; COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML install file" +; COM_JEDCHECKER_RULE_PH3_DESC="An install file should include the license information in a license-tag. The license must be GPL or GPL compatible." +COM_JEDCHECKER_EVERYTHING_SEEMS_TO_BE_FINE_WITH_THAT_RULE="Parabéns! Tudo aparenta estar bem com essa regra!" +COM_JEDCHECKER_DEVELOPED_BY="JEDchecker é principalmente desenvolvido por compojoom.com" +; COM_JEDCHECKER_PHP_VERSION_INCOMPATIBLE="JEDchecker is incompatible with the PHP version that you run on this site: %s. You would need at least PHP Version %s. Aborting installation" diff --git a/source/administrator/language/pt-BR/pt-BR.com_jedchecker.sys.ini b/source/administrator/language/pt-BR/pt-BR.com_jedchecker.sys.ini new file mode 100644 index 0000000..8006706 --- /dev/null +++ b/source/administrator/language/pt-BR/pt-BR.com_jedchecker.sys.ini @@ -0,0 +1,2 @@ +; Language files have to start with semicolon (;) otherwise we have problems with transifex +COM_JEDCHECKER="JEDchecker" \ No newline at end of file diff --git a/source/administrator/language/pt-PT/pt-PT.com_jedchecker.ini b/source/administrator/language/pt-PT/pt-PT.com_jedchecker.ini new file mode 100644 index 0000000..65b7158 --- /dev/null +++ b/source/administrator/language/pt-PT/pt-PT.com_jedchecker.ini @@ -0,0 +1,27 @@ +; Language files have to start with semicolon (;) otherwise we have problems with transifex +COM_JEDCHECKER_UPLOAD_WAS_SUCCESSFUL="Carregamento bem sucedido" +COM_JEDCHECKER_UNZIP_SUCCESS="Descompactação bem sucedida! Continue e clique no botão Verificar!" +COM_JEDCHECKER_UNZIP_FAILED="A descompactação falhou" +; COM_JEDCHECKER_CONGRATS="Congratulations! If you use this component then you've most probably developed a Joomla!® extension! Now comes the "_QQ_"hard"_QQ_" part - getting it listed in the Joomla Extension Directory (JED). The JED has strict requirements to the extensions that get listed there. Those requirements can be found here. Currently extensions are being manually tested for code problems. This component is an attempt to simplify your and the JED editors life's by automatically checking the code for common errors in extensions." +; COM_JEDCHECKER_CODE_STANDARDS="However our goal is not only to test the extensions against common code errors that prevent it from getting listed in the JED. Our goal is to also have code standards checks such as the JPlatform has. This would ensure that joomla extension developers are aware of the JPlatform coding standards and this could raise the quality bar in our Joomla community even higher! For this we will need you! Have a look at the github project page. Fork the component! Add your code checks and send us your pull requests!" +COM_JEDCHECKER_HOW_TO_USE="Como usar este componente?" +; COM_JEDCHECKER_STEP1="Upload your component/plugin/module zip file by using the upload form below" +COM_JEDCHECKER_STEP2="Clique em descompactar" +COM_JEDCHECKER_STEP3="Clique para rever os resultados" +COM_JEDCHECKER_WALL_OF_HONOR="Quadro de honra" +; COM_JEDCHECKER_PEOPLE_THAT_HAVE_HELPED_WITH_THE_DEVELOPMENT="People that have helped with the development of this component" +COM_JEDCHECKER_HOW_TO_INTERPRET_RESULTS="Como interpretar os resultados" +COM_JEDCHECKER_RULE_SE1="Regra:SE1 - Necessário incluir um ficheiro index.html em todas as pastas da extensão" +; COM_JEDCHECKER_RULE_SE1_DESC="If you want your extension to be listed on the JED, then you should make sure that all your extension folders contain an index.html file. - Developers don't like this rule at all - it fills your package with index.html files, which in terms slows down the installation process etc. But index.html files provide protection for badly configured hosts (one could argue if we need to try to do anything for those), but as long the joomla CMS comes with those files the JED is going to require that extensions also have those." +; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING="The JEDchecker checks every single folder in your package for the presence of index.html files,but this doesn't mean that all folders need to have an index.html file. For example - language folders don't need to have an index.html file, because the joomla CMS has index.html files in those locations.If your package has the following structure:" +; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING1="Properly reading the JEDchecker results for SE1:" +; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING2="If the JEDchecker tells you that you have missing index.html in the following folders:" +COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING3="Não tem nada com que se preocupar de momento" +; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING4="as those 2 folders won't have the index.html files when your component gets installed" +COM_JEDCHECKER_RULE_PH2="Regra PH2 - É necessário a verificação de segurança JEXEC em todos os ficheiros PHP" +; COM_JEDCHECKER_RULE_PH2_DESC="All the PHP files in your extension needs to have a defined('_JEXEC') or die(); statement in the beginning of each file. This ensures that the file cannot be opened outside of the joomla installation and this way increases the security of your site." +; COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML install file" +; COM_JEDCHECKER_RULE_PH3_DESC="An install file should include the license information in a license-tag. The license must be GPL or GPL compatible." +COM_JEDCHECKER_EVERYTHING_SEEMS_TO_BE_FINE_WITH_THAT_RULE="Parabéns! Parece estar tudo correto relativamente a esta regra" +COM_JEDCHECKER_DEVELOPED_BY="JEDchecker +e desenvolvido por compojoom.com" +; COM_JEDCHECKER_PHP_VERSION_INCOMPATIBLE="JEDchecker is incompatible with the PHP version that you run on this site: %s. You would need at least PHP Version %s. Aborting installation" diff --git a/source/administrator/language/pt-PT/pt-PT.com_jedchecker.sys.ini b/source/administrator/language/pt-PT/pt-PT.com_jedchecker.sys.ini new file mode 100644 index 0000000..8006706 --- /dev/null +++ b/source/administrator/language/pt-PT/pt-PT.com_jedchecker.sys.ini @@ -0,0 +1,2 @@ +; Language files have to start with semicolon (;) otherwise we have problems with transifex +COM_JEDCHECKER="JEDchecker" \ No newline at end of file From 303257082fe6ecc159791f88c99ffdc58c8d4899 Mon Sep 17 00:00:00 2001 From: Daniel Dimitrov Date: Thu, 28 Jun 2012 09:39:00 +0200 Subject: [PATCH 09/11] SE1 was not showing ok message if every folder was containing index.html files --- .../components/com_jedchecker/libraries/rules/htmlindexes.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/administrator/components/com_jedchecker/libraries/rules/htmlindexes.php b/source/administrator/components/com_jedchecker/libraries/rules/htmlindexes.php index 4312e66..7f2ac54 100644 --- a/source/administrator/components/com_jedchecker/libraries/rules/htmlindexes.php +++ b/source/administrator/components/com_jedchecker/libraries/rules/htmlindexes.php @@ -24,7 +24,7 @@ class jedcheckerRulesHtmlindexes { $indexes = array_replace($this->folders, $this->indexes); echo ''.JText::_('COM_JEDCHECKER_RULE_SE1') . '
    '; - if(count($indexes)) { + if(count($indexes) && in_array(false, $indexes)) { foreach($indexes as $key => $index) { if(!$index) { echo $key . '
    '; From 62efa3295318d73fee1355f0bfb065fdf46dcf08 Mon Sep 17 00:00:00 2001 From: nonumber Date: Thu, 28 Jun 2012 11:53:00 +0200 Subject: [PATCH 10/11] Removed info and texts strings regarding index.html files in allowed folders (seeing this is fixed in rule now) Removed the ! from NoNumber (very important :) ) --- .../views/uploads/tmpl/default.php | 27 +++---------------- .../language/da-DK/da-DK.com_jedchecker.ini | 5 ---- .../language/en-GB/en-GB.com_jedchecker.ini | 5 ---- .../language/it-IT/it-IT.com_jedchecker.ini | 5 ---- .../language/pt-BR/pt-BR.com_jedchecker.ini | 5 ---- .../language/pt-PT/pt-PT.com_jedchecker.ini | 5 ---- 6 files changed, 3 insertions(+), 49 deletions(-) diff --git a/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php b/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php index 15724d4..d130d42 100644 --- a/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php +++ b/source/administrator/components/com_jedchecker/views/uploads/tmpl/default.php @@ -61,9 +61,9 @@ JHtml::script('media/com_jedchecker/js/police.js');

    @@ -82,27 +82,6 @@ JHtml::script('media/com_jedchecker/js/police.js');

    - -

    -
    -
    - - administrator/components/your_component
    - components/your_component
    -
    - - administrator
    - administrator/components
    - administrator/components/your_component
    - components/
    - components/your_component
    -
    - - administrator/components/your_component
    - components/your_component
    - - -

  • diff --git a/source/administrator/language/da-DK/da-DK.com_jedchecker.ini b/source/administrator/language/da-DK/da-DK.com_jedchecker.ini index 683c972..0f158a2 100644 --- a/source/administrator/language/da-DK/da-DK.com_jedchecker.ini +++ b/source/administrator/language/da-DK/da-DK.com_jedchecker.ini @@ -13,11 +13,6 @@ COM_JEDCHECKER_PEOPLE_THAT_HAVE_HELPED_WITH_THE_DEVELOPMENT="Folk, der har hjulp COM_JEDCHECKER_HOW_TO_INTERPRET_RESULTS="Hvordan fortolkes resultaterne?" COM_JEDCHECKER_RULE_SE1="Regel:SE1 - Udvidelse mangler index.html fil i alle mapper" COM_JEDCHECKER_RULE_SE1_DESC="Hvis du ønsker din udvidelse listet på JED, bør du sikre dig, at alle dine udvidelse mapper indeholder en index.html fil. - Udviklere bryder sig overhovedet ikke om denne regel - det udfylder din pakke med index.html filer, som forsinker installationsprocessen osv. Men index.html filer giver beskyttelse for dårligt konfigurerede webhosts (man kunne indvende, om vi skulle forsøge at gøre noget for dem), men så længe joomla CMS leveres med disse filer vil JED kræve at udvidelser også har dem." -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING="JEDchecker kontrollerer hver enkelt mappe i din pakke for tilstedeværelse af index.html filer, men dette betyder ikke, at alle mapper skal have en index.html fil. For eksempel - behøver sprog mapper ikke have en index.html fil, fordi joomla CMS har index.html filer disse steder.Hvis din pakke har følgende struktur:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING1="Korrekt læsning af JEDchecker resultaterne for SE1:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING2="Hvis JEDchecker fortæller dig, at du har mangler index.html i følgende mapper:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING3="Er du faktisk kun nødt til at bekymre dig om" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING4="da disse 2 mapper ikke har index.html filerne, når din komponent bliver installeret" COM_JEDCHECKER_RULE_PH2="Regel PH2 - PHP filer mangler JEXEC sikkerhed" COM_JEDCHECKER_RULE_PH2_DESC="Alle PHP filer i din udvidelse skal have en defined('_JEXEC') or die(); sætning i begyndelsen af hver fil. Dette sikrer, at filen ikke kan åbnes uden for joomla installationen og på denne måde øges sikkerheden for dit websted." ; COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML install file" diff --git a/source/administrator/language/en-GB/en-GB.com_jedchecker.ini b/source/administrator/language/en-GB/en-GB.com_jedchecker.ini index 9c340b6..c421edf 100644 --- a/source/administrator/language/en-GB/en-GB.com_jedchecker.ini +++ b/source/administrator/language/en-GB/en-GB.com_jedchecker.ini @@ -13,11 +13,6 @@ COM_JEDCHECKER_PEOPLE_THAT_HAVE_HELPED_WITH_THE_DEVELOPMENT="People that have he COM_JEDCHECKER_HOW_TO_INTERPRET_RESULTS="How to interpret the results?" COM_JEDCHECKER_RULE_SE1="Rule SE1 - Extension is missing index.html file in all folders" COM_JEDCHECKER_RULE_SE1_DESC="If you want your extension to be listed on the JED, then you should make sure that all your extension folders contain an index.html file. - Developers don't like this rule at all - it fills your package with index.html files, which in terms slows down the installation process etc. But index.html files provide protection for badly configured hosts (one could argue if we need to try to do anything for those), but as long the joomla CMS comes with those files the JED is going to require that extensions also have those." -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING="The JEDchecker checks every single folder in your package for the presence of index.html files,but this doesn't mean that all folders need to have an index.html file. For example - language folders don't need to have an index.html file, because the joomla CMS has index.html files in those locations.If your package has the following structure:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING1="Properly reading the JEDchecker results for SE1:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING2="If the JEDchecker tells you that you have missing index.html in the following folders:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING3="You actually need to worry only about" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING4="as those 2 folders won't have the index.html files when your component gets installed" COM_JEDCHECKER_RULE_PH2="Rule PH2 - PHP Files missing JEXEC security" COM_JEDCHECKER_RULE_PH2_DESC="All the PHP files in your extension needs to have a defined('_JEXEC') or die(); statement in the beginning of each file. This ensures that the file cannot be opened outside of the joomla installation and this way increases the security of your site." COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML install file" diff --git a/source/administrator/language/it-IT/it-IT.com_jedchecker.ini b/source/administrator/language/it-IT/it-IT.com_jedchecker.ini index df7d2f6..4df8aac 100644 --- a/source/administrator/language/it-IT/it-IT.com_jedchecker.ini +++ b/source/administrator/language/it-IT/it-IT.com_jedchecker.ini @@ -13,11 +13,6 @@ COM_JEDCHECKER_PEOPLE_THAT_HAVE_HELPED_WITH_THE_DEVELOPMENT="Persone che hanno c COM_JEDCHECKER_HOW_TO_INTERPRET_RESULTS="Come interpretare i risultati?" COM_JEDCHECKER_RULE_SE1="Regola:SE1 - L'estensione non dispone dei file index.html in tutte le cartelle" COM_JEDCHECKER_RULE_SE1_DESC="Se vuoi che la tua estensione sia pubblicata nella JED, devi assicurarti che tutte le cartelle della tua estensione contengano un file index.html. - Gli sviluppatori non amano questa regola - dicendo che riempiendo il tuo pacchetto con i file index.html, si rallenta il processo d'installazione ecc. Ma i file index.html forniscono protezione per gli host configurati male (ci si potrebbe chiedere se si possa fare qualcosa per quelli), ma finché il CMS Joomla viene fornito con questi file, JED richiede che anche le estensioni li abbiano." -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING="Il JEDChecker controlla ogni singola cartella nel tuo pacchetto alla ricerca dei file index.html, ma ciò non vuol dire che tutte le cartelle debbano avere un file index.html. Per esempio - la cartella language non necessita di un file index.html, poiché il CMS Joomla ha un file index.html in queste cartelle. Se il tuo pacchetto ha la struttura seguente:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING1="Lettura corretta dei risultati di JEDChecker per SE1:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING2="Se JEDchecker ti dice che il file index.html è mancante nelle seguenti cartelle:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING3="Hai veramente bisogno di preoccuparti solo per" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING4="perché quelle 2 cartelle non hanno il file index.html quando il tuo componente viene installato" COM_JEDCHECKER_RULE_PH2="Regola PH2 - I file PHP non presentano la protezione JEXEC" COM_JEDCHECKER_RULE_PH2_DESC="Tutti i file PHP nella tua estensioni devono avere definito uno statement ('_JEXEC') or die(); all'inizio di ogni file. Ciò assicura che il file non possa essere aperto all'esterno di un'installazione di Joomla ed in questo modo aumenta la sicurezza del tuo sito." ; COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML install file" diff --git a/source/administrator/language/pt-BR/pt-BR.com_jedchecker.ini b/source/administrator/language/pt-BR/pt-BR.com_jedchecker.ini index 82c3986..1f1f86c 100644 --- a/source/administrator/language/pt-BR/pt-BR.com_jedchecker.ini +++ b/source/administrator/language/pt-BR/pt-BR.com_jedchecker.ini @@ -13,11 +13,6 @@ COM_JEDCHECKER_PEOPLE_THAT_HAVE_HELPED_WITH_THE_DEVELOPMENT="Pessoas que contrib COM_JEDCHECKER_HOW_TO_INTERPRET_RESULTS="Como interpretar os resultados?" COM_JEDCHECKER_RULE_SE1="Regra:SE1 - Extensão sem o arquivo index.html em todas as pastas" ; COM_JEDCHECKER_RULE_SE1_DESC="If you want your extension to be listed on the JED, then you should make sure that all your extension folders contain an index.html file. - Developers don't like this rule at all - it fills your package with index.html files, which in terms slows down the installation process etc. But index.html files provide protection for badly configured hosts (one could argue if we need to try to do anything for those), but as long the joomla CMS comes with those files the JED is going to require that extensions also have those." -; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING="The JEDchecker checks every single folder in your package for the presence of index.html files,but this doesn't mean that all folders need to have an index.html file. For example - language folders don't need to have an index.html file, because the joomla CMS has index.html files in those locations.If your package has the following structure:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING1="Lendo corretamente os resultados de JEDchecker para SE1:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING2="Se o JEDchecker diz a você que há ausência de index.html nas seguintes pastas:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING3="Você na verdade precisa se preocupar apenas com" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING4="pois essas 2 pastas não vão ter os arquivos index. html quando o componente é instalado" COM_JEDCHECKER_RULE_PH2="Regra PH2 - arquivos PHP sem segurança JEXEC" COM_JEDCHECKER_RULE_PH2_DESC="Todos os arquivos PHP de sua extensão precisam ter uma afirmativa defined('_JEXEC') or die(); no início de cada arquivo. Isso assegura que o arquivo não possa ser aberto fora da instalação joomla e assim aumenta a segurança de seu site." ; COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML install file" diff --git a/source/administrator/language/pt-PT/pt-PT.com_jedchecker.ini b/source/administrator/language/pt-PT/pt-PT.com_jedchecker.ini index 65b7158..788c1fd 100644 --- a/source/administrator/language/pt-PT/pt-PT.com_jedchecker.ini +++ b/source/administrator/language/pt-PT/pt-PT.com_jedchecker.ini @@ -13,11 +13,6 @@ COM_JEDCHECKER_WALL_OF_HONOR="Quadro de honra" COM_JEDCHECKER_HOW_TO_INTERPRET_RESULTS="Como interpretar os resultados" COM_JEDCHECKER_RULE_SE1="Regra:SE1 - Necessário incluir um ficheiro index.html em todas as pastas da extensão" ; COM_JEDCHECKER_RULE_SE1_DESC="If you want your extension to be listed on the JED, then you should make sure that all your extension folders contain an index.html file. - Developers don't like this rule at all - it fills your package with index.html files, which in terms slows down the installation process etc. But index.html files provide protection for badly configured hosts (one could argue if we need to try to do anything for those), but as long the joomla CMS comes with those files the JED is going to require that extensions also have those." -; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING="The JEDchecker checks every single folder in your package for the presence of index.html files,but this doesn't mean that all folders need to have an index.html file. For example - language folders don't need to have an index.html file, because the joomla CMS has index.html files in those locations.If your package has the following structure:" -; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING1="Properly reading the JEDchecker results for SE1:" -; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING2="If the JEDchecker tells you that you have missing index.html in the following folders:" -COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING3="Não tem nada com que se preocupar de momento" -; COM_JEDCHECKER_RULE_SE1_MORE_INFO_INTERPRETING4="as those 2 folders won't have the index.html files when your component gets installed" COM_JEDCHECKER_RULE_PH2="Regra PH2 - É necessário a verificação de segurança JEXEC em todos os ficheiros PHP" ; COM_JEDCHECKER_RULE_PH2_DESC="All the PHP files in your extension needs to have a defined('_JEXEC') or die(); statement in the beginning of each file. This ensures that the file cannot be opened outside of the joomla installation and this way increases the security of your site." ; COM_JEDCHECKER_RULE_PH3="Rule PH3 - License tag missing or incorrect in XML install file" From 0bafa78beef842b9356caf663634d09134377c99 Mon Sep 17 00:00:00 2001 From: Daniel Dimitrov Date: Fri, 29 Jun 2012 16:37:05 +0200 Subject: [PATCH 11/11] protecting the form with a token --- .../components/com_jedchecker/controllers/uploads.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/administrator/components/com_jedchecker/controllers/uploads.php b/source/administrator/components/com_jedchecker/controllers/uploads.php index dc9c9c2..31191cb 100644 --- a/source/administrator/components/com_jedchecker/controllers/uploads.php +++ b/source/administrator/components/com_jedchecker/controllers/uploads.php @@ -28,6 +28,7 @@ class jedcheckerControllerUploads extends JController */ public function upload() { + JRequest::checkToken() or die( 'Invalid Token' ); $appl = JFactory::getApplication(); $file = JRequest::getVar('extension', '', 'files', 'array'); if ($file['tmp_name']) { @@ -71,6 +72,7 @@ class jedcheckerControllerUploads extends JController */ public function unzip() { + JRequest::checkToken() or die( 'Invalid Token' ); $appl = JFactory::getApplication(); // if folder doesn't exist - create it! if(!JFolder::exists($this->pathUnzipped)) {