From a2bb820771f417ed6a00cce9b56a02c77312d7ac Mon Sep 17 00:00:00 2001
From: Denis Ryabov <dryabov@yandex.ru>
Date: Tue, 9 Mar 2021 23:36:58 +0300
Subject: [PATCH] Check errors in JFolder::folders/files results

---
 .../com_jedchecker/libraries/rules/framework.php | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/administrator/components/com_jedchecker/libraries/rules/framework.php b/administrator/components/com_jedchecker/libraries/rules/framework.php
index f130181..9cd294d 100644
--- a/administrator/components/com_jedchecker/libraries/rules/framework.php
+++ b/administrator/components/com_jedchecker/libraries/rules/framework.php
@@ -62,14 +62,22 @@ class JedcheckerRulesFramework extends JEDcheckerRule
 		$folders = JFolder::folders($this->basedir, $regex_leftover_folders, true, true, array(), array());
 		$files = JFolder::files($this->basedir, $regex_leftover_folders, true, true, array(), array());
 
-		foreach ($folders as $folder)
+		if ($folders !== false)
 		{
-			$this->report->addWarning($folder, JText::_("COM_JEDCHECKER_ERROR_FRAMEWORK_LEFTOVER_FOLDER"));
+			// Warn on leftover folders found
+			foreach ($folders as $folder)
+			{
+				$this->report->addWarning($folder, JText::_("COM_JEDCHECKER_ERROR_FRAMEWORK_LEFTOVER_FOLDER"));
+			}
 		}
 
-		foreach ($files as $file)
+		if ($files !== false)
 		{
-			$this->report->addWarning($file, JText::_("COM_JEDCHECKER_ERROR_FRAMEWORK_LEFTOVER_FILE"));
+			// Warn on leftover filess found
+			foreach ($files as $file)
+			{
+				$this->report->addWarning($file, JText::_("COM_JEDCHECKER_ERROR_FRAMEWORK_LEFTOVER_FILE"));
+			}
 		}
 
 		$this->leftover_folders = explode(',', $leftover_folders);