joomla/jedchecker
33
2
Fork 0
mirror of https://github.com/joomla-extensions/jedchecker.git synced 2024-12-31 21:51:46 +00:00
Code Issues Releases Activity

use warning for BOM followed by newline or comment

Browse Source
This commit is contained in:
Denis Ryabov 2021-02-24 14:52:01 +03:00
parent b0a0a3a0ad
commit c0f76f4da6
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
administrator/components/com_jedchecker/libraries/rules/language.php
View File

@ -19,7 +19,7 @@ require_once JPATH_COMPONENT_ADMINISTRATOR . '/models/rule.php';
* *
* This class validates language ini file * This class validates language ini file
* *
* @since 2.3 * @since 3.0
*/ */
class JedcheckerRulesLanguage extends JEDcheckerRule class JedcheckerRulesLanguage extends JEDcheckerRule
{ {
@ -84,7 +84,15 @@ class JedcheckerRulesLanguage extends JEDcheckerRule
// Check for BOM sequence // Check for BOM sequence
if ($lineno === 0 && strncmp($line, "\xEF\xBB\xBF", 3) === 0) if ($lineno === 0 && strncmp($line, "\xEF\xBB\xBF", 3) === 0)
{ {
$this->report->addError($file, JText::_('COM_JEDCHECKER_LANG_BOM_FOUND'), $startLineno); if (isset($line[3]) && strpos(";\n\r", $line[3]) === false)
{
$this->report->addError($file, JText::_('COM_JEDCHECKER_LANG_BOM_FOUND'), $startLineno);
}
else
{
$this->report->addWarning($file, JText::_('COM_JEDCHECKER_LANG_BOM_FOUND'), $startLineno);
}
// Romeve BOM for further checks // Romeve BOM for further checks
$line = substr($line, 3); $line = substr($line, 3);
} }
@ -227,7 +235,8 @@ class JedcheckerRulesLanguage extends JEDcheckerRule
// Count %n$... (argnum) formats in the string // Count %n$... (argnum) formats in the string
$countArgnum = preg_match_all('/(?<=^|[^%])%\d+\$/', $value); $countArgnum = preg_match_all('/(?<=^|[^%])%\d+\$/', $value);
if ($countAll > 1 && $countArgnum < $countAll) { if ($countAll > 1 && $countArgnum < $countAll)
{
// @todo It's not mentioned in docs // @todo It's not mentioned in docs
$this->report->addInfo($file, JText::_('COM_JEDCHECKER_LANG_RECOMMEND_ARGNUM'), $startLineno, $line); $this->report->addInfo($file, JText::_('COM_JEDCHECKER_LANG_RECOMMEND_ARGNUM'), $startLineno, $line);
} }