joomla/patchtester
33
0
Fork 0
mirror of https://github.com/joomla-extensions/patchtester.git synced 2025-01-11 01:32:05 +00:00
Code Issues Releases Activity

Apply suggestions from code review

Browse Source 
Added some new lines at the end of templates, whites-spaces between casting and attribute, replaced back ticks with double quotes.

Co-Authored-By: SharkyKZ <sharkykz@gmail.com>
This commit is contained in:
Sebastian Enns 2019-10-01 13:23:01 +02:00 committed by GitHub
parent 502a4937ba
commit 6f4a9518b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
administrator/components/com_patchtester/PatchTester/View/Pulls/tmpl/default.php
View File

@ -132,4 +132,4 @@ $filterRtc = $this->escape($this->state->get('filter.rtc'));
<input type="hidden" name="pull_id" id="pull_id" value=""/> <input type="hidden" name="pull_id" id="pull_id" value=""/>
<?php echo HTMLHelper::_('form.token'); ?> <?php echo HTMLHelper::_('form.token'); ?>
</div> </div>
</form> </form>

6
administrator/components/com_patchtester/PatchTester/View/Pulls/tmpl/default_items.php
View File

@ -68,12 +68,12 @@ foreach ($this->items as $i => $item) :
<td class="center"> <td class="center">
<?php if ($item->applied) : ?> <?php if ($item->applied) : ?>
<button type="button" class="btn btn-sm btn-success submitPatch" <button type="button" class="btn btn-sm btn-success submitPatch"
data-task="revert-<?php echo (int)$item->applied; ?>"><?php echo Text::_('COM_PATCHTESTER_REVERT_PATCH'); ?></button> data-task="revert-<?php echo (int) $item->applied; ?>"><?php echo Text::_('COM_PATCHTESTER_REVERT_PATCH'); ?></button>
<br/> <br/>
<?php else : ?> <?php else : ?>
<button type="button" class="btn btn-sm btn-primary submitPatch" <button type="button" class="btn btn-sm btn-primary submitPatch"
data-task="apply-<?php echo (int)$item->pull_id; ?>"><?php echo Text::_('COM_PATCHTESTER_APPLY_PATCH'); ?></button> data-task="apply-<?php echo (int) $item->pull_id; ?>"><?php echo Text::_('COM_PATCHTESTER_APPLY_PATCH'); ?></button>
<?php endif; ?> <?php endif; ?>
</td> </td>
</tr> </tr>
<?php endforeach; <?php endforeach;

2
administrator/components/com_patchtester/install/sql/postgresql/install.sql
View File

@ -24,5 +24,5 @@ CREATE TABLE IF NOT EXISTS "#__patchtester_chain" (
"id" serial NOT NULL, "id" serial NOT NULL,
"insert_id" bigint NOT NULL, "insert_id" bigint NOT NULL,
"pull_id" bigint NOT NULL, "pull_id" bigint NOT NULL,
PRIMARY KEY (`id`) PRIMARY KEY ("id")
); );

6
administrator/templates/atum/html/com_patchtester/pulls/default_items.php
View File

@ -16,7 +16,7 @@ foreach ($this->items as $i => $item) :
if ($item->applied) : if ($item->applied) :
$status = ' class="table-active"'; $status = ' class="table-active"';
endif; endif;
?> ?>
<tr<?php echo $status; ?>> <tr<?php echo $status; ?>>
<th scope="row" class="text-center"> <th scope="row" class="text-center">
<?php echo $item->pull_id; ?> <?php echo $item->pull_id; ?>
@ -66,10 +66,10 @@ foreach ($this->items as $i => $item) :
<td class="text-center"> <td class="text-center">
<?php if ($item->applied) : ?> <?php if ($item->applied) : ?>
<button type="button" class="btn btn-sm btn-success submitPatch" <button type="button" class="btn btn-sm btn-success submitPatch"
data-task="revert-<?php echo (int)$item->applied; ?>"><?php echo Text::_('COM_PATCHTESTER_REVERT_PATCH'); ?></button> data-task="revert-<?php echo (int) $item->applied; ?>"><?php echo Text::_('COM_PATCHTESTER_REVERT_PATCH'); ?></button>
<?php else : ?> <?php else : ?>
<button type="button" class="btn btn-sm btn-primary submitPatch" <button type="button" class="btn btn-sm btn-primary submitPatch"
data-task="apply-<?php echo (int)$item->pull_id; ?>"><?php echo Text::_('COM_PATCHTESTER_APPLY_PATCH'); ?></button> data-task="apply-<?php echo (int) $item->pull_id; ?>"><?php echo Text::_('COM_PATCHTESTER_APPLY_PATCH'); ?></button>
<?php endif; ?> <?php endif; ?>
</td> </td>
</tr> </tr>