33
0
mirror of https://github.com/joomla-extensions/patchtester.git synced 2025-01-24 07:38:26 +00:00

Use leading slash consistently, use JHtml::_ versus direct method call

This commit is contained in:
Michael Babker 2015-05-23 11:01:58 -04:00
parent aa4106f00a
commit 9b8a4d6745
2 changed files with 19 additions and 17 deletions

View File

@ -85,7 +85,7 @@ $sortFields = $this->getSortFields();
<?php if (empty($this->items)) : ?> <?php if (empty($this->items)) : ?>
<div class="alert alert-no-items"> <div class="alert alert-no-items">
<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?> <?php echo \JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div> </div>
<?php else : ?> <?php else : ?>
<table class="table table-striped"> <table class="table table-striped">
@ -113,7 +113,7 @@ $sortFields = $this->getSortFields();
</thead> </thead>
<tfoot> <tfoot>
<tr> <tr>
<td colspan="7"> <td colspan="6">
</td> </td>
</tr> </tr>
</tfoot> </tfoot>

View File

@ -30,29 +30,31 @@ $sortFields = $this->getSortFields();
" "
); );
JFactory::getDocument()->addStyleDeclaration( \JFactory::getDocument()->addStyleDeclaration(
' '
.icon-48-patchtester { background-image:url("/media/com_patchtester/images/icon-48-patchtester.png"); } .icon-48-patchtester { background-image:url("/media/com_patchtester/images/icon-48-patchtester.png"); }
' '
); );
echo JHtmlBootstrap::renderModal( echo \JHtml::_(
'modal-refresh', array( 'bootstrap.renderModal',
'url' => JUri::root() . 'administrator/index.php?option=com_patchtester&view=fetch&tmpl=component', 'modal-refresh',
'title' => JText::_('COM_PATCHTESTER_TOOLBAR_FETCH_DATA'), array(
'url' => \JUri::root() . 'administrator/index.php?option=com_patchtester&view=fetch&tmpl=component',
'title' => \JText::_('COM_PATCHTESTER_TOOLBAR_FETCH_DATA'),
'width' => '800px', 'width' => '800px',
'height' => '300px' 'height' => '300px'
) )
); );
?> ?>
<form action="<?php echo JRoute::_('index.php?option=com_patchtester&view=pulls'); ?>" method="post" name="adminForm" id="adminForm"> <form action="<?php echo \JRoute::_('index.php?option=com_patchtester&view=pulls'); ?>" method="post" name="adminForm" id="adminForm">
<div id="j-main-container"> <div id="j-main-container">
<fieldset id="filter-bar"> <fieldset id="filter-bar">
<legend class="element-invisible"><?php echo JText::_('JSEARCH_FILTER_LABEL'); ?></legend> <legend class="element-invisible"><?php echo \JText::_('JSEARCH_FILTER_LABEL'); ?></legend>
<div class="filter-search"> <div class="filter-search">
<label class="filter-search-lbl" for="filter_search"><?php echo JText::_('JSEARCH_FILTER_LABEL'); ?></label> <label class="filter-search-lbl" for="filter_search"><?php echo JText::_('JSEARCH_FILTER_LABEL'); ?></label>
<input type="text" name="filter_search" id="filter_search" value="<?php echo $this->escape($this->state->get('filter.search')); ?>" title="<?php echo JText::_('COM_PATCHTESTER_FILTER_SEARCH_DESCRIPTION'); ?>" /> <input type="text" name="filter_search" id="filter_search" value="<?php echo $this->escape($this->state->get('filter.search')); ?>" title="<?php echo \JText::_('COM_PATCHTESTER_FILTER_SEARCH_DESCRIPTION'); ?>" />
<button type="submit" class="btn"><?php echo JText::_('JSEARCH_FILTER_SUBMIT'); ?></button> <button type="submit" class="btn"><?php echo \JText::_('JSEARCH_FILTER_SUBMIT'); ?></button>
<button type="button" onclick="document.getElementById('filter_search').value='';this.form.submit();"><?php echo JText::_('JSEARCH_FILTER_CLEAR'); ?></button> <button type="button" onclick="document.getElementById('filter_search').value='';this.form.submit();"><?php echo \JText::_('JSEARCH_FILTER_CLEAR'); ?></button>
</div> </div>
<div class="filter-select"> <div class="filter-select">
<label class="selectlabel" for="filter_applied"><?php echo JText::_('COM_PATCHTESTER_FILTER_APPLIED_PATCHES'); ?></label> <label class="selectlabel" for="filter_applied"><?php echo JText::_('COM_PATCHTESTER_FILTER_APPLIED_PATCHES'); ?></label>
@ -61,7 +63,7 @@ echo JHtmlBootstrap::renderModal(
<option value="yes"<?php if ($filterApplied == 'yes') echo ' selected="selected"'; ?>><?php echo \JText::_('COM_PATCHTESTER_APPLIED'); ?></option> <option value="yes"<?php if ($filterApplied == 'yes') echo ' selected="selected"'; ?>><?php echo \JText::_('COM_PATCHTESTER_APPLIED'); ?></option>
<option value="no"<?php if ($filterApplied == 'no') echo ' selected="selected"'; ?>><?php echo \JText::_('COM_PATCHTESTER_NOT_APPLIED'); ?></option> <option value="no"<?php if ($filterApplied == 'no') echo ' selected="selected"'; ?>><?php echo \JText::_('COM_PATCHTESTER_NOT_APPLIED'); ?></option>
</select> </select>
<button type="submit" id="filter-go"><?php echo JText::_('JSUBMIT'); ?></button> <button type="submit" id="filter-go"><?php echo \JText::_('JSUBMIT'); ?></button>
</div> </div>
</fieldset> </fieldset>
<div class="clr"> </div> <div class="clr"> </div>
@ -70,10 +72,10 @@ echo JHtmlBootstrap::renderModal(
<thead> <thead>
<tr> <tr>
<th width="5%" class="nowrap center"> <th width="5%" class="nowrap center">
<?php echo JHtml::_('grid.sort', 'COM_PATCHTESTER_PULL_ID', 'a.pull_id', $listDirn, $listOrder); ?> <?php echo \JHtml::_('grid.sort', 'COM_PATCHTESTER_PULL_ID', 'a.pull_id', $listDirn, $listOrder); ?>
</th> </th>
<th class="nowrap"> <th class="nowrap">
<?php echo JHtml::_('grid.sort', 'JGLOBAL_TITLE', 'a.title', $listDirn, $listOrder); ?> <?php echo \JHtml::_('grid.sort', 'JGLOBAL_TITLE', 'a.title', $listDirn, $listOrder); ?>
</th> </th>
<th width="8%" class="nowrap center"> <th width="8%" class="nowrap center">
<?php echo \JText::_('COM_PATCHTESTER_GITHUB'); ?> <?php echo \JText::_('COM_PATCHTESTER_GITHUB'); ?>
@ -82,7 +84,7 @@ echo JHtmlBootstrap::renderModal(
<?php echo \JText::_('COM_PATCHTESTER_JISSUES'); ?> <?php echo \JText::_('COM_PATCHTESTER_JISSUES'); ?>
</th> </th>
<th width="10%" class="nowrap center"> <th width="10%" class="nowrap center">
<?php echo JHtml::_('grid.sort', 'JSTATUS', 'applied', $listDirn, $listOrder); ?> <?php echo \JHtml::_('grid.sort', 'JSTATUS', 'applied', $listDirn, $listOrder); ?>
</th> </th>
<th width="15%" class="nowrap center"> <th width="15%" class="nowrap center">
<?php echo \JText::_('COM_PATCHTESTER_TEST_THIS_PATCH'); ?> <?php echo \JText::_('COM_PATCHTESTER_TEST_THIS_PATCH'); ?>
@ -106,7 +108,7 @@ echo JHtmlBootstrap::renderModal(
<input type="hidden" name="pull_id" id="pull_id" value="" /> <input type="hidden" name="pull_id" id="pull_id" value="" />
<input type="hidden" name="filter_order" value="<?php echo $listOrder; ?>"/> <input type="hidden" name="filter_order" value="<?php echo $listOrder; ?>"/>
<input type="hidden" name="filter_order_Dir" value="<?php echo $listDirn; ?>"/> <input type="hidden" name="filter_order_Dir" value="<?php echo $listDirn; ?>"/>
<?php echo JHtml::_('form.token'); ?> <?php echo \JHtml::_('form.token'); ?>
</div> </div>
</form> </form>
<?php endif; <?php endif;