joomla/patchtester
33
0
Fork 0
mirror of https://github.com/joomla-extensions/patchtester.git synced 2024-12-23 03:19:00 +00:00
Code Issues Releases Activity

Ensure all JHttp connections are wrapped in try/catch

Browse Source
This commit is contained in:
Michael Babker 2015-05-09 12:35:36 -04:00
parent 5ca5795016
commit b013b85e74
3 changed files with 29 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
administrator/components/com_patchtester/PatchTester/Controller/ApplyController.php
View File

@ -35,7 +35,7 @@ class ApplyController extends DisplayController
if ($model->apply($this->getInput()->getUint('pull_id'))) if ($model->apply($this->getInput()->getUint('pull_id')))
{ {
$msg = \JText::_('COM_PATCHTESTER_APPLY_OK'); $msg = \JText::_('COM_PATCHTESTER_APPLY_OK');
} }
else else
{ {

33
administrator/components/com_patchtester/PatchTester/Model/PullModel.php
View File

@ -142,7 +142,14 @@ class PullModel extends \JModelBase
); );
} }
$pull = $github->pulls->get($this->getState()->get('github_user'), $this->getState()->get('github_repo'), $id); try
{
$pull = $github->pulls->get($this->getState()->get('github_user'), $this->getState()->get('github_repo'), $id);
}
catch (\Exception $e)
{
throw new \RuntimeException(\JText::sprintf('COM_PATCHTESTER_COULD_NOT_CONNECT_TO_GITHUB', $e->getMessage()));
}
if (is_null($pull->head->repo)) if (is_null($pull->head->repo))
{ {
@ -164,7 +171,14 @@ class PullModel extends \JModelBase
$transport = new \JHttp($options, $driver); $transport = new \JHttp($options, $driver);
$patch = $transport->get($pull->diff_url)->body; try
{
$patch = $transport->get($pull->diff_url)->body;
}
catch (\Exception $e)
{
throw new \RuntimeException(\JText::sprintf('COM_PATCHTESTER_COULD_NOT_CONNECT_TO_GITHUB', $e->getMessage()));
}
$files = $this->parsePatch($patch); $files = $this->parsePatch($patch);
@ -177,7 +191,7 @@ class PullModel extends \JModelBase
{ {
if ($file->action == 'deleted' && !file_exists(JPATH_ROOT . '/' . $file->old)) if ($file->action == 'deleted' && !file_exists(JPATH_ROOT . '/' . $file->old))
{ {
throw new \RuntimeException(sprintf(\JText::_('COM_PATCHTESTER_FILE_DELETED_DOES_NOT_EXIST_S'), $file->old)); throw new \RuntimeException(\JText::sprintf('COM_PATCHTESTER_FILE_DELETED_DOES_NOT_EXIST_S', $file->old));
} }
if ($file->action == 'added' || $file->action == 'modified') if ($file->action == 'added' || $file->action == 'modified')
@ -185,18 +199,25 @@ class PullModel extends \JModelBase
// If the backup file already exists, we can't apply the patch // If the backup file already exists, we can't apply the patch
if (file_exists(JPATH_COMPONENT . '/backups/' . md5($file->new) . '.txt')) if (file_exists(JPATH_COMPONENT . '/backups/' . md5($file->new) . '.txt'))
{ {
throw new \RuntimeException(sprintf(\JText::_('COM_PATCHTESTER_CONFLICT_S'), $file->new)); throw new \RuntimeException(\JText::sprintf('COM_PATCHTESTER_CONFLICT_S', $file->new));
} }
if ($file->action == 'modified' && !file_exists(JPATH_ROOT . '/' . $file->old)) if ($file->action == 'modified' && !file_exists(JPATH_ROOT . '/' . $file->old))
{ {
throw new \RuntimeException(sprintf(\JText::_('COM_PATCHTESTER_FILE_MODIFIED_DOES_NOT_EXIST_S'), $file->old)); throw new \RuntimeException(\JText::sprintf('COM_PATCHTESTER_FILE_MODIFIED_DOES_NOT_EXIST_S', $file->old));
} }
$url = 'https://raw.github.com/' . urlencode($pull->head->user->login) . '/' . urlencode($pull->head->repo->name) $url = 'https://raw.github.com/' . urlencode($pull->head->user->login) . '/' . urlencode($pull->head->repo->name)
. '/' . urlencode($pull->head->ref) . '/' . $file->new; . '/' . urlencode($pull->head->ref) . '/' . $file->new;
$file->body = $transport->get($url)->body; try
{
$file->body = $transport->get($url)->body;
}
catch (\Exception $e)
{
throw new \RuntimeException(\JText::sprintf('COM_PATCHTESTER_COULD_NOT_CONNECT_TO_GITHUB', $e->getMessage()));
}
} }
} }

1
administrator/components/com_patchtester/language/en-GB/en-GB.com_patchtester.ini
View File

@ -13,6 +13,7 @@ COM_PATCHTESTER_COMPONENT_DESC="Joomla! Patch Tester Configuration Values"
COM_PATCHTESTER_COMPONENT_LABEL="Joomla! Patch Tester" COM_PATCHTESTER_COMPONENT_LABEL="Joomla! Patch Tester"
COM_PATCHTESTER_CONFIGURATION="Joomla! Patch Tester Settings" COM_PATCHTESTER_CONFIGURATION="Joomla! Patch Tester Settings"
COM_PATCHTESTER_CONFLICT_S="The patch could not be applied because it conflicts with a previously applied patch: %s" COM_PATCHTESTER_CONFLICT_S="The patch could not be applied because it conflicts with a previously applied patch: %s"
COM_PATCHTESTER_COULD_NOT_CONNECT_TO_GITHUB="Could not connect to GitHub with the following error: %s"
COM_PATCHTESTER_ERROR_APPLIED_PATCHES="Cannot fetch data from GitHub while there are applied patches. Please revert those patches before continuing." COM_PATCHTESTER_ERROR_APPLIED_PATCHES="Cannot fetch data from GitHub while there are applied patches. Please revert those patches before continuing."
COM_PATCHTESTER_ERROR_GITHUB_FETCH="Error retrieving pull requests from GitHub: %s" COM_PATCHTESTER_ERROR_GITHUB_FETCH="Error retrieving pull requests from GitHub: %s"
COM_PATCHTESTER_ERROR_INSERT_DATABASE="Error inserting pull request data into the database: %s" COM_PATCHTESTER_ERROR_INSERT_DATABASE="Error inserting pull request data into the database: %s"