33
0
mirror of https://github.com/joomla-extensions/patchtester.git synced 2024-12-22 10:58:58 +00:00

Merge pull request #316 from weeblr/314-missing-pulls-j4

314 missing pulls j4
This commit is contained in:
Roland Dalmulder 2021-03-03 21:22:07 +01:00 committed by GitHub
commit ef98862329
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 5 deletions

View File

@ -211,6 +211,25 @@ class GitHub
return $this->processResponse($this->client->get($prepared['url'], $prepared['headers'])); return $this->processResponse($this->client->get($prepared['url'], $prepared['headers']));
} }
/**
* Get a list of the open pull requests for a repository.
*
* @param string $user The name of the owner of the GitHub repository.
* @param string $repo The name of the GitHub repository.
* @param integer $page The page number from which to get items.
* @param integer $limit The number of items on a page.
*
* @return Response
*
* @since 3.0.0
*/
public function getOpenPulls($user, $repo, $page = 0, $limit = 0)
{
$prepared = $this->prepareRequest("/repos/$user/$repo/pulls", $page, $limit);
return $this->processResponse($this->client->get($prepared['url'], $prepared['headers']));
}
/** /**
* Get an option from the connector. * Get an option from the connector.
* *

View File

@ -508,7 +508,7 @@ class PullsModel extends AbstractModel
// TODO - Option to configure the batch size // TODO - Option to configure the batch size
$batchSize = 100; $batchSize = 100;
$pullsResponse = Helper::initializeGithub()->getOpenIssues( $pullsResponse = Helper::initializeGithub()->getOpenPulls(
$this->getState()->get('github_user'), $this->getState()->get('github_user'),
$this->getState()->get('github_repo'), $this->getState()->get('github_repo'),
$page, $page,
@ -573,8 +573,6 @@ class PullsModel extends AbstractModel
foreach ($pulls as $pull) foreach ($pulls as $pull)
{ {
if (isset($pull->pull_request))
{
// Check if this PR is RTC and has a `PR-` branch label // Check if this PR is RTC and has a `PR-` branch label
$isRTC = false; $isRTC = false;
$isNPM = false; $isNPM = false;
@ -618,14 +616,13 @@ class PullsModel extends AbstractModel
$this->getDb()->quote( $this->getDb()->quote(
HTMLHelper::_('string.truncate', $pull->body, 100) HTMLHelper::_('string.truncate', $pull->body, 100)
), ),
$this->getDb()->quote($pull->pull_request->html_url), $this->getDb()->quote($pull->html_url),
(int) $isRTC, (int) $isRTC,
(int) $isNPM, (int) $isNPM,
$this->getDb()->quote($branch), $this->getDb()->quote($branch),
]; ];
$data[] = implode(',', $pullData); $data[] = implode(',', $pullData);
}
} }
// If there are no pulls to insert then bail, assume we're finished // If there are no pulls to insert then bail, assume we're finished