joomla/patchtester
33
0
Fork 0
mirror of https://github.com/joomla-extensions/patchtester.git synced 2024-12-23 03:19:00 +00:00
Code Issues Releases Activity

Improve performance by only making 1 query

Browse Source
This commit is contained in:
George Wilson 2015-02-17 00:12:08 +00:00
parent 9033f2a4df
commit fe839a077d
1 changed files with 23 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
administrator/components/com_patchtester/PatchTester/Model/PullsModel.php
View File

@ -328,23 +328,32 @@ class PullsModel extends \JModelDatabase
// Dump the old data now
$this->getDb()->truncateTable('#__patchtester_pulls');
foreach ($pulls as &$pull)
// If there are no pulls to insert then bail
if (empty($pulls))
{
return;
}
$data = array();
foreach ($pulls as $pull)
{
// Build the data object to store in the database
$data = new \stdClass;
$data->pull_id = $pull->number;
$data->title = $pull->title;
$data->description = $pull->body;
$data->pull_url = $pull->html_url;
$pullData = array($pull->number, $pull->title, $pull->body, $pull->html_url);
$data[] = implode($pullData, ',');
}
try
{
$this->getDb()->insertObject('#__patchtester_pulls', $data, 'id');
}
catch (\RuntimeException $e)
{
throw new \RuntimeException(\JText::sprintf('COM_PATCHTESTER_ERROR_INSERT_DATABASE', $e->getMessage()));
}
$query = $this->getDb()->getQuery();
$query->insert('#__patchtester_pulls')->columns('pull_id, title, description, pull_url')->values($data);
$this->getDb()->setQuery($query);
try
{
$this->getDb()->execute();
}
catch (\RuntimeException $e)
{
throw new \RuntimeException(\JText::sprintf('COM_PATCHTESTER_ERROR_INSERT_DATABASE', $e->getMessage()));
}
}
else