From bfee41b26d60b340d7e3b9e9610a660e4d9c3560 Mon Sep 17 00:00:00 2001 From: ReLater Date: Wed, 17 Feb 2021 15:27:23 +0100 Subject: [PATCH 1/3] Return an array for count() --- src/modules/mod_weblinks/helper.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/modules/mod_weblinks/helper.php b/src/modules/mod_weblinks/helper.php index 78a27ce..85fbeac 100644 --- a/src/modules/mod_weblinks/helper.php +++ b/src/modules/mod_weblinks/helper.php @@ -106,10 +106,8 @@ class ModWeblinksHelper $item->link = $item->url; } } - - return $items; } - return; + return $items; } } From 95d0f86f1ef04545b437b735e56a592c424fe8e2 Mon Sep 17 00:00:00 2001 From: Tuan Pham Ngoc Date: Wed, 18 Aug 2021 14:24:42 +0700 Subject: [PATCH 2/3] Return empty array on failure --- src/modules/mod_weblinks/helper.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/mod_weblinks/helper.php b/src/modules/mod_weblinks/helper.php index 85fbeac..8bf04fb 100644 --- a/src/modules/mod_weblinks/helper.php +++ b/src/modules/mod_weblinks/helper.php @@ -106,8 +106,10 @@ class ModWeblinksHelper $item->link = $item->url; } } + + return $items; } - return $items; + return array(); } } From 40fec2bdfa4701f82872743eafcef6738c7166fc Mon Sep 17 00:00:00 2001 From: Tuan Pham Ngoc Date: Wed, 18 Aug 2021 14:39:15 +0700 Subject: [PATCH 3/3] Better check --- src/components/com_weblinks/models/categories.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/com_weblinks/models/categories.php b/src/components/com_weblinks/models/categories.php index e5295b3..745e262 100644 --- a/src/components/com_weblinks/models/categories.php +++ b/src/components/com_weblinks/models/categories.php @@ -92,7 +92,7 @@ class WeblinksModelCategories extends JModelList */ public function getItems() { - if (is_null($this->_items) || !count($this->_items)) + if ($this->_items === null) { $app = JFactory::getApplication(); $menu = $app->getMenu();