diff --git a/src/administrator/components/com_weblinks/views/weblink/tmpl/edit_params.php b/src/administrator/components/com_weblinks/views/weblink/tmpl/edit_params.php index 23bb0d1..61d4d85 100644 --- a/src/administrator/components/com_weblinks/views/weblink/tmpl/edit_params.php +++ b/src/administrator/components/com_weblinks/views/weblink/tmpl/edit_params.php @@ -9,20 +9,17 @@ defined('_JEXEC') or die; -$fieldSets = $this->form->getFieldsets('params'); -foreach ($fieldSets as $name => $fieldSet) : - ?> -
- description) && trim($fieldSet->description)) : - echo '

'.$this->escape(JText::_($fieldSet->description)).'

'; - endif; - ?> - form->getFieldset($name) as $field) : ?> -
-
label; ?>
-
input; ?>
-
- +$fieldSets = $this->form->getFieldsets('params'); ?> + $fieldSet) : ?> +
+ description) && trim($fieldSet->description)) : ?> + ' . $this->escape(JText::_($fieldSet->description)) . '

'; ?> + + form->getFieldset($name) as $field) : ?> +
+
label; ?>
+
input; ?>
+
+
diff --git a/src/administrator/components/com_weblinks/views/weblink/view.html.php b/src/administrator/components/com_weblinks/views/weblink/view.html.php index 0d330ab..550c6a7 100644 --- a/src/administrator/components/com_weblinks/views/weblink/view.html.php +++ b/src/administrator/components/com_weblinks/views/weblink/view.html.php @@ -23,40 +23,48 @@ class WeblinksViewWeblink extends JViewLegacy protected $form; /** - * Display the view + * Display the view. + * + * @param string $tpl The name of the template file to parse; automatically searches through the template paths. + * + * @return mixed A string if successful, otherwise an Error object. */ public function display($tpl = null) { - $this->state = $this->get('State'); - $this->item = $this->get('Item'); - $this->form = $this->get('Form'); + $this->state = $this->get('State'); + $this->item = $this->get('Item'); + $this->form = $this->get('Form'); // Check for errors. if (count($errors = $this->get('Errors'))) { JError::raiseError(500, implode("\n", $errors)); + return false; } $this->addToolbar(); + parent::display($tpl); } /** * Add the page title and toolbar. * + * @return void + * * @since 1.6 */ protected function addToolbar() { JFactory::getApplication()->input->set('hidemainmenu', true); - $user = JFactory::getUser(); - $isNew = ($this->item->id == 0); - $checkedOut = !($this->item->checked_out == 0 || $this->item->checked_out == $user->get('id')); + $user = JFactory::getUser(); + $isNew = ($this->item->id == 0); + $checkedOut = !($this->item->checked_out == 0 || $this->item->checked_out == $user->get('id')); // Since we don't track these assets at the item level, use the category id. - $canDo = JHelperContent::getActions('com_weblinks', 'category', $this->item->catid); + $canDo = JHelperContent::getActions('com_weblinks', 'category', $this->item->catid); JToolbarHelper::title($isNew ? JText::_('COM_WEBLINKS_MANAGER_WEBLINK_NEW') : JText::_('COM_WEBLINKS_MANAGER_WEBLINK_EDIT'), 'link weblinks'); diff --git a/src/administrator/components/com_weblinks/views/weblinks/tmpl/default.php b/src/administrator/components/com_weblinks/views/weblinks/tmpl/default.php index 0801f94..c102846 100644 --- a/src/administrator/components/com_weblinks/views/weblinks/tmpl/default.php +++ b/src/administrator/components/com_weblinks/views/weblinks/tmpl/default.php @@ -9,7 +9,7 @@ defined('_JEXEC') or die; -JHtml::addIncludePath(JPATH_COMPONENT.'/helpers/html'); +JHtml::addIncludePath(JPATH_COMPONENT . '/helpers/html'); JHtml::_('bootstrap.tooltip'); JHtml::_('behavior.multiselect'); @@ -129,7 +129,7 @@ if ($saveOrder) editor, $item->checked_out_time, 'weblinks.', $canCheckin); ?> - + escape($item->title); ?> escape($item->title); ?> @@ -150,7 +150,7 @@ if ($saveOrder) language == '*') : ?> - + language_title ? JHtml::_('image', 'mod_languages/' . $item->language_image . '.gif', $item->language_title, array('title' => $item->language_title), true) . ' ' . $this->escape($item->language_title) : JText::_('JUNDEFINED'); ?> diff --git a/src/administrator/components/com_weblinks/views/weblinks/view.html.php b/src/administrator/components/com_weblinks/views/weblinks/view.html.php index 05712f5..8487ae6 100644 --- a/src/administrator/components/com_weblinks/views/weblinks/view.html.php +++ b/src/administrator/components/com_weblinks/views/weblinks/view.html.php @@ -23,9 +23,11 @@ class WeblinksViewWeblinks extends JViewLegacy protected $state; /** - * Display the view + * Display the view. * - * @return void + * @param string $tpl The name of the template file to parse; automatically searches through the template paths. + * + * @return mixed A string if successful, otherwise an Error object. */ public function display($tpl = null) { @@ -52,6 +54,8 @@ class WeblinksViewWeblinks extends JViewLegacy /** * Add the page title and toolbar. * + * @return void + * * @since 1.6 */ protected function addToolbar()