From ceed4b3be0aedc9a0ccbb11fc04e85897860e65e Mon Sep 17 00:00:00 2001
From: dgt41 <d.grammatiko@gmail.com>
Date: Thu, 13 Nov 2014 17:09:11 +0200
Subject: [PATCH] Introduce jquery formvalidator for com_weblinks

#### Executive summary

This PR converts the form validation on com_weblinks to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!

#### Testing

1. Apply first PR #4888 (!important)
2. Apply this PR
3. In the admin area go to com_weblinks and try to submit any form.

If no javascript errors are logged in your browser and the functionality remains the same your test is a pass in any other case please report the errors here

Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
http://localhost/administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt
Logout and log in to demonstrate the use of noframes without mt.
---
 src/com_weblinks/admin/views/weblink/tmpl/edit.php | 13 +++++++------
 .../admin/views/weblinks/tmpl/default.php          | 14 ++++++++------
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/com_weblinks/admin/views/weblink/tmpl/edit.php b/src/com_weblinks/admin/views/weblink/tmpl/edit.php
index 64ca6f0..18afe40 100644
--- a/src/com_weblinks/admin/views/weblink/tmpl/edit.php
+++ b/src/com_weblinks/admin/views/weblink/tmpl/edit.php
@@ -11,19 +11,20 @@ defined('_JEXEC') or die;
 
 JHtml::addIncludePath(JPATH_COMPONENT . '/helpers/html');
 
-JHtml::_('behavior.formvalidation');
+JHtml::_('behavior.formvalidator');
 JHtml::_('formbehavior.chosen', 'select');
 
-?>
-<script type="text/javascript">
+JFactory::getDocument()->addScriptDeclaration("
+jQuery(document).ready(function() {
 	Joomla.submitbutton = function(task)
 	{
-		if (task == 'weblink.cancel' || document.formvalidator.isValid(document.id('weblink-form'))) {
-			<?php echo $this->form->getField('description')->save(); ?>
+		if (task == 'weblink.cancel' || document.formvalidator.isValid(document.getElementById('weblink-form'))) {
+			" . $this->form->getField('description')->save() . "
 			Joomla.submitform(task, document.getElementById('weblink-form'));
 		}
 	}
-</script>
+});");
+?>
 
 <form action="<?php echo JRoute::_('index.php?option=com_weblinks&layout=edit&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="weblink-form" class="form-validate">
 
diff --git a/src/com_weblinks/admin/views/weblinks/tmpl/default.php b/src/com_weblinks/admin/views/weblinks/tmpl/default.php
index 1b00ae8..c528597 100644
--- a/src/com_weblinks/admin/views/weblinks/tmpl/default.php
+++ b/src/com_weblinks/admin/views/weblinks/tmpl/default.php
@@ -27,24 +27,26 @@ if ($saveOrder)
 	JHtml::_('sortablelist.sortable', 'weblinkList', 'adminForm', strtolower($listDirn), $saveOrderingUrl);
 }
 $sortFields = $this->getSortFields();
-?>
-<script type="text/javascript">
+
+JFactory::getDocument()->addScriptDeclaration('
+jQuery(document).ready(function() {
 	Joomla.orderTable = function()
 	{
 		table = document.getElementById("sortTable");
 		direction = document.getElementById("directionTable");
 		order = table.options[table.selectedIndex].value;
-		if (order != '<?php echo $listOrder; ?>')
+		if (order != "' . $listOrder . '")
 		{
-			dirn = 'asc';
+			dirn = "asc";
 		}
 		else
 		{
 			dirn = direction.options[direction.selectedIndex].value;
 		}
-		Joomla.tableOrdering(order, dirn, '');
+		Joomla.tableOrdering(order, dirn, "");
 	}
-</script>
+		});');
+?>
 <form action="<?php echo JRoute::_('index.php?option=com_weblinks&view=weblinks'); ?>" method="post" name="adminForm" id="adminForm">
 <?php if (!empty( $this->sidebar)) : ?>
 	<div id="j-sidebar-container" class="span2">