I have a site which provided me with an error 500 code. On looking in the server logs it pointed to an extra ) on row 33 which is now on row 34 in the staging version.
Testing:
Code Review
Check it still shows correctly.
Looks good, thank you @chrisdavenport
If we ever have time (probably at the code sprint, added it to the todo-list), we should move the file existing check to the constructor.. We need that for every task 👍
* Create Categories on-the-fly on Weblink edit form
Create Categories on-the-fly on Weblink edit form (1/3)
* Create Categories on-the-fly on Weblink edit form
Create Categories on-the-fly on Weblink edit form (2/3)
* Create Categories on-the-fly on Weblink edit form
Create Categories on-the-fly on Weblink edit form (3/3
* CS fix
CS fix
* Update weblink.xml
* Update weblink.php
* Update weblink.php
* one space
one space as suggested
* Started integration of drone.io scripts
* Started integration of drone.io scripts
* Started integration of drone.io scripts
* Removed curl testing
* Skipping frontend tests for drone
* Skipping frontend tests for drone
* Updated scenario skip comment and removed time from .drone.yml
```
FILE: ...oomla-extensions/weblinks/src/components/com_weblinks/helpers/route.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
183 | ERROR | Missing comment for param "$needles" at position 1
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
```
hopfully the last on to go with: https://github.com/joomla-extensions/weblinks/pull/227
chrisdavenport
andrepereiradasilva
Tito Alvarez
Chris Davenport
Twincarb
Walt Sorensen
Nicola Galgano
zero-24
Daniel Dimitrov
Niels Nübel
Jelle Kok
Yves Hoppe
javier gomez
Puneet Kala
Robert Deutz