I have a site which provided me with an error 500 code. On looking in the server logs it pointed to an extra ) on row 33 which is now on row 34 in the staging version.
Testing:
Code Review
Check it still shows correctly.
* Create Categories on-the-fly on Weblink edit form
Create Categories on-the-fly on Weblink edit form (1/3)
* Create Categories on-the-fly on Weblink edit form
Create Categories on-the-fly on Weblink edit form (2/3)
* Create Categories on-the-fly on Weblink edit form
Create Categories on-the-fly on Weblink edit form (3/3
* CS fix
CS fix
* Update weblink.xml
* Update weblink.php
* Update weblink.php
* one space
one space as suggested
```
FILE: ...oomla-extensions/weblinks/src/components/com_weblinks/helpers/route.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
183 | ERROR | Missing comment for param "$needles" at position 1
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
```
hopfully the last on to go with: https://github.com/joomla-extensions/weblinks/pull/227
* allow captcha on submit web link
allow captcha on submit web link (1/5)
* allow captcha on submit web link
allow captcha on submit web link (2/5)
* allow captcha on submit web link
allow captcha on submit web link (3/5)
* allow captcha on submit web link
allow captcha on submit web link (4/5)
* allow captcha on submit web link
allow captcha on submit web link (5/5)
* CS fix
CS fix
* XML CS for https://github.com/joomla-extensions/weblinks/pull/223
Simple XML CS https://github.com/joomla-extensions/weblinks/pull/223
* update captcha message
update captcha message like com_user, com_contatct #10931
* handle session data
handle session data 1(/2)
* handle session data
handle session data (2/2)
* move buttons down
move buttons down
* fix conflicts with #231
fix conflicts with #231
* fix conflicts with #231
fix conflicts with #231
* implements searchtools, filters and merge the other two PR
* just to force travis to run
* revert
* filter is published
* filter is published 2
* modify filter test thanks to yvesh
* code style
* elseif , not else if
* Group by subcategories on mod_weblinks
* BUGFIX: added missing 1-column option.
* GroupBySubcategories turned Off by default.
* Improved readability of inline php statements.
* "Weblink" to "Web Link" (frontend module)
* "Weblink" to "Web Link" (package language)
* update site name
* admin language
* admin language 2
* missing this one
* change text also in tests
* forgot one
* change frontend tests too
File must be copied because we have two versions of jorobo with different expectations where the file is located. If we udpate to jorobo > 0.2 then we delete the one in src
https://github.com/joomla-projects/jorobo/pull/13
testing this one #7832 i was unable to install pkg_weblinks on MSSQL
the problem was that these fields (version,hits,modified_user_id,checked_out) was passed like a string instead of bigint
On the Weblinks list page, you can filter the results by putting text in the filter box. Clicking the X won't empty the search field.
To test:
1. Go to Weblinks
2. Filter the list
3. Click the X and it doesn't clear the search field
4. Apply patch
5. Reload page
6. Clear the search field with the X
7. Search field is now cleared
#### Steps to reproduce the issue
try to install on postgresql
#### Expected result
it install
#### Actual result
don't install
#### System information (as much as possible)
Weblinks 3.4.1 Release Candidate 2
PostgreSQL 9.3.5
Joomla 3.4.4-dev
#### Additional comments
without the setting give an invalid timestamp for the category table
#### Executive summary
This PR converts the form validation on com_weblinks to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!
#### Testing
1. Apply first PR #4888 (!important)
2. Apply this PR
3. In the admin area go to com_weblinks and try to submit any form.
If no javascript errors are logged in your browser and the functionality remains the same your test is a pass in any other case please report the errors here
Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
http://localhost/administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt
Logout and log in to demonstrate the use of noframes without mt.
