octoleo/gh-ost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Experiment: removing LOCK IN SHARE MODE

Browse Source
This commit is contained in:
Shlomi Noach 2018-02-11 15:54:51 +02:00
parent 4390c854ca
commit 19e00e5ddc
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
go/sql/builder.go
View File

@ -214,18 +214,14 @@ func BuildRangeInsertQuery(databaseName, originalTableName, ghostTableName strin
return "", explodedArgs, err return "", explodedArgs, err
} }
explodedArgs = append(explodedArgs, rangeExplodedArgs...) explodedArgs = append(explodedArgs, rangeExplodedArgs...)
transactionalClause := ""
if transactionalTable {
transactionalClause = "lock in share mode"
}
result = fmt.Sprintf(` result = fmt.Sprintf(`
insert /* gh-ost %s.%s */ ignore into %s.%s (%s) insert /* gh-ost %s.%s */ ignore into %s.%s (%s)
(select %s from %s.%s force index (%s) (select %s from %s.%s force index (%s)
where (%s and %s) %s where (%s and %s)
) )
`, databaseName, originalTableName, databaseName, ghostTableName, mappedSharedColumnsListing, `, databaseName, originalTableName, databaseName, ghostTableName, mappedSharedColumnsListing,
sharedColumnsListing, databaseName, originalTableName, uniqueKey, sharedColumnsListing, databaseName, originalTableName, uniqueKey,
rangeStartComparison, rangeEndComparison, transactionalClause) rangeStartComparison, rangeEndComparison)
return result, explodedArgs, nil return result, explodedArgs, nil
} }