From 59c1a24774482723f100f1213bb16b16497b40f6 Mon Sep 17 00:00:00 2001 From: Morgan Tocker Date: Tue, 15 Nov 2022 15:40:21 -0700 Subject: [PATCH] remove useless func per review --- go/logic/migrator.go | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/go/logic/migrator.go b/go/logic/migrator.go index 0f4ebba..a102188 100644 --- a/go/logic/migrator.go +++ b/go/logic/migrator.go @@ -364,7 +364,7 @@ func (this *Migrator) Migrate() (err error) { // Attempt to do this if AttemptInstantDDL is set. if this.migrationContext.AttemptInstantDDL { this.migrationContext.Log.Infof("Attempting to execute alter with ALGORITHM=INSTANT") - if err := this.attemptInstantDDL(); err == nil { + if err := this.applier.AttemptInstantDDL(); err == nil { this.migrationContext.Log.Infof("Success! table %s.%s migrated instantly", sql.EscapeName(this.migrationContext.DatabaseName), sql.EscapeName(this.migrationContext.OriginalTableName)) return nil } else { @@ -745,13 +745,6 @@ func (this *Migrator) initiateServer() (err error) { return nil } -// attemptInstantDDL tries to apply the DDL statement directly to the table -// using a ALGORITHM=INSTANT assertion. If this fails, it will return an error, -// in which case the original algorithm should be used. -func (this *Migrator) attemptInstantDDL() (err error) { - return this.applier.AttemptInstantDDL() -} - // initiateInspector connects, validates and inspects the "inspector" server. // The "inspector" server is typically a replica; it is where we issue some // queries such as: