From 5ea949f31e1e44c773e1ebfd67ee878ff7b60f1e Mon Sep 17 00:00:00 2001 From: Tim Vaillancourt Date: Fri, 25 Feb 2022 00:02:27 +0100 Subject: [PATCH] Remove end-of-life MySQL 5.5.x --- .github/workflows/replica-tests.yml | 2 +- doc/requirements-and-limitations.md | 2 ++ go/logic/inspect.go | 3 +-- localtests/datetime-submillis-zeroleading/ignore_versions | 1 - localtests/datetime-submillis/ignore_versions | 1 - localtests/datetime-to-timestamp-pk-fail/ignore_versions | 1 - localtests/datetime/ignore_versions | 1 - localtests/generated-columns-add57/ignore_versions | 2 +- localtests/generated-columns-rename57/ignore_versions | 2 +- localtests/generated-columns57-unique/ignore_versions | 2 +- localtests/generated-columns57/ignore_versions | 2 +- localtests/geometry57/ignore_versions | 2 +- localtests/json57/ignore_versions | 2 +- localtests/json57dml/ignore_versions | 2 +- localtests/spatial57/ignore_versions | 2 +- localtests/swap-pk-uk/ignore_versions | 1 - localtests/swap-uk-uk/ignore_versions | 1 - localtests/timestamp-to-datetime/ignore_versions | 1 - localtests/timestamp/ignore_versions | 1 - localtests/tz-datetime-ts/ignore_versions | 1 - localtests/tz/ignore_versions | 1 - 21 files changed, 12 insertions(+), 21 deletions(-) delete mode 100644 localtests/datetime-submillis-zeroleading/ignore_versions delete mode 100644 localtests/datetime-submillis/ignore_versions delete mode 100644 localtests/datetime-to-timestamp-pk-fail/ignore_versions delete mode 100644 localtests/datetime/ignore_versions delete mode 100644 localtests/swap-pk-uk/ignore_versions delete mode 100644 localtests/swap-uk-uk/ignore_versions delete mode 100644 localtests/timestamp-to-datetime/ignore_versions delete mode 100644 localtests/timestamp/ignore_versions delete mode 100644 localtests/tz-datetime-ts/ignore_versions delete mode 100644 localtests/tz/ignore_versions diff --git a/.github/workflows/replica-tests.yml b/.github/workflows/replica-tests.yml index f1c887c..7d4ef15 100644 --- a/.github/workflows/replica-tests.yml +++ b/.github/workflows/replica-tests.yml @@ -8,7 +8,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - version: [mysql-5.5.62,mysql-5.6.43,mysql-5.7.25,mysql-8.0.16] + version: [mysql-5.6.43,mysql-5.7.25,mysql-8.0.16] steps: - uses: actions/checkout@v2 diff --git a/doc/requirements-and-limitations.md b/doc/requirements-and-limitations.md index e09ae4f..2f5a346 100644 --- a/doc/requirements-and-limitations.md +++ b/doc/requirements-and-limitations.md @@ -2,6 +2,8 @@ ### Requirements +- `gh-ost` currently requires MySQL versions 5.6 and greater. + - You will need to have one server serving Row Based Replication (RBR) format binary logs. Right now `FULL` row image is supported. `MINIMAL` to be supported in the near future. `gh-ost` prefers to work with replicas. You may [still have your master configured with Statement Based Replication](migrating-with-sbr.md) (SBR). - If you are using a replica, the table must have an identical schema between the master and replica. diff --git a/go/logic/inspect.go b/go/logic/inspect.go index 524c3bf..9f82d74 100644 --- a/go/logic/inspect.go +++ b/go/logic/inspect.go @@ -364,8 +364,7 @@ func (this *Inspector) validateBinlogs() error { } query = `select @@global.binlog_row_image` if err := this.db.QueryRow(query).Scan(&this.migrationContext.OriginalBinlogRowImage); err != nil { - // Only as of 5.6. We wish to support 5.5 as well - this.migrationContext.OriginalBinlogRowImage = "FULL" + return err } this.migrationContext.OriginalBinlogRowImage = strings.ToUpper(this.migrationContext.OriginalBinlogRowImage) if this.migrationContext.OriginalBinlogRowImage != "FULL" { diff --git a/localtests/datetime-submillis-zeroleading/ignore_versions b/localtests/datetime-submillis-zeroleading/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/datetime-submillis-zeroleading/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5) diff --git a/localtests/datetime-submillis/ignore_versions b/localtests/datetime-submillis/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/datetime-submillis/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5) diff --git a/localtests/datetime-to-timestamp-pk-fail/ignore_versions b/localtests/datetime-to-timestamp-pk-fail/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/datetime-to-timestamp-pk-fail/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5) diff --git a/localtests/datetime/ignore_versions b/localtests/datetime/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/datetime/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5) diff --git a/localtests/generated-columns-add57/ignore_versions b/localtests/generated-columns-add57/ignore_versions index b6de5f8..ce491e6 100644 --- a/localtests/generated-columns-add57/ignore_versions +++ b/localtests/generated-columns-add57/ignore_versions @@ -1 +1 @@ -(5.5|5.6) +(5.6) diff --git a/localtests/generated-columns-rename57/ignore_versions b/localtests/generated-columns-rename57/ignore_versions index b6de5f8..ce491e6 100644 --- a/localtests/generated-columns-rename57/ignore_versions +++ b/localtests/generated-columns-rename57/ignore_versions @@ -1 +1 @@ -(5.5|5.6) +(5.6) diff --git a/localtests/generated-columns57-unique/ignore_versions b/localtests/generated-columns57-unique/ignore_versions index b6de5f8..ce491e6 100644 --- a/localtests/generated-columns57-unique/ignore_versions +++ b/localtests/generated-columns57-unique/ignore_versions @@ -1 +1 @@ -(5.5|5.6) +(5.6) diff --git a/localtests/generated-columns57/ignore_versions b/localtests/generated-columns57/ignore_versions index b6de5f8..ce491e6 100644 --- a/localtests/generated-columns57/ignore_versions +++ b/localtests/generated-columns57/ignore_versions @@ -1 +1 @@ -(5.5|5.6) +(5.6) diff --git a/localtests/geometry57/ignore_versions b/localtests/geometry57/ignore_versions index b6de5f8..ce491e6 100644 --- a/localtests/geometry57/ignore_versions +++ b/localtests/geometry57/ignore_versions @@ -1 +1 @@ -(5.5|5.6) +(5.6) diff --git a/localtests/json57/ignore_versions b/localtests/json57/ignore_versions index b6de5f8..ce491e6 100644 --- a/localtests/json57/ignore_versions +++ b/localtests/json57/ignore_versions @@ -1 +1 @@ -(5.5|5.6) +(5.6) diff --git a/localtests/json57dml/ignore_versions b/localtests/json57dml/ignore_versions index b6de5f8..ce491e6 100644 --- a/localtests/json57dml/ignore_versions +++ b/localtests/json57dml/ignore_versions @@ -1 +1 @@ -(5.5|5.6) +(5.6) diff --git a/localtests/spatial57/ignore_versions b/localtests/spatial57/ignore_versions index b6de5f8..ce491e6 100644 --- a/localtests/spatial57/ignore_versions +++ b/localtests/spatial57/ignore_versions @@ -1 +1 @@ -(5.5|5.6) +(5.6) diff --git a/localtests/swap-pk-uk/ignore_versions b/localtests/swap-pk-uk/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/swap-pk-uk/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5) diff --git a/localtests/swap-uk-uk/ignore_versions b/localtests/swap-uk-uk/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/swap-uk-uk/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5) diff --git a/localtests/timestamp-to-datetime/ignore_versions b/localtests/timestamp-to-datetime/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/timestamp-to-datetime/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5) diff --git a/localtests/timestamp/ignore_versions b/localtests/timestamp/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/timestamp/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5) diff --git a/localtests/tz-datetime-ts/ignore_versions b/localtests/tz-datetime-ts/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/tz-datetime-ts/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5) diff --git a/localtests/tz/ignore_versions b/localtests/tz/ignore_versions deleted file mode 100644 index 7acd3f0..0000000 --- a/localtests/tz/ignore_versions +++ /dev/null @@ -1 +0,0 @@ -(5.5)