octoleo/gh-ost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #220 from Wattpad/exit-on-hook-replication-stop-failure

Browse Source 
Fail operation if onStopReplication hook fails
This commit is contained in:
Shlomi Noach 2016-09-02 09:39:43 +02:00 committed by GitHub
commit 75d225353f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
go/logic/migrator.go
View File

@ -408,7 +408,9 @@ func (this *Migrator) cutOver() (err error) {
// the same cut-over phase as the master would use. That means we take locks // the same cut-over phase as the master would use. That means we take locks
// and swap the tables. // and swap the tables.
// The difference is that we will later swap the tables back. // The difference is that we will later swap the tables back.
this.hooksExecutor.onStopReplication() if err := this.hooksExecutor.onStopReplication(); err != nil {
return err
}
if this.migrationContext.TestOnReplicaSkipReplicaStop { if this.migrationContext.TestOnReplicaSkipReplicaStop {
log.Warningf("--test-on-replica-skip-replica-stop enabled, we are not stopping replication.") log.Warningf("--test-on-replica-skip-replica-stop enabled, we are not stopping replication.")
} else { } else {