From 7a3912da80d396e77e301b9a69e181b362269df2 Mon Sep 17 00:00:00 2001 From: Shlomi Noach Date: Mon, 27 Mar 2017 08:33:06 +0300 Subject: [PATCH 1/3] fixing binlog syncer double-close() --- go/binlog/gomysql_reader.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/go/binlog/gomysql_reader.go b/go/binlog/gomysql_reader.go index 445617a..9feca87 100644 --- a/go/binlog/gomysql_reader.go +++ b/go/binlog/gomysql_reader.go @@ -160,6 +160,10 @@ func (this *GoMySQLReader) StreamEvents(canStopStreaming func() bool, entriesCha } func (this *GoMySQLReader) Close() error { - this.binlogSyncer.Close() + // Historically there was a: + // this.binlogSyncer.Close() + // here. A new go-mysql version closes the binlog syncer connection independently. + // I will go against the sacred rules of comments and just leave this here. + // This is the year 2017. Let's see what year these comments get deleted. return nil } From 3b5132bf2cd6b345989a492bf1525d4fef928d44 Mon Sep 17 00:00:00 2001 From: Shlomi Noach Date: Sun, 2 Apr 2017 10:43:45 +0300 Subject: [PATCH 2/3] supporting TravisCI --- .travis.yml | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 01078c0..079e425 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,20 @@ +# http://docs.travis-ci.com/user/languages/go/ language: go -go: - - 1.6 - - tip +go: 1.8 -script: ./test.sh +os: + - linux + +env: +- MYSQL_USER=root + +before_install: + - mysql -e 'CREATE DATABASE IF NOT EXISTS test;' + +install: true + +script: script/cibuild + +notifications: + email: false From 0d799b67ea692bf05a6ed5910e29ac6a0a045108 Mon Sep 17 00:00:00 2001 From: Shlomi Noach Date: Sun, 2 Apr 2017 10:46:36 +0300 Subject: [PATCH 3/3] Readme badges --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index f312d2f..04c032a 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,7 @@ # gh-ost +[![build status](https://travis-ci.org/github/gh-ost.svg)](https://travis-ci.org/github/gh-ost) [![downloads](https://img.shields.io/github/downloads/github/gh-ost/total.svg)](https://github.com/github/gh-ost/releases) [![release](https://img.shields.io/github/release/github/gh-ost.svg)](https://github.com/github/gh-ost/releases) + #### GitHub's online schema migration for MySQL `gh-ost` is a triggerless online schema migration solution for MySQL. It is testable and provides pausability, dynamic control/reconfiguration, auditing, and many operational perks.