Merge pull request #1097 from timvaillancourt/remove-eol-5.5

Remove end-of-life MySQL 5.5.x version
2022-02-25 15:01:35 +00:00 · 2022-02-25 15:01:35 +00:00 · e15166ecb9
commit e15166ecb9
parent d3ea39c669 31f3ac0c8b
21 changed files with 12 additions and 21 deletions
--- a/.github/workflows/replica-tests.yml
+++ b/.github/workflows/replica-tests.yml
@ -8,7 +8,7 @@ jobs:
    runs-on: ubuntu-latest
    strategy:
      matrix:
-        version: [mysql-5.5.62,mysql-5.6.43,mysql-5.7.25,mysql-8.0.16]
+        version: [mysql-5.6.43,mysql-5.7.25,mysql-8.0.16]

    steps:
    - uses: actions/checkout@v2
--- a/doc/requirements-and-limitations.md
+++ b/doc/requirements-and-limitations.md
@ -2,6 +2,8 @@

 ### Requirements

+- `gh-ost` currently requires MySQL versions 5.6 and greater.
+
 - You will need to have one server serving Row Based Replication (RBR) format binary logs. Right now `FULL` row image is supported. `MINIMAL` to be supported in the near future. `gh-ost` prefers to work with replicas. You may [still have your master configured with Statement Based Replication](migrating-with-sbr.md) (SBR).

 - If you are using a replica, the table must have an identical schema between the master and replica.
--- a/go/logic/inspect.go
+++ b/go/logic/inspect.go
@ -364,8 +364,7 @@ func (this *Inspector) validateBinlogs() error {
 	}
 	query = `select @@global.binlog_row_image`
 	if err := this.db.QueryRow(query).Scan(&this.migrationContext.OriginalBinlogRowImage); err != nil {
-		// Only as of 5.6. We wish to support 5.5 as well
-		this.migrationContext.OriginalBinlogRowImage = "FULL"
+		return err
 	}
 	this.migrationContext.OriginalBinlogRowImage = strings.ToUpper(this.migrationContext.OriginalBinlogRowImage)
 	if this.migrationContext.OriginalBinlogRowImage != "FULL" {
--- a/localtests/datetime-submillis-zeroleading/ignore_versions
+++ b/localtests/datetime-submillis-zeroleading/ignore_versions
@ -1 +0,0 @@
-(5.5)
--- a/localtests/datetime-submillis/ignore_versions
+++ b/localtests/datetime-submillis/ignore_versions
@ -1 +0,0 @@
-(5.5)
--- a/localtests/datetime-to-timestamp-pk-fail/ignore_versions
+++ b/localtests/datetime-to-timestamp-pk-fail/ignore_versions
@ -1 +0,0 @@
-(5.5)
--- a/localtests/datetime/ignore_versions
+++ b/localtests/datetime/ignore_versions
@ -1 +0,0 @@
-(5.5)
--- a/localtests/generated-columns-add57/ignore_versions
+++ b/localtests/generated-columns-add57/ignore_versions
@ -1 +1 @@
-(5.5|5.6)
+(5.6)
--- a/localtests/generated-columns-rename57/ignore_versions
+++ b/localtests/generated-columns-rename57/ignore_versions
@ -1 +1 @@
-(5.5|5.6)
+(5.6)
--- a/localtests/generated-columns57-unique/ignore_versions
+++ b/localtests/generated-columns57-unique/ignore_versions
@ -1 +1 @@
-(5.5|5.6)
+(5.6)
--- a/localtests/generated-columns57/ignore_versions
+++ b/localtests/generated-columns57/ignore_versions
@ -1 +1 @@
-(5.5|5.6)
+(5.6)
--- a/localtests/geometry57/ignore_versions
+++ b/localtests/geometry57/ignore_versions
@ -1 +1 @@
-(5.5|5.6)
+(5.6)
--- a/localtests/json57/ignore_versions
+++ b/localtests/json57/ignore_versions
@ -1 +1 @@
-(5.5|5.6)
+(5.6)
--- a/localtests/json57dml/ignore_versions
+++ b/localtests/json57dml/ignore_versions
@ -1 +1 @@
-(5.5|5.6)
+(5.6)
--- a/localtests/spatial57/ignore_versions
+++ b/localtests/spatial57/ignore_versions
@ -1 +1 @@
-(5.5|5.6)
+(5.6)
--- a/localtests/swap-pk-uk/ignore_versions
+++ b/localtests/swap-pk-uk/ignore_versions
@ -1 +0,0 @@
-(5.5)
--- a/localtests/swap-uk-uk/ignore_versions
+++ b/localtests/swap-uk-uk/ignore_versions
@ -1 +0,0 @@
-(5.5)
--- a/localtests/timestamp-to-datetime/ignore_versions
+++ b/localtests/timestamp-to-datetime/ignore_versions
@ -1 +0,0 @@
-(5.5)
--- a/localtests/timestamp/ignore_versions
+++ b/localtests/timestamp/ignore_versions
@ -1 +0,0 @@
-(5.5)
--- a/localtests/tz-datetime-ts/ignore_versions
+++ b/localtests/tz-datetime-ts/ignore_versions
@ -1 +0,0 @@
-(5.5)
--- a/localtests/tz/ignore_versions
+++ b/localtests/tz/ignore_versions
@ -1 +0,0 @@
-(5.5)