From e82d5633f915310077bfe652e9e7a60a48db7ab9 Mon Sep 17 00:00:00 2001 From: Nikhil Mathew Date: Mon, 18 Dec 2017 11:03:37 -0800 Subject: [PATCH] Close the binlog syncer --- go/binlog/gomysql_reader.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/go/binlog/gomysql_reader.go b/go/binlog/gomysql_reader.go index cb6d2b7..6016f81 100644 --- a/go/binlog/gomysql_reader.go +++ b/go/binlog/gomysql_reader.go @@ -158,10 +158,6 @@ func (this *GoMySQLReader) StreamEvents(canStopStreaming func() bool, entriesCha } func (this *GoMySQLReader) Close() error { - // Historically there was a: - // this.binlogSyncer.Close() - // here. A new go-mysql version closes the binlog syncer connection independently. - // I will go against the sacred rules of comments and just leave this here. - // This is the year 2017. Let's see what year these comments get deleted. + this.binlogSyncer.Close() return nil }