Commit Graph

466 Commits

Author SHA1 Message Date
Shlomi Noach
5dbd2e1c85 clarifying meaning of sleep-ratio 2016-08-18 13:13:51 +02:00
Shlomi Noach
d9ae2f3942 Merge pull request #156 from github/avoid-restarting-replication
accepting `--assume-rbr`, remove `SUPER` requirement
2016-08-18 10:11:35 +02:00
Shlomi Noach
508534976a assume-rbr and SUPER documentation
- introducing --assume-rbr
- discussing the implication of being able to run without SUPER
2016-08-18 10:09:06 +02:00
Daniël van Eeden
d3422bd19a Give more info about foreign keys
This helps when the table itself doesn't have foreign keys defined but if there are other tables with foreign keys pointing to the table on which gh-ost runs.

This gives INFO messages for each FK. Note that it now informs the user about `payment` being involved.
```
$ ./gh-ost -database sakila -table rental -alter 'ADD COLUMN ghost_test_001 tinyint DEFAULT NULL' -port 19590 -user msandbox -password msandbox -verbose
2016-08-03 10:18:45 INFO starting gh-ost 1.0.8
2016-08-03 10:18:45 INFO Migrating `sakila`.`rental`
2016-08-03 10:18:45 INFO connection validated on 127.0.0.1:19590
2016-08-03 10:18:45 INFO User has ALL privileges
2016-08-03 10:18:45 INFO binary logs validated on 127.0.0.1:19590
2016-08-03 10:18:45 INFO Restarting replication on 127.0.0.1:19590 to make sure binlog settings apply to replication thread
2016-08-03 10:18:46 INFO Table found. Engine=InnoDB
2016-08-03 10:18:47 INFO Found foreign key on `sakila`.`payment` related to `sakila`.`rental`
2016-08-03 10:18:47 INFO Found foreign key on `sakila`.`rental` related to `sakila`.`rental`
2016-08-03 10:18:47 INFO Found foreign key on `sakila`.`rental` related to `sakila`.`rental`
2016-08-03 10:18:47 INFO Found foreign key on `sakila`.`rental` related to `sakila`.`rental`
2016-08-03 10:18:47 ERROR Found 4 foreign keys related to `sakila`.`rental`. Foreign keys are not supported. Bailing out
2016-08-03 10:18:47 FATAL 2016-08-03 10:18:47 ERROR Found 4 foreign keys related to `sakila`.`rental`. Foreign keys are not supported. Bailing out
```

Related Issue: https://github.com/github/gh-ost/issues/129
2016-08-18 10:07:32 +02:00
Shlomi Noach
825c64fd62 Merge pull request #160 from github/fix-unsigned-columns
Fix unsigned columns
2016-08-17 13:22:05 +02:00
Shlomi Noach
3a0ee9b4a5 clarified commented transactional apply 2016-08-17 10:50:41 +02:00
Shlomi Noach
16d76aa299 builder fixes arg type from signed to unsigned based on UnsingedFlags 2016-08-17 06:52:23 +02:00
Shlomi Noach
29d20316ba inspector applies unsigned flags to all migration related columns 2016-08-17 06:51:58 +02:00
Shlomi Noach
f00a9814e6 legacy comments cleanup 2016-08-17 06:51:06 +02:00
Shlomi Noach
4c8edf6372 elaborate error message on applying event data: printing out the error, query and args 2016-08-17 06:50:40 +02:00
Shlomi Noach
7a0e2cfe3f adding UnsignedFlags to ColumnsList 2016-08-17 06:49:20 +02:00
Shlomi Noach
596dce5993 elaborate output on error in apply dml 2016-08-15 15:23:30 +02:00
Shlomi Noach
ac0b788153 rename trust-rbr to assume-rbr 2016-08-15 11:05:51 +02:00
Shlomi Noach
01d48e667c Merge pull request #143 from EasyPost/issue_142
Thank you
2016-08-15 10:53:36 +02:00
Shlomi Noach
20456c894e manual fix to branch 2016-08-12 16:21:29 +02:00
Shlomi Noach
1995be2b3f accepting --trust-rbr
- avoiding need to restart replication
- in turn avoiding need for SUPER
2016-08-12 14:26:58 +02:00
Shlomi Noach
98f6ddf00c merged dveeden-build_failfast 2016-08-12 13:04:17 +02:00
Shlomi Noach
8bf07c506f Merge pull request #147 from github/cleanup-socket-file
Cleanup socket file
2016-08-12 11:26:37 +02:00
Shlomi Noach
51111e0aa7 Merge pull request #155 from github/relaxed-log-slave-updates
relaxed check for log_slave_updates
2016-08-12 11:25:18 +02:00
Shlomi Noach
5001e7303f Merge pull request #152 from github/validate-no-triggers
testing for trigger existence
2016-08-12 11:24:20 +02:00
Shlomi Noach
a46022f727 localized function name 2016-08-11 17:37:50 +02:00
Shlomi Noach
66ff5964ed relaxed check for log_slave_updates 2016-08-11 14:49:14 +02:00
Shlomi Noach
95b4f9e440 testing for trigger existence 2016-08-11 14:10:35 +02:00
Shlomi Noach
bfe7e11790 Merge pull request #148 from github/master-master-limitation
doc: active-active master-master unsupported
2016-08-11 09:19:07 +02:00
Shlomi Noach
5d29e3dedd master-master unsupported 2016-08-11 09:18:22 +02:00
Shlomi Noach
a1f9c47102 Merge pull request #137 from dveeden/grants_info
Thank you
2016-08-11 09:07:48 +02:00
Shlomi Noach
35ff3f5b7b added log message 2016-08-11 09:03:39 +02:00
Shlomi Noach
dd1ef29dac cleaning up socket file 2016-08-11 09:01:14 +02:00
Shlomi Noach
0d62f362b7 Merge pull request #126 from dveeden/exec_buildsh
Thank you!
2016-08-11 08:50:54 +02:00
Shlomi Noach
1418395e99 Merge pull request #124 from dgryski/time-since
Thank you!
2016-08-11 08:50:06 +02:00
James Brown
b2fee9a037 detect IPv6 literals and wrap them in square brackets in GetDBUri 2016-08-05 16:54:26 -07:00
Ben Kochie
e48f4eecbc Merge pull request #139 from dveeden/typo_fix_autoinc
Fix typo: s/auto_incrmenet/auto_increment/
2016-08-05 17:51:30 +02:00
Daniël van Eeden
7786356a45 Fix typo: s/auto_incrmenet/auto_increment/ 2016-08-05 17:46:38 +02:00
Daniël van Eeden
95ba07e01b More user friendly error reporting for privileges
Related Issue: https://github.com/github/gh-ost/issues/136

New output:
```
2016-08-05 11:39:07 DEBUG Privileges: Super: true, REPLICATION SLAVE: false, ALL on *.*: false, ALL on `sakila`.*: true
2016-08-05 11:39:07 ERROR User has insufficient privileges for migration. Needed: SUPER, REPLICATION SLAVE and ALL on `sakila`.*
2016-08-05 11:39:07 FATAL 2016-08-05 11:39:07 ERROR User has insufficient privileges for migration. Needed: SUPER, REPLICATION SLAVE and ALL on `sakila`.*
```
2016-08-05 11:41:36 +02:00
Daniël van Eeden
d837c6b8e2 Set executable bits on build.sh 2016-08-04 07:13:46 +02:00
Ben Kochie
511e2c87c8 Merge pull request #125 from sethkrasnianski/sjk/typo
[go cmd] Correct spelling for main() comment
2016-08-02 17:24:33 +02:00
Seth Krasnianski
a94f64b42c [go cmd] Correct spelling for main() comment 2016-08-02 09:22:44 -04:00
Damian Gryski
e02a49449e all: use time.Since() instead of time.Now().Sub
Patch created with:
    gofmt -w -r 'time.Now().Sub(a) -> time.Since(a)' .
2016-08-02 08:38:56 -04:00
Shlomi Noach
97496d9a7e Clarifying row image requirement 2016-08-02 10:25:36 +02:00
Shlomi Noach
1c1869d876 Merge pull request #123 from adamvduke/patch-1
Thank you
2016-08-02 00:25:58 +02:00
Adam Duke
e695f239ec Fix README typo 2016-08-01 18:20:42 -04:00
Shlomi Noach
c73fcdc57c Merge pull request #122 from cflewis/patch-1
Thank you
2016-08-01 22:37:27 +02:00
Chris Lewis
c3d53cf419 Mention that Google Cloud SQL also requires SUPER 2016-08-01 12:46:42 -07:00
Shlomi Noach
f06b469227 Merge pull request #121 from github/release-1-0-8
release 1.0.8
2016-08-01 10:37:31 +02:00
Shlomi Noach
8e17880608 upped version 2016-08-01 10:36:17 +02:00
Shlomi Noach
6cd5915240 Merge pull request #119 from github/row-copy-start-mark
ETA counting rows, fixed copy time on count
2016-07-31 16:10:30 +02:00
Shlomi Noach
f11a39fb2a Merge pull request #120 from github/the-fine-print
adding The Fine Print documentation
2016-07-31 16:10:04 +02:00
Shlomi Noach
d20a82c2d2 README updates 2016-07-31 16:07:59 +02:00
Shlomi Noach
d2742e6c53 link to CONTRIBUTING.md from pull-requests template 2016-07-31 16:05:42 +02:00
Shlomi Noach
327fd70aa2 understanding output: updated with output improvements 2016-07-31 15:56:27 +02:00