Commit Graph

661 Commits

Author SHA1 Message Date
Shlomi Noach
c1a6773c02 better handling of --assume-master-host
separated logic and not even attempting to crawl topology
2016-10-11 16:42:19 +02:00
Shlomi Noach
dbf50afbc7 reading time_zone settings for Inspector and Applier separately.
--time-zone overrides both of them, if given
2016-10-11 16:00:26 +02:00
Shlomi Noach
5de8a010df restoring original row_event code; tampering with applier time_zone based on global timze_zone 2016-10-10 22:33:54 +02:00
Shlomi Noach
15f4ddfd8a support for --critical-load-interval-millis
this optional flag gives --critical-load a second chance. When configured to positive value, meeting with critical-load spawns a timer. When this timer expires a second check for critical-load is made; if still met, gh-ost bails out.
By default the interval is zero, in which case gh-ost bails out immediately on meeting critical load.
2016-10-10 13:21:01 +02:00
Shlomi Noach
4d4af07295 more tests for foreign keys, including expected failures 2016-10-10 12:29:25 +02:00
Shlomi Noach
a4d566e71c counting child vs parent sie foreign keys on table,
parent-side foreign keys cannot be discarded
2016-10-10 12:28:56 +02:00
Shlomi Noach
56e0833389 support for expect_failure on localtests 2016-10-10 12:28:13 +02:00
Shlomi Noach
a8f75f73ba supporting extra-args in tz tests 2016-10-10 11:43:43 +02:00
Shlomi Noach
6750959e1a configurable time-zone, native time parsing 2016-10-10 11:39:57 +02:00
Shlomi Noach
8e5c9cd5e1 adding fk tests 2016-10-08 11:07:01 +02:00
Shlomi Noach
0c35a811f7 setting time_zoe='+00:00' on rowcopy 2016-10-08 11:06:27 +02:00
Shlomi Noach
5d312a2bfb documenting --discard-foreign-keys flag 2016-10-07 10:23:52 +02:00
Shlomi Noach
1f65473e69 support for --discard-foreign-keys
This flag makes migration silently and happily discard any existing foreign keys on migrated table. This is useful for intentional dropping of foreign keys, as gh-ost does not otherwise have support for foreign key migration.
At some time in the future gh-ost may support foreign key migration, at which time this flag will be removed
2016-10-07 10:20:50 +02:00
Shlomi Noach
ef04fa49f5 assume-master-host now applied ImpliedKey 2016-10-06 12:00:34 +02:00
Shlomi Noach
72f63d3042 safe access to applier/inspector hostnames for hooks 2016-10-04 21:18:44 +02:00
Jonah Berquist
c749edccfd Merge pull request #253 from jbodah/patch-6
fix more docs typos
2016-09-30 10:42:26 -07:00
Josh Bodah
d008e40ac1 fix more docs typos 2016-09-30 12:39:50 -04:00
Jonah Berquist
c7f8795136 Merge pull request #252 from jbodah/patch-5
fix broken external mysql link in docs
2016-09-29 17:28:51 -07:00
Jonah Berquist
12d0d830d5 Merge pull request #251 from jbodah/patch-4
fix doc spelling
2016-09-29 17:28:03 -07:00
Josh Bodah
738531018b fix broken external mysql link in docs 2016-09-29 17:09:05 -04:00
Josh Bodah
a2444fe93e fix doc spelling 2016-09-29 16:24:04 -04:00
Shlomi Noach
f5d5cc8d8c Merge branch 'master' into test-datetime-timestamp 2016-09-29 10:20:59 +02:00
Shlomi Noach
bd19da618d Merge pull request #236 from Wattpad/binlog_insert_column_lookup_issue
Fix value fetch and convert issue in binlog insert path
2016-09-29 10:19:14 +02:00
Shlomi Noach
de2513b465 Merge pull request #249 from jbodah/patch-3
thank you!
2016-09-28 21:51:08 +02:00
Josh Bodah
52d7bc31ea Change docs from referencing gh-osc
Changes docs to use new exe name of `gh-ost` instead of old name `gh-osc`
2016-09-28 15:20:48 -04:00
Shlomi Noach
33ebc2d177 converting DATETIME values to UTC 2016-09-28 10:28:46 +02:00
Shlomi Noach
ddf4f88338 refined tests: tz-datetime only tests datetime issues; tz-datetime-ts converts datetime to timestamp 2016-09-28 10:28:21 +02:00
Shlomi Noach
420370433d adding datetime->timestamp conversion test 2016-09-28 09:44:05 +02:00
Shlomi Noach
51f0c0d957 fix arg conversion in BuildDMLUpdateQuery 2016-09-27 13:08:31 +02:00
Shlomi Noach
db2c8a254f added update/delete tests for multi-charset/alter tests 2016-09-27 12:57:05 +02:00
Shlomi Noach
109ddb0452 fixed integer random values 2016-09-27 12:56:37 +02:00
Shlomi Noach
253e0a1406 columns not null in test 2016-09-27 12:45:22 +02:00
Shlomi Noach
d32534710e added tests for unsigned rename/reorder 2016-09-27 12:41:46 +02:00
Shlomi Noach
e256e06826 Merge remote-tracking branch 'origin/master' into binlog_insert_column_lookup_issue 2016-09-27 11:05:59 +02:00
Shlomi Noach
a6b33427de Merge pull request #240 from github/test-column-reorder
added tests for column-reorder
2016-09-22 09:25:16 +02:00
Shlomi Noach
63419b3636 added test for renaming and reordering same column 2016-09-21 09:45:36 +02:00
Shlomi Noach
2bf882de16 added rename & reorder test 2016-09-21 09:01:33 +02:00
Jonah Berquist
f58a8be086 Merge pull request #241 from MichaelGooden/patch-1
Update documentation link.
2016-09-20 15:06:03 -07:00
Michael Gooden
008ff1f008 Update documentation link. 2016-09-20 22:30:41 +02:00
Shlomi Noach
53ef6eae5a added tests for column-reorder 2016-09-20 16:00:07 +02:00
Jonah Berquist
13b35478a1 Merge pull request #238 from jbodah/patch-2
Fix broken docs link in command-line-flags
2016-09-19 15:47:28 -07:00
Josh Bodah
36ab61c278 Fix broken docs link in command-line-flags 2016-09-19 14:57:34 -04:00
Paulo Bittencourt
8c5dcca187 Add test for modifying columns to different charsets 2016-09-19 09:37:08 -04:00
Paulo Bittencourt
2f80c9d424 Used the source column definition to fetch and convert insert values
When processing binlog insert statements, we want to use `sharedColumns`
to decide which values to fetch and convert from the insert DML event.

We only want to  `mappedShareColumns` to define the column names in the
`replace into ...` statement.
2016-09-14 11:28:30 -04:00
Paulo Bittencourt
25b5474cfa Add test case for renaming a column and only applying inserts
This catches a bug in `sql.BuildDMLInsertQuery` where we we are fetching
the insert values using the renamed column's name, and end up fetching
the value of the wrong column.

The test in `localtests/rename` did not catch this because binlog
update events were "correcting" the error, as they follow a different
code path that does not contain the bug.
2016-09-14 11:28:30 -04:00
Paulo Bittencourt
671fc71067 Add test case for altering a column's charset
This catches a bug in `sql.BuildDMLInsertQuery` where we are using the target
column's Charset to drive the value conversion.  In the case where we are
altering the charset, the Charset used for conversion will be different than
the original column's charset, resulting in an erroneous conversion.
2016-09-14 11:26:43 -04:00
Shlomi Noach
eac6a726de Merge pull request #231 from github/named-cut-over
Named cut over
2016-09-13 08:23:00 -07:00
Shlomi Noach
7517d48776 updated version 2016-09-13 05:35:43 -07:00
Shlomi Noach
a7627091a7 Merge branch 'master' into named-cut-over 2016-09-13 05:25:16 -07:00
Shlomi Noach
5215dd5999 Merge pull request #234 from github/vendor-charmap
added charset dependencies
2016-09-13 05:24:19 -07:00