octoleo/gh-ost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,240 Commits 51 Branches 51 Tags 24 MiB
766040d83f
Commit Graph

1240 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Josh Soref
4dda9cf930 spelling: aggressive 2017-11-08 00:44:30 +00:00
Shlomi Noach
0fd4603ae6 minor updates to test 2017-11-01 09:52:04 +02:00
Shlomi Noach
82b7f2a564
Merge pull request #517 from akshaychhajed/help-output-stdout 
Thank you!
 2017-11-01 09:34:30 +02:00
Akshay Chhajed
05fc358ed4 send -help output to stdout 2017-11-01 00:24:09 +05:30
Shlomi Noach
ca2340ae0a
Merge pull request #514 from druud62/druud62/doc 
Thank you!
 2017-10-29 06:41:56 +02:00
Ruud H.G. van Tol
ee0c56b7a5 doc/command-line-flags.md - normalize 2017-10-28 00:12:13 +02:00
Ruud H.G. van Tol
7cf8b42ae8 doc/command-line-flags.md - normalize links 2017-10-28 00:07:11 +02:00
Ruud H.G. van Tol
be53dbab0c doc/command-line-flags.md - oops 2017-10-27 23:39:23 +02:00
Ruud H.G. van Tol
e73206412f doc/command-line-flags.md - add --critical-load; normalize links 2017-10-27 23:34:48 +02:00
Ruud H.G. van Tol
bacb87cc74 doc/command-line-flags.md - normalize links 2017-10-27 23:13:31 +02:00
Ruud H.G. van Tol
10d1952dc6 doc/command-line-flags.md - add --heartbeat-interval-millis; normalize links 2017-10-27 23:02:23 +02:00
Ruud H.G. van Tol
772826e591 Revert "script/showdups - show all duplicate files in current repo" 
This reverts commit e75811fc5a.
 2017-10-27 10:48:51 +02:00
Ruud H.G. van Tol
88009e42a1 Revert "Tweaks" 
This reverts commit e01ea1c0de.
 2017-10-27 10:48:44 +02:00
Ruud H.G. van Tol
e01ea1c0de Tweaks 
Really, just tweaks.
 2017-10-27 02:28:10 +02:00
Ruud H.G. van Tol
e75811fc5a script/showdups - show all duplicate files in current repo 2017-10-27 02:18:37 +02:00
Ruud H.G. van Tol
038bd0124d Document replica-server-id command line option 2017-10-26 20:32:42 +02:00
Shlomi Noach
1a4bdbdcc2 Merge pull request #508 from github/better-localtest-diff-output 
better diff output in localtests
 2017-10-24 15:27:25 +03:00
Shlomi Noach
5b51a2863a better diff output in localtests 2017-10-24 15:25:08 +03:00
Shlomi Noach
f1a76e6866 Merge pull request #415 from github/touch-postpone-flag-file 
-postpone-cut-over-flag-file implies touching indicated file
 2017-10-18 08:07:39 +03:00
Shlomi Noach
4e6e454abd documenting --postpone-cut-over-flag-file 2017-10-18 08:05:55 +03:00
Shlomi Noach
087a6cc0cb Merge branch 'master' into touch-postpone-flag-file 2017-10-17 16:02:11 +03:00
Shlomi Noach
bdd2897510 Merge pull request #500 from github/enable-extra-port 
Enable extra port
 2017-10-17 10:02:19 +03:00
Nikhil Mathew
f06e23282e Merge branch 'master' into nm-refactor-migration-context 2017-10-02 10:31:57 -07:00
Shlomi Noach
aff7413624 clearer error message when not able to create postpone-cut-over-flag-file 2017-10-02 16:00:58 +03:00
Shlomi Noach
c2186db527 Merge branch 'master' into touch-postpone-flag-file 2017-10-02 15:55:21 +03:00
Shlomi Noach
5db266e4fa tests expecting ROW binlog format, gracefully waiting for replication to catch up 2017-10-02 15:52:31 +03:00
Shlomi Noach
9890e66755 Merge pull request #491 from zmoazeni/enable-extra-port 
Allow gh-ost to modify the server using extra port
 2017-10-02 14:26:59 +03:00
Shlomi Noach
dfc9f41342 Merge pull request #498 from dcadevil/master 
Thank you!
 2017-09-29 09:25:36 +01:00
Nikhil Mathew
84bdfdb1ad Cache DB connection pools on the migrationContext where applicable 2017-09-22 16:06:06 -07:00
Nikhil Mathew
5788ab5347 CR Revisions: Make concurrent operations safe 2017-09-22 15:17:58 -07:00
dcadevil
351bfe1a24 Correct spelling for initiateStreaming() comment. 2017-09-21 11:36:27 +08:00
Zach Moazeni
df27c5b76f Allow gh-ost to modify the server using extra port 
Both Percona and Maria allow MySQL to be configured to listen on an extra port when their thread pool is enable.

* https://www.percona.com/doc/percona-server/5.7/performance/threadpool.html
* https://mariadb.com/kb/en/the-mariadb-library/thread-pool-in-mariadb-51-53/

This is valuable because if the table has a lot of traffic (read or write load), gh-ost can end up starving the thread pool as incomming connections are immediately blocked.

By using gh-ost on the extra port, MySQL locking will still behave the same, but MySQL will keep a dedicated thread for each gh-ost connection.

When doing this, it's important to inspect the extra-max-connections variable. Both Percona and Maria default to 1, so gh-ost may easily exceed with its threads.

An example local run using this

```
$ mysql -S /tmp/mysql_sandbox20393.sock -e "select @@global.port, @@global.extra_port"
+---------------+---------------------+
| @@global.port | @@global.extra_port |
+---------------+---------------------+
|         20393 |               30393 |
+---------------+---------------------+

./bin/gh-ost \
--initially-drop-ghost-table \
--initially-drop-old-table \
--assume-rbr \
--port="20395" \
--assume-master-host="127.0.0.1:30393" \
--max-load=Threads_running=25 \
--critical-load=Threads_running=1000 \
--chunk-size=1000 \
--max-lag-millis=1500 \
--user="gh-ost" \
--password="gh-ost" \
--database="test" \
--table="mytable" \
--verbose \
--alter="ADD mynewcol decimal(11,2) DEFAULT 0.0 NOT NULL" \
--exact-rowcount \
--concurrent-rowcount \
--default-retries=120 \
--panic-flag-file=/tmp/ghost.panic.flag \
--postpone-cut-over-flag-file=/tmp/ghost.postpone.flag \
--execute
```
 2017-09-20 16:05:20 -04:00
Shlomi Noach
52f2dd7a20 release v1.0.42 2017-09-14 09:51:12 +03:00
Shlomi Noach
a46d5b54ea Merge pull request #494 from github/cfg-read-error 
Clearer error message on config file read error
 2017-09-10 19:54:13 +03:00
Shlomi Noach
6362dbe51a Clearer error message on config file read error 2017-09-10 08:20:01 +03:00
Shlomi Noach
a2847015d6 Merge branch 'master' into nm-refactor-migration-context 2017-09-10 08:08:39 +03:00
Shlomi Noach
3fc3446561 Merge pull request #489 from github/checking-thresholds 
Validating password length
 2017-09-06 15:36:46 +03:00
Shlomi Noach
bdae67f839 Merge branch 'master' into checking-thresholds 2017-09-06 15:24:04 +03:00
Shlomi Noach
8940649a32 Merge branch 'master' into checking-thresholds 2017-09-06 15:14:17 +03:00
Shlomi Noach
1ada323c03 Merge pull request #490 from boomballa/master 
Update the main.go word spelling error
 2017-09-06 10:19:29 +03:00
Peng Sung
113e115c49 Update the main.go word spelling error 2017-09-06 15:12:09 +08:00
Shlomi Noach
78c1e0432f Merge branch 'master' into checking-thresholds 2017-09-06 08:07:35 +03:00
Shlomi Noach
0eac2f8da5 Merge pull request #488 from github/check-unique-key-types 
Check unique key types
 2017-09-06 08:05:23 +03:00
Shlomi Noach
e464c83e13 added test 2017-09-05 06:56:19 +03:00
Shlomi Noach
7c47c722e3 tests belonged in another branch 2017-09-05 06:38:55 +03:00
Shlomi Noach
227f1de193 adding tests 2017-09-05 06:35:56 +03:00
Shlomi Noach
0924a459f2 adding tests 2017-09-05 06:34:26 +03:00
Shlomi Noach
e2171e0162 Validating password length 2017-09-03 10:27:04 +03:00
Shlomi Noach
3437cf44c4 Validating shared key column types 2017-09-03 09:57:26 +03:00
Shlomi Noach
933901e21e Validating shared key column types 2017-09-03 09:57:24 +03:00