Tim Vaillancourt
bf408b0d0e
Merge branch 'master' into master
2020-12-16 12:53:59 +01:00
Tim Vaillancourt
88e59dd2a3
Merge branch 'master' into master
2020-10-22 23:22:32 +02:00
Tim Vaillancourt
8c4cd10d79
Merge branch 'master' into ipv6
2020-10-22 11:39:46 +02:00
Tim Vaillancourt
0e2d33ad86
Merge in https://github.com/github/gh-ost/pull/755
2020-10-20 16:08:49 +02:00
Tim Vaillancourt
f268259f5e
Merge branch 'master' into handle_driver_timeout_error
2020-08-19 22:04:55 +02:00
Tim Vaillancourt
4bbc8deb77
Fix tabs from merge conflict
2020-08-13 15:50:38 +02:00
Tim Vaillancourt
5b6da5b7f3
Merge branch 'master' into handle_driver_timeout_error
2020-08-13 15:49:34 +02:00
Shlomi Noach
c9249f2b71
Updating and using AlterTableOptions
2020-07-23 11:38:05 +03:00
Shlomi Noach
f482356a94
Merge branch 'master' into parse-alter-statement
2020-07-22 12:36:59 +03:00
Shlomi Noach
6c7b4736e1
Support a complete ALTER TABLE statement in --alter
2020-07-22 12:33:02 +03:00
Justin Fudally
b02900ae06
Merge branch 'master' into logging-interface-contrib
2020-07-21 16:01:29 -05:00
Shuode Li
57955b968b
Merge branch 'master' into master
2020-05-06 00:15:57 -07:00
Andrew Mason
90ad7a061f
Handle the rest of rows.Err
cases
2020-04-21 12:50:23 -04:00
Andrew Mason
61de098072
Add a check to rows.Err after processing all rows
...
Closes #822 .
In https://github.com/go-sql-driver/mysql/issues/1075 , @acharis notes
that the way the go-sql driver is written, query timeout errors don't
get set in `rows.Err()` until _after_ a call to `rows.Next()` is made.
Because this kind of error means there will be no rows in the result
set, the `for rows.Next()` will never enter the for loop, so we must
check the value of `rows.Err()` after the loop, and surface the error up
appropriately.
2020-03-31 16:25:16 -04:00
Justin Fudally
2178b5947b
remove spammy error
2020-03-30 10:05:23 -05:00
Justin Fudally
5816ede7b3
add error message
2020-03-30 09:55:49 -05:00
Justin Fudally
7893f8e1c3
catch error in collectFunc
2020-03-30 09:53:10 -05:00
Justin Fudally
df60fa4204
add error logging
2020-03-25 16:06:17 -05:00
Justin Fudally
57cf5f3c90
add override to ignore http errors
2020-03-25 15:58:32 -05:00
Justin Fudally
ca0b822a3d
Add comment
2020-03-25 15:41:23 -05:00
Justin Fudally
64083e4705
Throttle on no metrics/error
2020-03-25 15:40:09 -05:00
Justin Fudally
0b2702bf53
Throttle on no metrics/error
2020-03-25 14:12:00 -05:00
Shuode Li
ae762694fb
Support Azure Database for MySQL.
2019-12-17 03:47:14 +00:00
Shlomi Noach
a36d6bee94
Merge branch 'logging-interface-contrib' into master
2019-12-11 07:03:37 +02:00
Shlomi Noach
d0ce7c014e
truncate lag digits
2019-10-23 10:18:56 +03:00
Abeyu M
f4676bf463
implement a logging interface
2019-10-07 11:10:36 -04:00
Shlomi Noach
21e7ec6b7c
lag: %+vs notation, e.g. 1s
2019-10-07 07:06:11 +03:00
Shlomi Noach
271c7274a3
refactor progressPct into migrationContext
2019-10-07 06:59:56 +03:00
Shlomi Noach
7869889988
context, status and hooks: progressPct and CurrentLag
2019-10-06 17:08:35 +03:00
Shlomi Noach
3175c2fe74
Merge branch 'master' into ggunson-panic-message
2019-08-13 08:39:43 +03:00
Gillian Gunson
3362c5d322
Changing panic message
2019-08-12 12:40:31 -07:00
Shlomi Noach
b881bff1e8
fixed linter issue
2019-08-11 15:06:03 +03:00
Shlomi Noach
f0ed7aeb0b
Always use NO_AUTO_VALUE_ON_ZERO
2019-03-24 11:32:42 +02:00
Shlomi Noach
7ae32f7184
Merge branch 'master' into skip-strict-mode
2019-03-17 23:49:13 -07:00
Shlomi Noach
7ead4c4a56
named throttle, no-throttle
2019-02-25 14:02:57 +02:00
Shlomi Noach
ff17d2f844
Merge branch 'master' into named-panic
2019-02-25 14:00:12 +02:00
babinomec
7d5749b84a
add --skip-strict-mode option
2019-02-14 15:58:49 +01:00
Shlomi Noach
9da2e21e03
Merge branch 'master' into add-tls-support
2019-02-10 11:27:36 +02:00
Brandon Bodnar
23617f287f
Add initial support for ssl encryption connections to database servers.
...
- Adding a command line option for users to enforce tls/ssl connections
for the applier, inspector, and binlog reader.
- The user can optionally request server certificate verification through
a command line option to specify the ca cert via a file path.
- Fixes an existing bug appending the timeout option to the singleton
applier connection.
2019-01-31 15:22:03 -06:00
Shlomi Noach
1671530300
Merge branch 'master' into hints-owner-token
2019-01-28 08:28:58 +02:00
Shlomi Noach
3161cd5823
added: --hooks-hint-owner, --hooks-hint-token
2019-01-24 13:06:20 +02:00
Shlomi Noach
93b88e262a
Auto-merged master into gh-ost/patch-1 on deployment
2019-01-23 08:13:55 +02:00
twotwotwo
afa108f8fa
inspect: remove redundant join conditions
...
The TABLE_SCHEMA and TABLE_NAME are already guaranteed to have the same value in COLUMNS and UNIQUES because of the WHEREs in each query. Dropping it from the ON clause makes it complete much faster.
On (at least) MySQL 5.6 installs with thousands of tables, this query completes in a few seconds without the additional join conditions, but takes more than a minute with it.
2019-01-22 12:26:55 -08:00
Shlomi Noach
809908cb1d
Merge branch 'master' into ipv6
2019-01-20 09:02:34 +02:00
Shlomi Noach
5f587c3262
Adding --force-named-panic option
2019-01-14 13:27:44 +02:00
Shlomi Noach
d32304520c
Merge branch 'master' into minor_changes
2019-01-14 10:45:27 +02:00
Shlomi Noach
419794e16d
Merge branch 'master' into master
2018-12-25 07:20:47 +02:00
黄恒
29e3d48c36
Merge branch 'master' into master
2018-12-11 13:12:47 +08:00
Eduardo Nunes
5f15f8a539
Remove not needed call by grouping columnLists
...
There is no need to call `applyColumnTypes` more than once for the same
`databaseName` and `tableName`, it is just move the additional
`columnList` to the first call.
2018-11-01 14:43:57 +01:00
Eduardo Nunes
dfc8aa28f4
Ignore not available columns when applying column types
...
The given `columnLists` may not contain all columns available in the
given table. This patch prevents the code to fail. Before this patch the
code was panicking whenever it was trying to set a value into a `nil`
object, e.g. `columnList.GetColumn('non-existant').Type = SomeType`.
For some reason the application was not completely failing but as a
side-effect any column after the non-existant column would never get its
Type properly set.
2018-11-01 14:33:11 +01:00
Shlomi Noach
60398e774f
Merge branch 'master' into add-dry-run-env
2018-10-02 14:08:08 +03:00
Shlomi Noach
6284a34823
Merge branch 'master' into ipv6
2018-10-02 08:12:15 +03:00
Shlomi Noach
7bd338faf7
Fix to retry logic in row copy
2018-09-20 10:49:21 +03:00
Jacob Bednarz
09a005d79e
Populate the env with dry run status
...
Updates the `applyEnvironmentVariables` function to populate whether or
not the current execution context is running as a dry run or not which
can then be used in hooks.
2018-09-18 14:41:26 +10:00
Shlomi Noach
04c0be6137
Merge branch 'master' into ipv6
2018-09-17 09:35:18 +03:00
Shlomi Noach
97c1e72dbe
Merge branch 'master' into minor_changes
2018-09-17 08:58:04 +03:00
Shlomi Noach
695e32d41b
Merge branch 'master' into dev_copyrow_hangs
2018-09-17 08:42:03 +03:00
Shlomi Noach
49b80df27b
Parsing ipv6 addresses
2018-09-16 11:44:52 +03:00
Shlomi Noach
32f1cf1dbe
Support for GCP (Google Cloud Platform)
2018-09-02 09:51:40 +03:00
钟越
ef686a4e7b
Support database with underscore
2018-08-31 09:31:58 +08:00
wangfei
c7dff99a19
fix copyRowsFunc hangs bug
2018-07-26 03:02:12 +08:00
MOON_CLJ
14eda7efe0
fix GetReplicationLag not used args
2018-05-23 13:13:25 +08:00
MOON_CLJ
21d455013e
minor changes and typo correction
2018-05-23 13:13:25 +08:00
Shlomi Noach
db871b42c4
Support for GENERATED (aka virtual) columns
2018-05-22 12:36:52 +03:00
Shlomi Noach
dfeefed5dc
avoid prepared statements for changelog table
2018-05-20 13:46:33 +03:00
Shlomi Noach
fb00a13871
Rejecting RENAME TO|AS
2018-05-06 11:19:03 +03:00
Shlomi Noach
160e7a11f5
Enforcing binlog_row_image=FULL
2018-04-24 05:56:03 -07:00
Shlomi Noach
3dc4930ae3
Merge branch 'master' into support-aliyun-rds
2018-04-16 14:17:03 +03:00
zj118228
d3b98d9e74
Refactor the code and remove the global variable of
...
support-aliyun-rds branch.
2018-03-29 12:20:41 +08:00
Kurt Kotzur
15e7417fc5
update comment
2018-03-19 12:29:49 -07:00
Kurt Kotzur
117b197b2a
Obey defaultNumRetries in retryOperationWithExponentialBackoff; name max interval flag more generically ( #2 )
...
* rename flags, obey defaultNumRetries
* capitalization fixes
* fix flag description typo
* fix sleep algorithm
2018-03-19 12:26:46 -07:00
Kurt Kotzur
628983f78f
🎨
2018-03-16 12:42:38 -07:00
Kurt Kotzur
64f66c4abb
add back nonFatalHint, fix type mismatches
2018-03-16 10:54:37 -07:00
Kurt Kotzur
bd62b19b0b
remove nonFatalHint argument from retryOperation; add retryOperationWithExponentialBackoff and conditionally use it
2018-03-15 17:41:15 -07:00
Shlomi Noach
bf01b31795
Merge branch 'master' into support-aliyun-rds
2018-03-07 16:39:55 +02:00
Shlomi Noach
9ae9cef17a
support quoted values in interactive commands
2018-02-25 19:17:37 +02:00
zj118228
6f3d54a136
Aliyun RDS hide some mysql variables for secrity so gh-ost will get
...
ilegal values. Add --aliyun-rds flag to avoid getting them.
2018-01-23 14:44:22 +08:00
Shlomi Noach
02579075d0
Call the throttler.Teardown
2018-01-11 08:03:09 +02:00
Nikhil Mathew
ec6ceffbcb
Pass in a migrationContext UUID for a migration specific connections cache
2017-12-14 15:53:29 -08:00
Nikhil Mathew
fac1ba7026
Throttler teardown
2017-12-14 15:14:13 -08:00
Shlomi Noach
0530b09700
Merge branch 'master' into nm-refactor-migration-context
2017-12-07 13:59:12 +02:00
Shlomi Noach
58c381f0a0
some cleanup
2017-11-21 09:14:04 +02:00
Shlomi Noach
203ea6c2cd
refactor, simplifid code
2017-11-20 10:24:28 +02:00
Shlomi Noach
3898d49f6c
supporting update to columns of migration key
2017-11-20 08:17:20 +02:00
Nikhil Mathew
538833ea84
Merge branch 'master' into nm-refactor-migration-context
2017-11-14 10:29:49 -08:00
Nikhil Mathew
2ad65ee1d7
Refactor usages of GetDB to use mysql
2017-11-10 15:44:22 -08:00
Shlomi Noach
8a59d7e823
failing on PK value change
2017-11-08 11:11:17 +02:00
Josh Soref
6bc04eee62
spelling: thing
2017-11-08 01:02:32 +00:00
Josh Soref
3196c890f5
spelling: running
2017-11-08 01:01:39 +00:00
Josh Soref
4c93b7ac6d
spelling: response
2017-11-08 00:55:09 +00:00
Josh Soref
961e2409f6
spelling: proceeding
2017-11-08 00:50:56 +00:00
Josh Soref
6a8d97c13f
spelling: progress
2017-11-08 00:50:48 +00:00
Josh Soref
867e6a28b3
spelling: merely
2017-11-08 00:49:51 +00:00
Josh Soref
e2df0b80eb
spelling: iterating
2017-11-08 00:49:23 +00:00
Josh Soref
2b430e3cb6
spelling: ignoring
2017-11-08 00:49:06 +00:00
Josh Soref
e608c16567
spelling: explicitly
2017-11-08 00:47:54 +00:00
Josh Soref
291c6d3594
spelling: entirely
2017-11-08 00:47:36 +00:00
Josh Soref
418462a6ca
spelling: dropping
2017-11-08 00:47:15 +00:00
Josh Soref
8901e6eec2
spelling: decision
2017-11-08 00:46:04 +00:00
Josh Soref
d29993ffda
spelling: changelog
2017-11-08 00:45:19 +00:00